New issue
Advanced search Search tips

Issue 819657 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

fake_auth_policy_client: Device policy is not persisted

Project Member Reported by rsorokin@chromium.org, Mar 7 2018

Issue description

FakeAuthPolicyClient: RefreshDevicePolicy should store saved device policy

E.g. it is unusable for tests to set specific device policies.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bb304e76e3c22677f5f8993c88724db31fce957

commit 9bb304e76e3c22677f5f8993c88724db31fce957
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Tue Mar 20 04:44:58 2018

FakeAuthPolicyClient: RefreshDevicePolicy stores saved device policy

RefreshDevicePolicy stores saved device policy in the session manager.
E.g. it is unusable for tests to set specific device policies.

BUG= chromium:819657 
TEST=FakeAuthPolicyClientTest.RefreshDevicePolicyStoresPolicy

Change-Id: Id90e090453da27ffa4527ed810bc1f45c5337a3a
Reviewed-on: https://chromium-review.googlesource.com/955842
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544281}
[modify] https://crrev.com/9bb304e76e3c22677f5f8993c88724db31fce957/chromeos/dbus/fake_auth_policy_client.cc
[modify] https://crrev.com/9bb304e76e3c22677f5f8993c88724db31fce957/chromeos/dbus/fake_auth_policy_client.h
[modify] https://crrev.com/9bb304e76e3c22677f5f8993c88724db31fce957/chromeos/dbus/fake_auth_policy_client_unittest.cc

Description: Show this description
Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Marked verified base on code reviews and no issue with test device policies.

Sign in to add a comment