New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 819649 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Abrt in base::BasicStringPiece<std::__1::basic_string<char, std::__1::char_traits<char>,

Project Member Reported by ClusterFuzz, Mar 7 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6022352593485824

Fuzzer: libFuzzer_signed_exchange_header_parser_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x0539000052f5
Crash State:
  base::BasicStringPiece<std::__1::basic_string<char, std::__1::char_traits<char>,
  content::StructuredHeaderParser::ReadString
  content::StructuredHeaderParser::ReadItem
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=541193:541201

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6022352593485824

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 7 2018

Components: Blink>Loader
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Cc: brajkumar@chromium.org
Labels: -Type-Bug M-67 Test-Predator-Wrong Type-Bug-Regression
Owner: palmer@chromium.org
Status: Assigned (was: Untriaged)
Predator could not provide any possible suspects.

From the below CL observing some changes related to 'StringPiece' hence suspecting the same
https://chromium.googlesource.com/chromium/src/+log/99ce3024704f4edcf3ca9341c4869f26f4229870..e5a6dfada32caaccc93e4f3ca4cb0bd0f6cdd019?pretty=fuller&n=10000

Suspect CL: https://chromium.googlesource.com/chromium/src/+/e5a6dfada32caaccc93e4f3ca4cb0bd0f6cdd019

palmer@ -- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!
Cc: palmer@chromium.org jyasskin@chromium.org
Owner: ksakamoto@chromium.org
ksakamoto: We added bounds checking to StringPiece, and it looks like we got a hit. Can you please take a look? Thanks!
Cc: ksakamoto@chromium.org
 Issue 819650  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6857c152c403a7684d742928e04ea7128c82ce21

commit 6857c152c403a7684d742928e04ea7128c82ce21
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Mon Mar 12 06:33:47 2018

Fix possible out-of-range access in StructuredHeaderParser::ReadString()

Bug:  819649 
Change-Id: I44905d1b25690bdfa8f652e2e56b5ca868996df4
Reviewed-on: https://chromium-review.googlesource.com/958764
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542430}
[modify] https://crrev.com/6857c152c403a7684d742928e04ea7128c82ce21/content/browser/web_package/signed_exchange_header_parser.cc
[modify] https://crrev.com/6857c152c403a7684d742928e04ea7128c82ce21/content/browser/web_package/signed_exchange_header_parser_unittest.cc

Status: Fixed (was: Assigned)
Project Member

Comment 8 by ClusterFuzz, Mar 13 2018

ClusterFuzz has detected this issue as fixed in range 542429:542430.

Detailed report: https://clusterfuzz.com/testcase?key=6022352593485824

Fuzzer: libFuzzer_signed_exchange_header_parser_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x0539000052f5
Crash State:
  base::BasicStringPiece<std::__1::basic_string<char, std::__1::char_traits<char>,
  content::StructuredHeaderParser::ReadString
  content::StructuredHeaderParser::ReadItem
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=541193:541201
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=542429:542430

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6022352593485824

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Mar 15 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6022352593485824 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment