Issue 819645 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	sorin@chromium.org
Closed:	Mar 2018
Cc:	waff...@chromium.org
Components:	Internals>Installer>Components
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

Make Task a ref counted object in the UpdateClient implementation

Project Member Reported by sorin@chromium.org, Mar 7 2018

Issue description

We'd like to avoid using unmanaged pointers for Task. These objects are stored in containers and passed as arguments to callbacks and other functions. A refcounted pointer is a good choice.

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7e356502b4f25d5ef698c7f50f8aaa72bc07923

commit f7e356502b4f25d5ef698c7f50f8aaa72bc07923
Author: Sorin Jianu <sorin@chromium.org>
Date: Wed Mar 07 20:54:34 2018

Make Task a ref counted object in the UpdateClient implementation.

Bug:  819645 
Change-Id: Iff4fbf906aa5e066db462aa41365e158969bc9b2
Reviewed-on: https://chromium-review.googlesource.com/953065
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541571}
[modify] https://crrev.com/f7e356502b4f25d5ef698c7f50f8aaa72bc07923/components/update_client/task.h
[modify] https://crrev.com/f7e356502b4f25d5ef698c7f50f8aaa72bc07923/components/update_client/task_send_uninstall_ping.cc
[modify] https://crrev.com/f7e356502b4f25d5ef698c7f50f8aaa72bc07923/components/update_client/task_send_uninstall_ping.h
[modify] https://crrev.com/f7e356502b4f25d5ef698c7f50f8aaa72bc07923/components/update_client/task_update.cc
[modify] https://crrev.com/f7e356502b4f25d5ef698c7f50f8aaa72bc07923/components/update_client/task_update.h
[modify] https://crrev.com/f7e356502b4f25d5ef698c7f50f8aaa72bc07923/components/update_client/update_client.cc
[modify] https://crrev.com/f7e356502b4f25d5ef698c7f50f8aaa72bc07923/components/update_client/update_client_internal.h

Comment 2 by sorin@chromium.org, Mar 7 2018

Status: Fixed (was: Untriaged)

►

Issue 819645 link

Issue metadata

Make Task a ref counted object in the UpdateClient implementation

Issue description

Comment 1 by bugdroid1@chromium.org, Mar 7 2018

Comment 1 Deleted

Comment 2 by sorin@chromium.org, Mar 7 2018

Comment 2 Deleted

Sign in to add a comment