SetLocalDescription returns wrong error when called in wrong state |
|||||||
Issue descriptionIf SetLocalDescription(answer) is called when there is no active call, "OperationError" is returned. "InvalidStateError" should have been returned. Spec: http://w3c.github.io/webrtc-pc/#set-description bullet 2 WPT test: RTCPeerConnection-setLocalDescription
,
Mar 8 2018
,
Mar 9 2018
,
Mar 9 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/5081c0cc6d79cbf7dd73025d99392a3950d8236c commit 5081c0cc6d79cbf7dd73025d99392a3950d8236c Author: Harald Alvestrand <hta@webrtc.org> Date: Fri Mar 09 15:37:34 2018 Change error handlers for Set*Description to use RTCError Needed in order to return error codes to Chromium. Bug: chromium:819629 , chromium:589455 Change-Id: Iab22250db62a348eee21c6d8bfc44020a7380586 Reviewed-on: https://webrtc-review.googlesource.com/60522 Commit-Queue: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22367} [modify] https://crrev.com/5081c0cc6d79cbf7dd73025d99392a3950d8236c/api/jsep.h [modify] https://crrev.com/5081c0cc6d79cbf7dd73025d99392a3950d8236c/pc/peerconnection.cc [modify] https://crrev.com/5081c0cc6d79cbf7dd73025d99392a3950d8236c/pc/peerconnection.h [modify] https://crrev.com/5081c0cc6d79cbf7dd73025d99392a3950d8236c/pc/peerconnection_jsep_unittest.cc [modify] https://crrev.com/5081c0cc6d79cbf7dd73025d99392a3950d8236c/pc/test/mockpeerconnectionobservers.h [modify] https://crrev.com/5081c0cc6d79cbf7dd73025d99392a3950d8236c/pc/test/peerconnectiontestwrapper.h
,
Mar 14 2018
,
Mar 17 2018
,
Mar 17 2018
,
Apr 18 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/3725d544fad8b676246d8aaeb18fbd50b46f1b06 commit 3725d544fad8b676246d8aaeb18fbd50b46f1b06 Author: Harald Alvestrand <hta@webrtc.org> Date: Wed Apr 18 17:02:24 2018 Change PeerConnection error codes Change error code for "state mismatch" to "State error", and also change some parameter errors to "Illegal parameter". Bug: chromium:819629 Change-Id: I9347d4161344b4ff2bcb58ad82fa6d533cd476fb Reviewed-on: https://webrtc-review.googlesource.com/69815 Reviewed-by: Benjamin Wright <benwright@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22924} [modify] https://crrev.com/3725d544fad8b676246d8aaeb18fbd50b46f1b06/pc/peerconnection.cc
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/246303e4f75d26ed8bae4524681a45a68007d61f commit 246303e4f75d26ed8bae4524681a45a68007d61f Author: Harald Alvestrand <hta@chromium.org> Date: Wed Apr 18 17:04:04 2018 Land WebRTC CL 69815 Bug: chromium:819629 Change-Id: Ia004db9e52cb147a1948de604d840387dff3379f Reviewed-on: https://chromium-review.googlesource.com/1017200 Reviewed-by: Tommi <tommi@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#551723} [modify] https://crrev.com/246303e4f75d26ed8bae4524681a45a68007d61f/third_party/WebKit/LayoutTests/TestExpectations
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/186f72d873258d184d5eba46512e68049564f591 commit 186f72d873258d184d5eba46512e68049564f591 Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Apr 19 02:04:00 2018 Roll src/third_party/webrtc/ 8619e8a3d..8e0b15b58 (4 commits) https://webrtc.googlesource.com/src.git/+log/8619e8a3d785..8e0b15b584b4 $ git log 8619e8a3d..8e0b15b58 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:819629 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I362ff24ce71e989cdb6d903714865ee0c9b35b3f Reviewed-on: https://chromium-review.googlesource.com/1017914 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551920} [modify] https://crrev.com/186f72d873258d184d5eba46512e68049564f591/DEPS
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af72d3648749821d07ecb6e7fdc96b792241ed47 commit af72d3648749821d07ecb6e7fdc96b792241ed47 Author: Harald Alvestrand <hta@chromium.org> Date: Fri Apr 20 11:21:19 2018 Reenable and rebase WebRTC createAnswer test Bug: chromium:819629 Change-Id: I8809c5fe6e46081629db94d6fbba98e894b7bf10 Reviewed-on: https://chromium-review.googlesource.com/1018463 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#552302} [modify] https://crrev.com/af72d3648749821d07ecb6e7fdc96b792241ed47/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/af72d3648749821d07ecb6e7fdc96b792241ed47/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-createAnswer-expected.txt
,
May 28 2018
Is this finished?
,
May 28 2018
,
Jun 7 2018
[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable? |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by hta@chromium.org
, Mar 7 2018