Implement password filling on focus for iOS |
||||
Issue description
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b160f7f010dd2a32595f4ac1b2d3903010ced0c0 commit b160f7f010dd2a32595f4ac1b2d3903010ced0c0 Author: vasilii <vasilii@chromium.org> Date: Fri Mar 23 18:12:40 2018 Change password suggestion UI on iOS. - The suggestions should include bullets according to the mock. - The suggested values should always include all the passwords regardless of what is typed into the username field. Bug: 819626 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ied795b335e00052f3629c2a0f30e26b9e51458b3 Reviewed-on: https://chromium-review.googlesource.com/978218 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#545519} [modify] https://crrev.com/b160f7f010dd2a32595f4ac1b2d3903010ced0c0/ios/chrome/browser/passwords/account_select_fill_data.cc [modify] https://crrev.com/b160f7f010dd2a32595f4ac1b2d3903010ced0c0/ios/chrome/browser/passwords/account_select_fill_data.h [modify] https://crrev.com/b160f7f010dd2a32595f4ac1b2d3903010ced0c0/ios/chrome/browser/passwords/account_select_fill_data_unittest.cc [modify] https://crrev.com/b160f7f010dd2a32595f4ac1b2d3903010ced0c0/ios/chrome/browser/passwords/password_controller.mm [modify] https://crrev.com/b160f7f010dd2a32595f4ac1b2d3903010ced0c0/ios/chrome/browser/passwords/password_controller_unittest.mm
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1faaeeaacb7ba4f2d799374be9a83e4902d3b11 commit e1faaeeaacb7ba4f2d799374be9a83e4902d3b11 Author: Vadym Doroshenko <dvadym@chromium.org> Date: Wed Mar 28 11:17:14 2018 [iOS Password Manager] Show suggestions on password fields. This CL implements showing suggestions on any password field and filling both username and password fields. Bug: 819626 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id8b6568ccef6a925d98502e47ab65e00861f15b8 Reviewed-on: https://chromium-review.googlesource.com/970827 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#546454} [modify] https://crrev.com/e1faaeeaacb7ba4f2d799374be9a83e4902d3b11/ios/chrome/browser/passwords/account_select_fill_data.cc [modify] https://crrev.com/e1faaeeaacb7ba4f2d799374be9a83e4902d3b11/ios/chrome/browser/passwords/account_select_fill_data.h [modify] https://crrev.com/e1faaeeaacb7ba4f2d799374be9a83e4902d3b11/ios/chrome/browser/passwords/account_select_fill_data_unittest.cc [modify] https://crrev.com/e1faaeeaacb7ba4f2d799374be9a83e4902d3b11/ios/chrome/browser/passwords/password_controller.mm [modify] https://crrev.com/e1faaeeaacb7ba4f2d799374be9a83e4902d3b11/ios/chrome/browser/passwords/password_controller_unittest.mm
,
Mar 28 2018
,
Apr 3 2018
Verified in M67.0.3387.0 canary iOS: 11.4beta#1, 11.2.6, 10.3.3 Devices: iPhone, iPad Show All is displayed when tapping inside Username/Password fields.
,
Apr 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62f32b393f5559c1862657c71e240ae9f1035e6e commit 62f32b393f5559c1862657c71e240ae9f1035e6e Author: vasilii <vasilii@chromium.org> Date: Thu Apr 12 14:55:04 2018 Introduce UMA metrics for user interactions with password suggestions on iOS. Bug: 819626 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4ea56f1d4d7d12184b2fdfbdbc9c44330b72b94e Reviewed-on: https://chromium-review.googlesource.com/1007059 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#550193} [modify] https://crrev.com/62f32b393f5559c1862657c71e240ae9f1035e6e/ios/chrome/browser/passwords/password_controller.mm [modify] https://crrev.com/62f32b393f5559c1862657c71e240ae9f1035e6e/tools/metrics/histograms/enums.xml [modify] https://crrev.com/62f32b393f5559c1862657c71e240ae9f1035e6e/tools/metrics/histograms/histograms.xml
,
Apr 17 2018
Verified on chrome canary version 68.0.3398.0 on iPhone 8 plus with iOS 11.4, 11.3. Suggestions are displayed when tapped in password field. Looks good.
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62f32b393f5559c1862657c71e240ae9f1035e6e commit 62f32b393f5559c1862657c71e240ae9f1035e6e Author: vasilii <vasilii@chromium.org> Date: Thu Apr 12 14:55:04 2018 Introduce UMA metrics for user interactions with password suggestions on iOS. Bug: 819626 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4ea56f1d4d7d12184b2fdfbdbc9c44330b72b94e Reviewed-on: https://chromium-review.googlesource.com/1007059 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#550193} [modify] https://crrev.com/62f32b393f5559c1862657c71e240ae9f1035e6e/ios/chrome/browser/passwords/password_controller.mm [modify] https://crrev.com/62f32b393f5559c1862657c71e240ae9f1035e6e/tools/metrics/histograms/enums.xml [modify] https://crrev.com/62f32b393f5559c1862657c71e240ae9f1035e6e/tools/metrics/histograms/histograms.xml |
||||
►
Sign in to add a comment |
||||
Comment 1 by vasi...@chromium.org
, Mar 23 2018308 KB
308 KB View Download