New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 819595 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 781754



Sign in to add a comment

Implement Service Workers in the WebView Support Library

Project Member Reported by gsennton@chromium.org, Mar 7 2018

Issue description

corresponding android bug: b/73151166
 
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/824511444f1772442551af893e3e0fdeafed177a

commit 824511444f1772442551af893e3e0fdeafed177a
Author: Gustav Sennton <gsennton@google.com>
Date: Thu Mar 22 09:47:25 2018

[WebView Support Library] Support service worker APIs.

Provide (chromium-side) support for ServiceWorkers in the WebView
Support Library.
We'll add feature flags for the ServiceWorker APIs in a follow-up.

Bug:  819595 
Change-Id: Id4c79e3970706633e36b28538c443a00c7e59e03
Reviewed-on: https://chromium-review.googlesource.com/964142
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Gustav Sennton <gsennton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545024}
[modify] https://crrev.com/824511444f1772442551af893e3e0fdeafed177a/android_webview/support_library/BUILD.gn
[modify] https://crrev.com/824511444f1772442551af893e3e0fdeafed177a/android_webview/support_library/boundary_interfaces/BUILD.gn
[add] https://crrev.com/824511444f1772442551af893e3e0fdeafed177a/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/ServiceWorkerClientBoundaryInterface.java
[add] https://crrev.com/824511444f1772442551af893e3e0fdeafed177a/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/ServiceWorkerControllerBoundaryInterface.java
[add] https://crrev.com/824511444f1772442551af893e3e0fdeafed177a/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/ServiceWorkerWebSettingsBoundaryInterface.java
[modify] https://crrev.com/824511444f1772442551af893e3e0fdeafed177a/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/WebViewProviderFactoryBoundaryInterface.java
[add] https://crrev.com/824511444f1772442551af893e3e0fdeafed177a/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibServiceWorkerClientAdapter.java
[add] https://crrev.com/824511444f1772442551af893e3e0fdeafed177a/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibServiceWorkerControllerAdapter.java
[add] https://crrev.com/824511444f1772442551af893e3e0fdeafed177a/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibServiceWorkerSettingsAdapter.java
[modify] https://crrev.com/824511444f1772442551af893e3e0fdeafed177a/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc82b2cb5c9e356f3a5502de77b17a2133a64d9f

commit cc82b2cb5c9e356f3a5502de77b17a2133a64d9f
Author: Gustav Sennton <gsennton@google.com>
Date: Fri Apr 06 17:13:53 2018

[android webview] Add feature flags for lots of APIs

We need to guard support library method calls with feature flags to
ensure the methods are only called on webview / support library version
where they're supported.
In this CL we add feature flags for various APIs related to
WebSettings, SafeBrowsing, and ServiceWorkers.

Bug:  828612 
Bug:  819595 
Bug:  816506 
Change-Id: Ice5f5645040ab7316ef90322812ca6319e8a2351
Reviewed-on: https://chromium-review.googlesource.com/995933
Commit-Queue: Gustav Sennton <gsennton@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548828}
[modify] https://crrev.com/cc82b2cb5c9e356f3a5502de77b17a2133a64d9f/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/util/Features.java
[modify] https://crrev.com/cc82b2cb5c9e356f3a5502de77b17a2133a64d9f/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80014088129f132550388a25098070937c8fff8f

commit 80014088129f132550388a25098070937c8fff8f
Author: Gustav Sennton <gsennton@google.com>
Date: Mon Apr 09 22:59:46 2018

[android webview] Future-proof ServiceWorker...shouldInterceptRequest

Guard the callback ServiceWorkerClientCompat.shouldInterceptRequest with
a feature flag to ensure that if we ever remove/replace that callback
from the support library in the future, existing WebView APKs won't call
into it.

Bug:  819595 
Change-Id: Id9796f695cc9fd66caf5739efeb77dd02e215821
Reviewed-on: https://chromium-review.googlesource.com/998164
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Gustav Sennton <gsennton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549312}
[modify] https://crrev.com/80014088129f132550388a25098070937c8fff8f/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/ServiceWorkerClientBoundaryInterface.java
[modify] https://crrev.com/80014088129f132550388a25098070937c8fff8f/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/util/BoundaryInterfaceReflectionUtil.java
[modify] https://crrev.com/80014088129f132550388a25098070937c8fff8f/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibServiceWorkerClientAdapter.java
[modify] https://crrev.com/80014088129f132550388a25098070937c8fff8f/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java

Status: Fixed (was: Assigned)

Sign in to add a comment