thomasanderson@, could you ptal?

yanp.bugz@ Thanks for the issue.

Tested this issue on Xfce desktop environment by following the below steps.

1. Installed Xfce desktop environment and logged into it.
2. Launched Chrome 64 version - 64.0.3282.186 and 65 Beta version - 65.0.3325.125 and compared the window icons.
Couldn't find any difference in the windows icons.
Tried to check the issue on latest Stable 65.0.3325.146, but couldn't enter any commands into the terminal.
On hitting the restart button on xfce, the system is stuck and unable to login in back to xfce.

thomasanderson@ Request you to please help in further triaging of this issue.

Thanks..

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fee6a987d967474df89a8d967fe0e60bf8d5dd5b

commit fee6a987d967474df89a8d967fe0e60bf8d5dd5b
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Thu Mar 08 17:59:01 2018

Fix XFCE frame buttons rendering too large on GTK < 3.20

Prior to GTK 3.20, a background-size set to "contain" would actually behave like
it was "stretch".  This was causing frame button images to render too large on
Greybird (XFCE theme) and Breeze (KDE theme).  Since the issue the CSS override
was fixing is not applicable to GTK < 3.20 (symbolic icons were used for these
versions), only apply the CSS if the GTK version is >= 3.20.

BUG= 819594 
R=erg
TBR=estade

Change-Id: I91807e4b5675b56647e2da1be5284e68a7bc7c3a
Reviewed-on: https://chromium-review.googlesource.com/954419
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541834}
[modify] https://crrev.com/fee6a987d967474df89a8d967fe0e60bf8d5dd5b/chrome/browser/ui/libgtkui/nav_button_provider_gtk3.cc

Requesting merge to M65 and M66.

This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

M65 is already out at 100% for Linux since Tuesday, 03/06. Is this critical to merge this fix to M65 or can it wait until M66?

It's just a visual issue, so not critical

Discussed with govind@ offline.  I believe the change is super-safe since it just adds one conditional, and that conditional just reverts back to the old behavior from before r526631.  The current plan is to merge to M66 now and merge to M65 once the fix is verified in dev.

Approving merge to M66 branch 3359 based on comment #10. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19381da3c4d6e03da419e321616e0643790833e0

commit 19381da3c4d6e03da419e321616e0643790833e0
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Thu Mar 08 20:44:51 2018

[Merge to M66] Fix XFCE frame buttons rendering too large on GTK < 3.20

> Prior to GTK 3.20, a background-size set to "contain" would actually behave like
> it was "stretch".  This was causing frame button images to render too large on
> Greybird (XFCE theme) and Breeze (KDE theme).  Since the issue the CSS override
> was fixing is not applicable to GTK < 3.20 (symbolic icons were used for these
> versions), only apply the CSS if the GTK version is >= 3.20.
>
> BUG= 819594 
> R=erg
> TBR=estade
>
> Change-Id: I91807e4b5675b56647e2da1be5284e68a7bc7c3a
> Reviewed-on: https://chromium-review.googlesource.com/954419
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541834}

BUG= 819594 
TBR=erg
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: I8a4e396e068c50de1e7abcbfc2e5ab297e336c9d
Reviewed-on: https://chromium-review.googlesource.com/956317
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#114}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/19381da3c4d6e03da419e321616e0643790833e0/chrome/browser/ui/libgtkui/nav_button_provider_gtk3.cc

Pls verify the fix on Chrome Dev version 66.0.3359.22. Thank you.
.

Verified on 66.0.3359.22 dev.  Frame buttons are normal sized on XFCE now.

Deleted: Screenshot from 2018-03-09 11-44-00.png 93.5 KB

	Screenshot from 2018-03-09 11-44-00.png 93.5 KB View Download

This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Didn't notice any other regressions.  This change should only affect desktop Linux.

Approving merge to M65 branch 3325 based on comments #10, 14 and #18. Please merge ASAP. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb9332da74009750df2f40a041f5491d5eb0280b

commit cb9332da74009750df2f40a041f5491d5eb0280b
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Fri Mar 09 20:29:33 2018

[Merge to M65] Fix XFCE frame buttons rendering too large on GTK < 3.20

> Prior to GTK 3.20, a background-size set to "contain" would actually behave like
> it was "stretch".  This was causing frame button images to render too large on
> Greybird (XFCE theme) and Breeze (KDE theme).  Since the issue the CSS override
> was fixing is not applicable to GTK < 3.20 (symbolic icons were used for these
> versions), only apply the CSS if the GTK version is >= 3.20.
>
> BUG= 819594 
> R=erg
> TBR=estade
>
> Change-Id: I91807e4b5675b56647e2da1be5284e68a7bc7c3a
> Reviewed-on: https://chromium-review.googlesource.com/954419
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541834}

BUG= 819594 
TBR=estade
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: Ic12d428b8c3a8d6daa14468e13ba18710ec9206f
Reviewed-on: https://chromium-review.googlesource.com/957447
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#683}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/cb9332da74009750df2f40a041f5491d5eb0280b/chrome/browser/ui/libgtkui/nav_button_provider_gtk3.cc

Tested the issue using latest M65: 65.0.3325.159 on Linux Debian Rodete as per the steps mentioned below. Could not observe any difference between #65.0.3325.146 and #65.0.3325.159 the versions.

Please find the below screenshots.

Thanks!!

Deleted: 65.0.3325.159.JPG 94.2 KB

	65.0.3325.159.JPG 94.2 KB View Download

Deleted: 65.0.3325.146.JPG 77.1 KB

	65.0.3325.146.JPG 77.1 KB View Download

Tested the issue using #65.0.3325.162 on Linux Debian Rodete, XFCE DE as per the steps mentioned in original comment. Did not observe any difference. 

Please find the screenshot and confirm about the fix.

Thanks!!

Deleted: 819594 - 162.JPG 69.8 KB

	819594 - 162.JPG 69.8 KB View Download

c#21, c#22: You're using the Adwaita (GNOME) theme.  You need to be using the Greybird (XFCE) theme.

Verified on 65.0.3325.162 Stable

Deleted: Screenshot from 2018-03-13 10-34-42.png 50.2 KB

	Screenshot from 2018-03-13 10-34-42.png 50.2 KB View Download

Deleted: Screenshot from 2018-03-13 10-35-26.png 47.5 KB

	Screenshot from 2018-03-13 10-35-26.png 47.5 KB View Download

This seems to also affect newer GTK versions such as 3.22.28. [1] I can still reproduce the issue with Chromium 65.0.3325.162 using the OSX-Arc-White GTK theme. [2]

Let me know if you'd prefer to have a new bug filed for this.

[1] https://bugs.archlinux.org/task/57746
[2] https://www.gnome-look.org/p/1167049/

Deleted: 64.0.3282.186.png 61.5 KB

	64.0.3282.186.png 61.5 KB View Download

Deleted: 65.0.3325.162.png 62.8 KB

	65.0.3325.162.png 62.8 KB View Download

 Issue 821276  has been merged into this issue.

c#25.  Thanks, please file a new issue and assign it to me.

Filed  issue 821881  but you'll have to grab it yourself since I can't assign issues. :P

Done.  I'll request EditBugs privileges for your account since you've submitted several high-quality bug reports in the past.

 Issue 830579  has been merged into this issue.