New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 819570 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression: No message is seen when there is no image in Gallery of Camera app and is seen blank

Project Member Reported by kebalaji@chromium.org, Mar 7 2018

Issue description

Chrome Version: 65.0.3325.120/10323.51.0 Beta channel Daisy,Kip,Reks
OS: Chrome OS

What steps will reproduce the problem?
(1)Sign-in to user>> Open Camera app and Go to gallery and observe

Expected: When no image is there, some message like 'No images in the Gallery' should be seen
Actual: No message is seen where there is no image in the gallery and gallery is seen blank

This is a Non-Regression issue seen from M62

NOTE: Issue is seen in M64 and M63 stable and M66 dev also

@Yuli: Please confirm the issue
 
ActualCameraNoImage.webm
2.6 MB View Download
ExpectedNoImage.webm
1.9 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/camera/+/cf769ba622ab8b6049d34a80a868ccd9617b94fd

commit cf769ba622ab8b6049d34a80a868ccd9617b94fd
Author: Yuli Huang <yuli@chromium.org>
Date: Sun Mar 11 06:19:36 2018

Disable album-button for empty album.

BUG= chromium:819570 
TEST=Tested manually on elm.

Change-Id: Ifc357520dc8e5a6fdf11b22eae7c02b65723f8e4
Reviewed-on: https://chromium-review.googlesource.com/956796
Reviewed-by: Sheng-hao Tsao <shenghao@google.com>
Tested-by: yuli <yuli@chromium.org>

[modify] https://crrev.com/cf769ba622ab8b6049d34a80a868ccd9617b94fd/src/js/views/camera.js

Comment 2 by y...@chromium.org, Mar 12 2018

Status: Fixed (was: Assigned)
The fix is that the gallery-button will be disabled for empty gallery. Please verify the fix on the next Camera app canary once it's released.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf769ba622ab8b6049d34a80a868ccd9617b94fd

commit cf769ba622ab8b6049d34a80a868ccd9617b94fd
Author: Yuli Huang <yuli@chromium.org>
Date: Sun Mar 11 06:19:36 2018

Disable album-button for empty album.

BUG= chromium:819570 
TEST=Tested manually on elm.

Change-Id: Ifc357520dc8e5a6fdf11b22eae7c02b65723f8e4
Reviewed-on: https://chromium-review.googlesource.com/956796
Reviewed-by: Sheng-hao Tsao <shenghao@google.com>
Tested-by: yuli <yuli@chromium.org>

[modify] https://crrev.com/cf769ba622ab8b6049d34a80a868ccd9617b94fd/src/js/views/camera.js

Sign in to add a comment