New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 819568 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

third_party/android_platform not pointing to third_party/android_ndk

Project Member Reported by mattcary@chromium.org, Mar 7 2018

Issue description

https://chromium-review.googlesource.com/949098 removed the [nearly] obsolete //third_party/android_tools/ndk. However scripts in //third_party/android_platform still point there, in particular //third_party/android_platform/development/scripts/symbol.py#ToolPath().

This is breaking orderfile generation on android. It's also likely breaking stack dump (stack.py in the same directory).
 
Issue 819589 has been merged into this issue.
Issue 819588 has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/979200fa93c4f7af80abc1f17060c4e1330b7ea6

commit 979200fa93c4f7af80abc1f17060c4e1330b7ea6
Author: Matthew Cary <mattcary@chromium.org>
Date: Wed Mar 07 13:20:09 2018

Update android_platform for //third_party/android_ndk.

development/scripts/symbol.py pointed to
//third_party/android_tools/ndk, which is now obsolete.

Bug:  819568 
TBR: agrieve@chromium.org, lizeb@chromium.org
Change-Id: I78ae6bc513d6a90a937f2f759dcdab47b8e942c5
Reviewed-on: https://chromium-review.googlesource.com/952906
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541415}
[modify] https://crrev.com/979200fa93c4f7af80abc1f17060c4e1330b7ea6/third_party/android_platform/development/scripts/symbol.py

Labels: Merge-Request-67
Labels: -Merge-Request-67 Merge-Request-66
Cc: kgna...@chromium.org
Labels: OS-Android
Merging to 3364 as requested by kgnaidu@
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 7 2018

Labels: merge-merged-3364
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e09f4d7325e74721aee90a70cdce0d51bd0e6484

commit e09f4d7325e74721aee90a70cdce0d51bd0e6484
Author: Matthew Cary <mattcary@chromium.org>
Date: Wed Mar 07 14:41:07 2018

Update android_platform for //third_party/android_ndk.

development/scripts/symbol.py pointed to
//third_party/android_tools/ndk, which is now obsolete.

TBR=mattcary@chromium.org

(cherry picked from commit 979200fa93c4f7af80abc1f17060c4e1330b7ea6)

Bug:  819568 
TBR: agrieve@chromium.org, lizeb@chromium.org
Change-Id: I78ae6bc513d6a90a937f2f759dcdab47b8e942c5
Reviewed-on: https://chromium-review.googlesource.com/952906
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#541415}
Reviewed-on: https://chromium-review.googlesource.com/951611
Cr-Commit-Position: refs/branch-heads/3364@{#3}
Cr-Branched-From: 92107f0efb261174280c88aaac88e3cd64469793-refs/heads/master@{#541279}
[modify] https://crrev.com/e09f4d7325e74721aee90a70cdce0d51bd0e6484/third_party/android_platform/development/scripts/symbol.py

Labels: -Merge-Request-66 Merge-Request-67
Project Member

Comment 11 by sheriffbot@chromium.org, Mar 16 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: We don't branch M67 until 2018-04-12.
Please contact the milestone owner if you have questions.
Owners: @(Android), @(iOS), @(ChromeOS), @(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Started)
I had created this bug in response to an official builder which was breaking, and I was confused about which milestone was involved. That seems to be all resolved now. No merge is necessary.
Labels: -Hotlist-Merge-Review -Merge-Review-67 Merge-Approved-67
Project Member

Comment 14 by sheriffbot@chromium.org, Apr 23 2018

Cc: cma...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 15 by sheriffbot@chromium.org, Apr 26 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 16 by cmasso@google.com, May 16 2018

Nothing to merge here? It is actually to late to merge now I guess but please confirm.
That is correct, no merge is necessary, comment #12 is still correct :)

Thanks for following up.
Labels: -Merge-Approved-67 -merge-merged-3364

Sign in to add a comment