Error messages are missing for gaia-input |
||||||
Issue description
What steps will reproduce the problem?
(1) Trigger screen with gaia-input element (e.g. in gaia_screen_handler.cc modify
GaiaScreenMode GetGaiaScreenMode(const std::string& email, bool use_offline) {
return GAIA_SCREEN_MODE_OFFLINE;
}
(2) Enter wrong value (e.g. a@a@a@ for user input)
What is the expected result?
Red line with error message
What happens instead?
just red line (see screen)
,
Mar 7 2018
How to reproduce:
chromium/src/$ cat tt.patch
diff --git a/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
index b54c7d66bc8d..3e24843a281d 100644
--- a/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
@@ -104,6 +104,7 @@ policy::DeviceMode GetDeviceMode() {
}
GaiaScreenMode GetGaiaScreenMode(const std::string& email, bool use_offline) {
+ return GAIA_SCREEN_MODE_OFFLINE;
if (GetDeviceMode() == policy::DEVICE_MODE_ENTERPRISE_AD)
return GAIA_SCREEN_MODE_AD;
chromium/src/$ patch -p1 < tt.patch
patching file chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
Hunk #1 succeeded at 103 (offset -1 lines).
chromium/src/$ gn gen --args='target_os="chromeos" is_chrome_branded=true is_official_build=true use_goma=true' out/Release && ninja -C out/Release/ -j 3000 chrome && (UDD=$HOME/cros-test-user-data-dir-tmp ; rm -rf "$HOME/cros-test-user-data-ditmp" ; mkdir -p "$UDD" ; ./out/Release/chrome --login-manager --login-profile=user --user-data-dir=$UDD --remote-debugging-port=9999 )
When chrome starts, proceed with OOBE "Let's go" => "Next" -> "Accept and continue" -> Gaia ("offline gaia", which is actually a Chrome WebUI) screen starts.
Type "a@a@a", press Enter.
You should see error message "Please enter the valid email address" under the login input field.
,
Mar 8 2018
I believe something is wrong in https://chromium-review.googlesource.com/c/chromium/src/+/902898/11/chrome/browser/resources/chromeos/login/gaia_input.html
,
Mar 30 2018
,
Apr 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c415889f1daa4710121634eebb2965fc425a8ba4 commit c415889f1daa4710121634eebb2965fc425a8ba4 Author: Hector Carmona <hcarmona@chromium.org> Date: Mon Apr 02 23:19:24 2018 paper-input-container: Add missing slot to error message in gaia login. Bug: 819567 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3683ea8b25ef5e8df47a897eb8f12d392f091b7a Reviewed-on: https://chromium-review.googlesource.com/988737 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#547555} [modify] https://crrev.com/c415889f1daa4710121634eebb2965fc425a8ba4/chrome/browser/resources/chromeos/login/gaia_input.html
,
Apr 3 2018
Requesting merge. Fix is trivial and low risk.
,
Apr 3 2018
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 5 2018
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88664654c40dfe34f841b8e0c05adfda2512db20 commit 88664654c40dfe34f841b8e0c05adfda2512db20 Author: Hector Carmona <hcarmona@chromium.org> Date: Thu Apr 05 01:48:32 2018 paper-input-container: Add missing slot to error message in gaia login. Bug: 819567 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3683ea8b25ef5e8df47a897eb8f12d392f091b7a Reviewed-on: https://chromium-review.googlesource.com/988737 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#547555}(cherry picked from commit c415889f1daa4710121634eebb2965fc425a8ba4) Reviewed-on: https://chromium-review.googlesource.com/997072 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#586} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/88664654c40dfe34f841b8e0c05adfda2512db20/chrome/browser/resources/chromeos/login/gaia_input.html
,
Apr 5 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by alemate@chromium.org
, Mar 7 2018Labels: -Pri-2 ReleaseBlock-Stable M-66 Pri-1
Owner: hcarmona@chromium.org