Regression : In md-extensions page, 'UPDATE' button turns grey momentarily upon clicking.
Reported by
avsha...@etouch.net,
Mar 7 2018
|
||||
Issue descriptionChrome Version : 67.0.3364.0 (Official Build) 92107f0efb261174280c88aaac88e3cd64469793-refs/heads/master@{#541279} 32/64-bit OS : Mac(10.12.6, 10.13.1, 10.13.4), Linux(14.04 LTS), Windows(7,8,8.1,10) What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://extensions page and enable 'Developer mode' toggle. 2. Click on 'UPDATE' button and observe the button color. Actual Result : 'UPDATE' button turns grey momentarily upon clicking. Expected Result : 'UPDATE' button should not turn grey upon clicking. This is a regression issue, broken in M-66 and providing the bisect results using per-revision script : Good Build : 66.0.3355.0 (Revision : 539002) Bad Build : 66.0.3356.0 (Revision : 539380) You are probably looking for a change made after 539167 (known good), but no later than 539168 (first known bad). CHANGE-LOG URL: https://chromium.googlesource.com/chromium/src/+log/4d5ef99b135acaea2bdd235075e7e5cd5ab36617..4e9b4a41be1eea9bfdf8ec9a7b719db7b7cf91ad Suspect : https://chromium.googlesource.com/chromium/src/+/4e9b4a41be1eea9bfdf8ec9a7b719db7b7cf91ad @Esmael : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
,
Mar 7 2018
The update button is being disabled while the extensions are updated. After the extensions have been updated (or failed to update), the button is then enabled. What should be done in this case? * Keep the new functionality (disable while updating) * Do not disabled update button, and ignore when an update is taking place * Style the disabled button state to be less jarring * Do no disable update button, and keep the old functionality
,
Mar 7 2018
Plan to do "Do not disabled update button, and ignore when an update is taking place"
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bd56e8e1bc28f774d0eec4bbd694fd41b5d7bfc commit 3bd56e8e1bc28f774d0eec4bbd694fd41b5d7bfc Author: Esmael El-Moslimany <aee@chromium.org> Date: Fri Mar 09 02:21:27 2018 MD Extensions: leave update button enabled and do not update while already updating Bug: 819566 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I90c75a6fe56117a42758118b158a26d75f3df0c2 Reviewed-on: https://chromium-review.googlesource.com/954011 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#541996} [modify] https://crrev.com/3bd56e8e1bc28f774d0eec4bbd694fd41b5d7bfc/chrome/browser/resources/md_extensions/toolbar.js [modify] https://crrev.com/3bd56e8e1bc28f774d0eec4bbd694fd41b5d7bfc/chrome/test/data/webui/extensions/extension_toolbar_test.js [modify] https://crrev.com/3bd56e8e1bc28f774d0eec4bbd694fd41b5d7bfc/chrome/test/data/webui/settings/certificate_manager_test.js [modify] https://crrev.com/3bd56e8e1bc28f774d0eec4bbd694fd41b5d7bfc/chrome/test/data/webui/test_browser_proxy.js
,
Mar 9 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by avsha...@etouch.net
, Mar 7 2018