New issue
Advanced search Search tips

Issue 819564 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

12.1% regression in webrtc_perf_tests at 22294:22294

Project Member Reported by sprang@google.com, Mar 7 2018

Issue description

Looks like there might be some small perf change with the round robin queue after all?

https://webrtc.googlesource.com/src/+/94065690f65ce06370d024cd18101ba8514f57d2

ilnik@ ptal if this is something worth acting on
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=819564

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=777ffb0d4a98adcf0aa359fe982bfd8d7fb5e4495451971065fb0dc7c4272d16


Bot(s) for this bug's original alert(s):

webrtc-android-tests-nexus6-nougat

Comment 2 by ilnik@chromium.org, Mar 7 2018

There are several groups of alerts:
In simulcast tests lower streams are now not starved by huge frames in the higher streams. This results in smaller sender delay for them but slightly higher delay for the high streams. I think this is good.

In screenshare simulcast this behavior even helped to reduce number of key frames request which resulted in higher PSNR and lesser send bandwidth.

There're also changes regarding FEC tests. Because FEC packets are now "prioritized" (they will get at least up-to half of bandwidth if they have anything to send), they get their configured bandwidth more consistently. This slightly increases send-side delay for video, but reduces total delay in high packet loss scenarios more.

Last group of changes is in the ramp up tests. Ramp up time is up, sent media and rtx is also up. This is not drastic, e.g. on bot jumped from 5 to 18 seconds, but other was already oscillating between 5 and 18 seconds and now is consistently at 18s. I will continue looking into that. This is probably caused by difference in how RTX stream is competing with media stream.

I think there's no need to revert CL, since it works good on perf tests and there were no bad signals in UMA data for the experiment.

Comment 3 by tkent@chromium.org, Mar 8 2018

Components: Blink>WebRTC

Comment 4 by ilnik@chromium.org, Jun 12 2018

Status: WontFix (was: Assigned)

Sign in to add a comment