New issue
Advanced search Search tips

Issue 819561 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Chromad: UserAvatarImage and WallpaperImage not working

Project Member Reported by ljusten@chromium.org, Mar 7 2018

Issue description

The two user policies don't work for Active Directory managed devices.
 
Summary: Chromad: UserAvatarImage and WallpaperImage not working (was: Chromad: UserAvatar and UserWallpaper not working)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a42f032712f98c56cd1d914ac9360276cd2e0539

commit a42f032712f98c56cd1d914ac9360276cd2e0539
Author: Lutz Justen <ljusten@chromium.org>
Date: Wed Mar 14 14:55:18 2018

Fix UserAvatarImage and WallpaperImage for Chromad

Both are 'external'-type policies, i.e. the images are not included in
the policy, but downloaded separately. However, the mechanisms to
download external user policies were not hooked up. This CL wires them
up. Interestingly, DeviceWallpaperImage works fine.

BUG= chromium:819561 
TEST=out/Release/unit_tests --gtest_filter=ActiveDirectoryPolicyManagerTest.*
     Set UserAvatarImage and WallpaperImage on Windows Server and
     verified that it applies on a domain joined Chromebook.

Change-Id: I8670a3e1ba0edcee31ed5753be92b021e9553bb0
Reviewed-on: https://chromium-review.googlesource.com/952903
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543084}
[modify] https://crrev.com/a42f032712f98c56cd1d914ac9360276cd2e0539/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/a42f032712f98c56cd1d914ac9360276cd2e0539/chrome/browser/chromeos/policy/active_directory_policy_manager.cc
[modify] https://crrev.com/a42f032712f98c56cd1d914ac9360276cd2e0539/chrome/browser/chromeos/policy/active_directory_policy_manager.h
[modify] https://crrev.com/a42f032712f98c56cd1d914ac9360276cd2e0539/chrome/browser/chromeos/policy/active_directory_policy_manager_unittest.cc
[modify] https://crrev.com/a42f032712f98c56cd1d914ac9360276cd2e0539/chrome/browser/chromeos/policy/cloud_external_data_policy_observer.cc
[modify] https://crrev.com/a42f032712f98c56cd1d914ac9360276cd2e0539/chrome/browser/chromeos/policy/cloud_external_data_policy_observer.h
[modify] https://crrev.com/a42f032712f98c56cd1d914ac9360276cd2e0539/chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc

Status: Fixed (was: Started)
Also fixes the NativePrintersBulkConfiguration policy.
Hi Lutz,

When attempted to verify this bug, I have set UserAvatarImage and WallpaperImage policies on Windows Server (see attached screenshots), but they were not applied (policies.json and debug-logs attached). And looks like DeviceWallpaperImage also doesn't work. Could you please take a look?

Chrome OS: 10575.4.0
Chrome: 67.0.3396.8
Device: Paine
Screenshot from 2018-04-17 13-27-54.png
29.5 KB View Download
Screenshot from 2018-04-17 13-28-27.png
30.6 KB View Download
policies.json
2.9 KB View Download
debug-logs_20180417-132304.tgz
1001 KB Download
The URL is not sufficient. You have to put in JSON including the URL and a SHA256 hash (32 characters).

{"hash": "<SHA256 hash of image>", "url": "https://example.com/wallpaper.jpg"}

Status: Verified (was: Fixed)
Thanks, Lutz!

I was able to configure UserAvatarImage and WallpaperImage policies (JSON attached), no issues.

Chrome OS: 10575.12.0
Chrome: 67.0.3396.16
Device: Santa
policies.json
6.1 KB View Download

Sign in to add a comment