"benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_mobile.browse:chrome:omnibox" is flaky |
||||||
Issue description"benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_mobile.browse:chrome:omnibox" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyfwsSBUZsYWtlInRiZW5jaG1hcmtzLnN5c3RlbV9oZWFsdGhfc21va2VfdGVzdC5TeXN0ZW1IZWFsdGhCZW5jaG1hcmtTbW9rZVRlc3Quc3lzdGVtX2hlYWx0aC5tZW1vcnlfbW9iaWxlLmJyb3dzZTpjaHJvbWU6b21uaWJveAw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/507a11acd6cae68872a027576aff193ebb198f90 commit 507a11acd6cae68872a027576aff193ebb198f90 Author: jdoerrie <jdoerrie@chromium.org> Date: Wed Mar 07 17:36:37 2018 Disable system_health.memory_mobile.browse:chrome:omnibox perf test on Nexus 5X TBR=perezju Bug: 819552 Change-Id: Ib4fb62e89cd7b1bdeb6de2d4e94621b4fba519c6 Reviewed-on: https://chromium-review.googlesource.com/951734 Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#541486} [modify] https://crrev.com/507a11acd6cae68872a027576aff193ebb198f90/tools/perf/expectations.config
,
Mar 8 2018
Since that test was already disabled on all of android_webview, doesn't adding the Nexus5 condition re-enable it on all other devices? (This test has now started flaking on health-plan-webview-phone and perf-go-webview-phone).
,
Mar 8 2018
Hmm.. it's possible that multiple conditions are not working as expected. Could you send a follow up CL breaking the disable into two lines? e.g. crbug.com/819552 [ Android_Webview ] system_health.memory_mobile/browse:chrome:omnibox [ Skip ] crbug.com/819552 [ Nexus_5X ] system_health.memory_mobile/browse:chrome:omnibox [ Skip ]
,
Mar 8 2018
Yes, I just found what the problem is:
# Test Expectations with multiple conditions are treated as logical
# and and require all conditions to be met for disabling to occur.
# By design, StoryExpectations treats lists as logical or so we must
# construct TestConditions using the logical and helper class.
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/story/expectations.py?rcl=6fbfa7cb20f44fdf0a0336137a33febc44f6fd84&l=57
That should be more prominent on the story disabling docs. I'll fix both.
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0f2ffe55d7b53600d9a9b0eb1d674189712d067 commit e0f2ffe55d7b53600d9a9b0eb1d674189712d067 Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Thu Mar 08 14:13:22 2018 [tools/perf] Disable browse:chrome:omnibox separately on WebView and N5 To disable on multiple platforms, each disable must be listed separately as a new entry. Also update docs to make this a bit more explicit. TBR=sullivan@chromium.org,nednguyen@google.com NOTRY=true Bug: 819552 Change-Id: I0f033a9ea11d8df6a27fcbbfaa5cc98d408ac2f1 Reviewed-on: https://chromium-review.googlesource.com/955682 Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#541787} [modify] https://crrev.com/e0f2ffe55d7b53600d9a9b0eb1d674189712d067/docs/speed/perf_bot_sheriffing.md [modify] https://crrev.com/e0f2ffe55d7b53600d9a9b0eb1d674189712d067/tools/perf/expectations.config
,
Mar 19 2018
Test is disabled, lowering Pri
,
Apr 30 2018
,
Apr 30 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jdoerrie@chromium.org
, Mar 7 2018Owner: perezju@chromium.org
Status: Assigned (was: Untriaged)