Relaunch recommended bubble passes behind browser window |
|||||||
Issue descriptionChrome Version: 66.0.3357.0 and newer OS: macOS What steps will reproduce the problem? (1) Set the RelaunchNotification policy setting to 1 (2) Launch the browser with chrome.exe --simulate-upgrade (3) Wait 20s or so What is the expected result? A bubble appears anchored to the Chrome menu and maintains its position relative to the menu. What happens instead? The bubble doesn't stick with the window, and clicking inside the window moves the window to the foreground, with the bubble going behind the window; see https://drive.google.com/open?id=16l_ZLBEZwf_8dg51T48k-PrVwkIuqAxa.
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68d0edd5d225f8a6c755afaf3134a9665a99f4d5 commit 68d0edd5d225f8a6c755afaf3134a9665a99f4d5 Author: Greg Thompson <grt@chromium.org> Date: Wed Mar 07 15:52:02 2018 Parent the relaunch recommended bubble to the browser window. This fixes a bug on macOS when using a Cocoa-based browser, whereby the bubble was not attached to the browser window. BUG= 819546 Change-Id: Ia465a0ba9251e33b3b6fc9c6756445d1399ff79a Reviewed-on: https://chromium-review.googlesource.com/952926 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#541443} [modify] https://crrev.com/68d0edd5d225f8a6c755afaf3134a9665a99f4d5/chrome/browser/ui/views/relaunch_notification/relaunch_recommended_bubble_view.cc
,
Mar 8 2018
Yiningc@ Could you please verify this issue on latest canary. Thank You...
,
Mar 8 2018
macourteau tried it out for me today and says it looks good to him. Calling this fixed. Happy to have additional verification, though.
,
Mar 8 2018
Here are some videos be captured: https://drive.google.com/drive/folders/18_Z4uFv_31UpwiXD0ksz7n7XIQzQE_0t?usp=sharing
,
Mar 8 2018
,
Mar 8 2018
I have verified this bug is fixed on Chrome build 67.0.3365.0.
,
Mar 8 2018
Perfect, thank you.
,
Mar 9 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d0ce611c458e76f78fb047759e7660659e3433a commit 3d0ce611c458e76f78fb047759e7660659e3433a Author: Greg Thompson <grt@chromium.org> Date: Fri Mar 09 19:52:59 2018 Parent the relaunch recommended bubble to the browser window. This fixes a bug on macOS when using a Cocoa-based browser, whereby the bubble was not attached to the browser window. BUG= 819546 TBR=grt@chromium.org Change-Id: Ia465a0ba9251e33b3b6fc9c6756445d1399ff79a Reviewed-on: https://chromium-review.googlesource.com/952926 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#541443}(cherry picked from commit 68d0edd5d225f8a6c755afaf3134a9665a99f4d5) Reviewed-on: https://chromium-review.googlesource.com/955651 Reviewed-by: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#137} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/3d0ce611c458e76f78fb047759e7660659e3433a/chrome/browser/ui/views/relaunch_notification/relaunch_recommended_bubble_view.cc
,
Mar 12 2018
Yiningc@ Could you please verify this issue on chrome #66.0.3359.26 Thank You...
,
Mar 12 2018
It is verified fixed on Chrome build 66.0.3359.26.
,
Mar 14 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by grt@chromium.org
, Mar 7 2018