New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 819510 link

Starred by 2 users
Status: Fixed
Owner:
█ yoshiki@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
Cc:
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task



Sign in to add a comment

Remove old-ARC-toast code

Project Member Reported by yoshiki@chromium.org, Mar 7 2018 
Originally ARC toast was implemented in Chrome side, but it is replaced with Android-side implementation. So the Chrome-side one is no longer used now. We should clean-up the code by removing the old code.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b0a6b4204233fbb0583182e4887811439d15789

commit 8b0a6b4204233fbb0583182e4887811439d15789
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Wed Mar 28 05:00:11 2018

Remove ArcToast code

ArcToast is no longer used, so this CL removes the related code.

The implementation of Toast in Chrome is not removed since it's used
from other component.

Related ARC-side changes: ag/3723365, ag/3723362, ag/3723361

Bug:  819510 
Test: none
Change-Id: I4dd62ce833787dabc7471a0b607ee963d71042c8
Reviewed-on: https://chromium-review.googlesource.com/958787
Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546409}
[modify] https://crrev.com/8b0a6b4204233fbb0583182e4887811439d15789/components/arc/common/notifications.mojom
[modify] https://crrev.com/8b0a6b4204233fbb0583182e4887811439d15789/ui/arc/notification/arc_notification_manager.cc
[modify] https://crrev.com/8b0a6b4204233fbb0583182e4887811439d15789/ui/arc/notification/arc_notification_manager.h

Comment 2 by yoshiki@chromium.org, Mar 28 2018

Status: Fixed (was: Started)
►

Sign in to add a comment