New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 819489 link

Starred by 51 users

Unable to view and develop websites in responsive mode.

Reported by senthi...@pickyourtrail.com, Mar 7 2018

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.146 Safari/537.36

Steps to reproduce the problem:
1. Open inspector and click responsive mode icon, change to different widths and check the website.

What is the expected behavior?

What went wrong?
Width and Height not applied properly

Did this work before? N/A 

Chrome version: 65.0.3325.146  Channel: stable
OS Version: OS X 10.11.6
Flash Version:
 
Screen Shot 2018-03-07 at 12.02.26 PM.png
367 KB View Download
Labels: Needs-Triage-M65
Cc: vamshi.kommuri@chromium.org
 Issue 819500  has been merged into this issue.
 Issue 819491  has been merged into this issue.
 Issue 819490  has been merged into this issue.

Comment 5 by o...@vesch.de, Mar 7 2018

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.106 Safari/537.36

Steps to reproduce the problem:
1. Open inspector and click responsive mode icon, change to an emulated device.

What is the expected behavior?

What went wrong?
Width and Height not applied properly

Did this work before? Yes

Chrome version: 65.0.3325.106 (Offizieller Build) beta (64-Bit)
OS Version: OS X 10.10.5

Google 2018-03-07 09-43-05.png
44.9 KB View Download

Comment 6 by o...@vesch.de, Mar 7 2018

After reinstall Chrome (the same Version) the emulated device view looked as expected. But when I switched to the responsive mode and changed the view size and after that switched back to the emulated device view, it looked the same as before in my screenshot.
 Issue 819496  has been merged into this issue.
 Issue 819495  has been merged into this issue.
 Issue 819494  has been merged into this issue.
 Issue 819493  has been merged into this issue.
 Issue 819499  has been merged into this issue.
 Issue 819492  has been merged into this issue.
 Issue 819498  has been merged into this issue.
 Issue 819497  has been merged into this issue.
 Issue 819501  has been merged into this issue.
 Issue 819502  has been merged into this issue.
Cc: sindhu.chelamcherla@chromium.org
Labels: -Type-Bug -Pri-2 ReleaseBlock-Stable Triaged-ET M-65 Target-65 FoundIn-65 RegressedIn-66 Pri-1 Type-Bug-Regression
Owner: ccameron@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on 65.0.3325.146 using Mac 10.13.3, but not reproducible(fixed) on latest canary 67.0.3364.0. Hence providing reverse bisect info. Issue is not reproducible on Linux and Windows.

Last Bad Build: 66.0.3358.0
First Good build: 66.0.3359.0

You are probably looking for a change made after 540146 (known good), but no later than 540147 (first known bad).
CHANGELOG URL:
 https://chromium.googlesource.com/chromium/src/+log/f5364a7d2520786491ecdc5ec6b066a305b36a80..615f354b286f4e9acdcc6c42fdb2dc640577640d

Probably fixed by  https://chromium-review.googlesource.com/938958

@ccameron: Please confirm the bug and help in merging to M-65 if it is safe. Adding RB-Stable for M-65. Please remove if not the case.

Thanks!
Cc: dgozman@chromium.org
Owner: fsam...@chromium.org
This is similar to  issue 817238 , but apparently the offending commit https://chromium.googlesource.com/chromium/src.git/+/e24c90e284ccaae925132cc0271d9179b5560ec3 was merged to 65 here: https://chromium.googlesource.com/chromium/src.git/+/64461531b578e20751309ffabcbe67493c934ced.

We should merge the fix from  issue 817238  (https://chromium.googlesource.com/chromium/src/+/615f354b286f4e9acdcc6c42fdb2dc640577640d) to 65. Fady, could you please check whether it's safe to merge and manually verify that everything works on the 65 branch? I am not sure how to check whether everything surface-related works fine.
This is reproducible on retina and non-retina Mac, and affects all DevTools users on Mac. Definitely a stable blocker.

The proper fix would be to merge https://chromium.googlesource.com/chromium/src/+/615f354b286f4e9acdcc6c42fdb2dc640577640d to 65. Unfortunately, that does not merge cleanly as there have been a couple of refactors since 65 in this area. fsamuel@ is working on an isolated fix.
Cc: ccameron@chromium.org
Components: Internals>Services>Viz
I know it is early but requesting postmortem for this before I forget.
Project Member

Comment 24 by bugdroid1@chromium.org, Mar 7 2018

Labels: merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed7c8bf8cf749050d4256ff7b597cfeaa219e12e

commit ed7c8bf8cf749050d4256ff7b597cfeaa219e12e
Author: Fady Samuel <fsamuel@chromium.org>
Date: Wed Mar 07 23:51:07 2018

Devtools: Fix clipping with device emulation.

8bb58f52036793831d0363c285a6b159b21513d9 exposed a pre-existing bug on Mac
whereby an incorrect device scale factor was passed into the compositor
when device emulation mode was turned on. This bug only occurs on Mac
because Mac and Windows used different code paths for device scale factor.

Windows always reports to the compositor a device scale factor of 1, and then
passes the real device scale factor to Blink which deals with the scaling itself.

Mac reports the actual device scale factor to the compositor along with Blink.
Blink doesn't deal with the scaling directly via zoom.

In either case, device emulation can change the device scale factor. The DSF
reported to the compositor must be the non-emulated DSF. The pre-existing bug
was that we passed the post-emulation device scale factor to the compositor which
affected clipping.

Bug:  819489 
Change-Id: Iecf87b5fcb22695a4af2213daf3f0597ddbffc20
Reviewed-on: https://chromium-review.googlesource.com/954122
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#675}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/ed7c8bf8cf749050d4256ff7b597cfeaa219e12e/content/renderer/render_widget.cc

I built and tested this locally and did a direct merge to M65 as it can't be merged to trunk.

Thank you  fsamuel@. This merge was approved per offline  group chat with dgozman@, fsamuel@ and ccameron@. 


NextAction: 2018-03-08
Pls test/verify this bug on latest M65 official build tomorrow. 
 Issue 819750  has been merged into this issue.
 Issue 819621  has been merged into this issue.
 Issue 819856  has been merged into this issue.
Pls verify this bug on M65 #65.0.3325.150 tomorrow.
Cl listed at #24 need merge to M66? If yes, pls request a merge. Thank you.
No merge to M66 is necessary. This was fixed by ccameron@ in M66.
No merge to M66 is necessary. This was fixed by ccameron@ in M66.
Ok, thank you for confirmation.
The NextAction date has arrived: 2018-03-08
I've verified the bug is gone in 150.

Comment 38 by ajha@chromium.org, Mar 8 2018

Labels: TE-Verified-M65 TE-Verified-65.0.3325.150
Verified the fix on the latest M-65(65.0.3325.150) on Mac OS 10.13.3 and this is working as intended.

Note: I was able to repro the issue on 65.0.3325.146.
819489.png
246 KB View Download
Status: Fixed (was: Assigned)
Labels: Hotlist-ConOps-Channel-Beta Hotlist-ConOps-Source-Feedback
 Issue 819628  has been merged into this issue.
 Issue 820109  has been merged into this issue.
 Issue 820084  has been merged into this issue.
 Issue 820074  has been merged into this issue.
 Issue 820058  has been merged into this issue.

Comment 46 by o...@vesch.de, Mar 9 2018

Stupid question, where can I download the version 65.0.3325.150?
I use this page https://www.chromium.org/getting-involved/dev-channel and there I choosed "Beta channel for Mac". But there is still the 65.0.3325.124 Version.
Any estimated time about releasing .150 build? I'm still getting the .146 at 10:45 AM Spain local time when using standard browser version autoupdate
Labels: Hotlist-ConOps
 Issue 820447  has been merged into this issue.
 Issue 820357  has been merged into this issue.
Cc: gov...@chromium.org
Cc: ellyjo...@chromium.org
 Issue 820914  has been merged into this issue.
 Issue 820887  has been merged into this issue.
 Issue 821010  has been merged into this issue.
 Issue 821116  has been merged into this issue.
Labels: -TE-Verified-65.0.3325.150 TE-Verified-65.0.3325.162
Able to reproduce the issue on chrome reported version 65.0.3325.146
Verified the fix on Mac 10.12.6 on Chrome version #65.0.3325.162 as per the comment#0
Attaching screenshot for reference.
Observed "Able to view websites in responsive mode"
Hence, the fix is working as expected.
Adding the verified label.

Thanks!
819489.png
415 KB View Download
So, any estimated time of releasing a new public version? the last one is still .146
Verified the fix on 65.0.3325.162. Thanks!
Just upgraded. Verified on 65.0.3325.162. Thanks for the quick turn around!
 Issue 821520  has been merged into this issue.
 Issue 821847  has been merged into this issue.
 Issue 821973  has been merged into this issue.
I just updated my Chrome on Mac 10.12.6 and it changed from Build 106 to build 124. Is Build 162 available on Mac 10.12.6?
 Issue 822404  has been merged into this issue.
 Issue 822174  has been merged into this issue.
 Issue 822122  has been merged into this issue.

Sign in to add a comment