New issue
Advanced search Search tips

Issue 819484 link

Starred by 1 user
Status: Fixed
Owner:
johannko...@google.com
Closed: Mar 2018
Cc:
jzern@chromium.org
ios-bugs@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android , iOS , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

vp9_iht8x8_64_add_neon produces incorrect results

Project Member Reported by johannko...@google.com, Mar 7 2018 
Chrome Version: M66
OS: All ARM based configurations

The vp9_iht8x8_64_add_neon produces incorrect results. This may create visual artifacts when decoding vp9 streams on ARM devices.

The function was broken in this commit
https://chromium-review.googlesource.com/c/webm/libvpx/+/892139

and then merged to chromium:
https://chromium-review.googlesource.com/c/chromium/src/+/895847

which made it into M66:
https://chromiumdash.appspot.com/commit/3abdbae1d173d811553d81a67971618144d5cc46

We discovered other iht functions were broken and disabled the 8x8 here:
https://chromium-review.googlesource.com/c/webm/libvpx/+/948062

and merged to chromium here, just after the M66 branch:
https://chromium-review.googlesource.com/c/chromium/src/+/952085

We have prepared a cherry-pick to disable the problematic function:
https://chromium-review.googlesource.com/c/webm/libvpx/+/952502

and request permission to merge this to M66

Comment 1 by johannko...@google.com, Mar 7 2018 

Because of the libvpx configuration this is a two-part process.

First is updating the library with the cherry pick:
https://chrome-internal-review.googlesource.com/#/c/chrome/tools/buildspec/+/584194

Second is running generate_gni.sh in the branch and uploading the results. In this particular instance, these steps do not need to be merged in tandem.

Comment 3 by gov...@chromium.org, Mar 7 2018 

Pls apply appropriate OSs label. Thank you.

Comment 4 by johannko...@google.com, Mar 7 2018

Labels: OS-Android OS-Chrome OS-iOS
I'm not sure we distribute on iOS, but it does exist on ChromeOS and I believe Android.
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 8 2018

Labels: -Merge-Request-66 Merge-Approved-66 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 8 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/buildspec/+/f86976ee52d76fbd2221d8a70026d4192fdebf40

commit f86976ee52d76fbd2221d8a70026d4192fdebf40
Author: Johann <johannkoenig@google.com>
Date: Thu Mar 08 20:39:15 2018
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 8 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e887bc8f0c82358c7f0c6f40d3c8408a681a5c4d

commit e887bc8f0c82358c7f0c6f40d3c8408a681a5c4d
Author: Johann <johannkoenig@google.com>
Date: Thu Mar 08 20:41:31 2018

libvpx: disable vp9_iht8x8_64_add_neon

Regenerate config files with vp9_iht8x8_64_add_neon
disabled.

BUG= 819484 

Change-Id: I7421739f61787b1a36bd2928a1e1e4a6309d9c45
Reviewed-on: https://chromium-review.googlesource.com/952111
Reviewed-by: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#113}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/e887bc8f0c82358c7f0c6f40d3c8408a681a5c4d/third_party/libvpx/README.chromium
[modify] https://crrev.com/e887bc8f0c82358c7f0c6f40d3c8408a681a5c4d/third_party/libvpx/source/config/ios/arm-neon/vp9_rtcd.h
[modify] https://crrev.com/e887bc8f0c82358c7f0c6f40d3c8408a681a5c4d/third_party/libvpx/source/config/ios/arm64/vp9_rtcd.h
[modify] https://crrev.com/e887bc8f0c82358c7f0c6f40d3c8408a681a5c4d/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vp9_rtcd.h
[modify] https://crrev.com/e887bc8f0c82358c7f0c6f40d3c8408a681a5c4d/third_party/libvpx/source/config/linux/arm-neon/vp9_rtcd.h
[modify] https://crrev.com/e887bc8f0c82358c7f0c6f40d3c8408a681a5c4d/third_party/libvpx/source/config/linux/arm64/vp9_rtcd.h
[modify] https://crrev.com/e887bc8f0c82358c7f0c6f40d3c8408a681a5c4d/third_party/libvpx/source/config/vpx_version.h

Comment 8 by johannko...@google.com, Mar 8 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment