New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 819464 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Build-Toolchain



Sign in to add a comment

Setup toolchain for armv7m target

Project Member Reported by manojgupta@chromium.org, Mar 7 2018

Issue description

Some of the new boards need support for armv7m target.
Note: Most likely also want to enable compiler-rt as well.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/899149de85b5b8e49c625310f2868c8385645c6c

commit 899149de85b5b8e49c625310f2868c8385645c6c
Author: Manoj Gupta <manojgupta@google.com>
Date: Thu Mar 08 03:46:42 2018

armv7m-cros-eabi: Disable hardened for the baremetal toolchain.

Mask hardended flag for the baremetal armv7m-cros-eabi toolchain.

BUG= chromium:819464 
TEST=emerge -pv cross-armv7m-cros-eabi shows "-hardended" flag.

Change-Id: Ieb061cf67886d4d0b6c927a6e967b55e1cb1fab6
Reviewed-on: https://chromium-review.googlesource.com/953651
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/899149de85b5b8e49c625310f2868c8385645c6c/profiles/default/linux/package.use.mask

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/21f3a08b72d123dbc39afbaeaa7622c3926397c8

commit 21f3a08b72d123dbc39afbaeaa7622c3926397c8
Author: Manoj Gupta <manojgupta@google.com>
Date: Thu Mar 08 06:08:09 2018

cros_setup_toolchains: Build compiler-rt in armv7m-cros-eabi.

We want to provide compiler-rt libraries in armv7m toolchain.
So add armv7m-cros-eabi to compiler-rt list.

BUG= chromium:819464 
TEST=cros_setup_toolchains -t armv7m-cros-eabi --nousepkg installs
     compiler-rt.

Change-Id: I87069562a9ed7b7b5204105f73582a821e895411
Reviewed-on: https://chromium-review.googlesource.com/952044
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/21f3a08b72d123dbc39afbaeaa7622c3926397c8/scripts/cros_setup_toolchains.py

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7982bcbb24c619a76f150bd35406f4439bd0482c

commit 7982bcbb24c619a76f150bd35406f4439bd0482c
Author: Manoj Gupta <manojgupta@google.com>
Date: Thu Mar 08 06:08:12 2018

compiler-rt: Add support after armv7m baremetal builds.

Add support for building baremetal targets.
Pass -Wa,vfpv2 to build some assembly files for armv7m since
currently there is no way to exclude assembly files for armv7m
targets with/without fpu.

BUG= chromium:819464 
TEST=sudo emerge cross-armv7m-cros-eabi/compiler-rt works.

Change-Id: Ibd729efdea5f78f312c2e6225904f42ff158dd1e
Reviewed-on: https://chromium-review.googlesource.com/952770
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/7982bcbb24c619a76f150bd35406f4439bd0482c/sys-libs/compiler-rt/compiler-rt-6.0_pre321490-r4.ebuild

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/72526b2347baffa873ca11a04e9418542e65756f

commit 72526b2347baffa873ca11a04e9418542e65756f
Author: Manoj Gupta <manojgupta@google.com>
Date: Sat Mar 10 02:14:07 2018

Add armv7m-cros-eabi toolchain.

This will make SDK builder build the new armv7m-cros-eabi toolchain.
Piggyback the new toolchain on arm64-generic since this board
is not built anywhere. So should not break anything because of
missing prebuilds.

BUG= chromium:819464 
TEST=cros_setup_toolchains -t armv7m-cros-eabi --nousepkg works.

Change-Id: Ia6161c035e11da4b8b9145a45ee1372750eaa171
Reviewed-on: https://chromium-review.googlesource.com/952771
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/72526b2347baffa873ca11a04e9418542e65756f/overlay-arm64-generic/toolchain.conf

Status: Verified (was: Untriaged)
armv7m-cros-eabi toolchain is now available.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/e800f17fc0709f5c20fde4af61ac11fc0165c235

commit e800f17fc0709f5c20fde4af61ac11fc0165c235
Author: Manoj Gupta <manojgupta@google.com>
Date: Thu Mar 29 02:34:30 2018

cheza: Install armv7m-cros-eabi toolchain.

armv7m-cros-eabi toolchain is needed to build aop code.

BUG= chromium:819464 
TEST=pre-cq installs the toolchain in setup_board stage.

Change-Id: Ic250eff8c82af2b159ac8add3eb3cfa82eaf14b7
Reviewed-on: https://chromium-review.googlesource.com/961421
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/e800f17fc0709f5c20fde4af61ac11fc0165c235/baseboard-cheza/toolchain.conf

Sign in to add a comment