New issue
Advanced search Search tips

Issue 819462 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: 2018-03-28
OS: ----
Pri: 3
Type: Bug
Q1



Sign in to add a comment

Collections: Add support for expanding/collapsing the Remote Tabs Session

Project Member Reported by sczs@chromium.org, Mar 7 2018

Issue description

Add support for expanding/collapsing the Remote Tabs Session.

This doesn't include the cell design, only Recen Tabs functionality


 
The NextAction date has arrived: 2018-03-14

Comment 2 by cmasso@google.com, Mar 15 2018

NextAction: 2018-03-28
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9e6905da2a4f6a5e3899397a24ad0c2b111fe21

commit c9e6905da2a4f6a5e3899397a24ad0c2b111fe21
Author: sczs <sczs@chromium.org>
Date: Thu Mar 15 22:13:39 2018

[ios] Adds Collapsed functionality to TableViewModel

Bug:  819462 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I364154d00b6fb138a7b1b85240b625984e36fee5
Reviewed-on: https://chromium-review.googlesource.com/961492
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543514}
[modify] https://crrev.com/c9e6905da2a4f6a5e3899397a24ad0c2b111fe21/ios/chrome/browser/ui/table_view/BUILD.gn
[modify] https://crrev.com/c9e6905da2a4f6a5e3899397a24ad0c2b111fe21/ios/chrome/browser/ui/table_view/table_view_model.h
[modify] https://crrev.com/c9e6905da2a4f6a5e3899397a24ad0c2b111fe21/ios/chrome/browser/ui/table_view/table_view_model.mm
[add] https://crrev.com/c9e6905da2a4f6a5e3899397a24ad0c2b111fe21/ios/chrome/browser/ui/table_view/table_view_model_unittest.mm

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82fe4dde1c72289c1038456cfa86df6ae33a3e4f

commit 82fe4dde1c72289c1038456cfa86df6ae33a3e4f
Author: sczs <sczs@chromium.org>
Date: Thu Mar 15 23:04:41 2018

[ios] Adds collapse and context menu functionality to Recent Tabs Headers

- Adds expand/collapse functionality.
- Adds contextmenu functionality (Open All and Hide For now).
- Adds a tapGesture recognizer for headers.

Video:
https://drive.google.com/open?id=1LwJCMrUlNmJ73O_SWHEpImBqaEh4M1hv

Bug:  819462 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Idc51238b5cfb205f3150d33364efad83868c7333
Reviewed-on: https://chromium-review.googlesource.com/958099
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543535}
[modify] https://crrev.com/82fe4dde1c72289c1038456cfa86df6ae33a3e4f/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.mm

Comment 5 by sczs@chromium.org, Mar 15 2018

Status: Fixed (was: Started)
The NextAction date has arrived: 2018-03-28
Labels: Proj-UIRefresh

Sign in to add a comment