New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 819461 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q2



Sign in to add a comment

New Tab Page: Update ntp frame when switching from ipad to iphone size classes

Project Member Reported by justincohen@chromium.org, Mar 7 2018

Issue description

Tablet compact size class needs to make the NTP full screen.

Probably blocked on hiding the tab strip in compact sc
 
Labels: -medium large
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d6548e6a8c4a71d1a8b99d56e5c4393dcd05c78

commit 6d6548e6a8c4a71d1a8b99d56e5c4393dcd05c78
Author: Justin Cohen <justincohen@google.com>
Date: Wed Apr 04 15:29:57 2018

[ios] Add size class support for refresh NTP.

This replaces checks for IsIpadIdiom with RegularXRegular size classes.

Bug:  819461 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I33b4410214dd1ca0672afd46953435150ccfb3c7
Reviewed-on: https://chromium-review.googlesource.com/981939
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548069}
[modify] https://crrev.com/6d6548e6a8c4a71d1a8b99d56e5c4393dcd05c78/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/6d6548e6a8c4a71d1a8b99d56e5c4393dcd05c78/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[modify] https://crrev.com/6d6548e6a8c4a71d1a8b99d56e5c4393dcd05c78/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.h
[modify] https://crrev.com/6d6548e6a8c4a71d1a8b99d56e5c4393dcd05c78/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.mm
[modify] https://crrev.com/6d6548e6a8c4a71d1a8b99d56e5c4393dcd05c78/ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm
[modify] https://crrev.com/6d6548e6a8c4a71d1a8b99d56e5c4393dcd05c78/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm
[modify] https://crrev.com/6d6548e6a8c4a71d1a8b99d56e5c4393dcd05c78/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm
[modify] https://crrev.com/6d6548e6a8c4a71d1a8b99d56e5c4393dcd05c78/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout.h
[modify] https://crrev.com/6d6548e6a8c4a71d1a8b99d56e5c4393dcd05c78/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout.mm
[delete] https://crrev.com/d4ce3da707ac4ec32c3f23ff1eb5e450a4c310b9/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout_handset.h
[delete] https://crrev.com/d4ce3da707ac4ec32c3f23ff1eb5e450a4c310b9/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout_handset.mm
[modify] https://crrev.com/6d6548e6a8c4a71d1a8b99d56e5c4393dcd05c78/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/6d6548e6a8c4a71d1a8b99d56e5c4393dcd05c78/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm
[modify] https://crrev.com/6d6548e6a8c4a71d1a8b99d56e5c4393dcd05c78/ios/chrome/browser/ui/ntp/BUILD.gn
[modify] https://crrev.com/6d6548e6a8c4a71d1a8b99d56e5c4393dcd05c78/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
[modify] https://crrev.com/6d6548e6a8c4a71d1a8b99d56e5c4393dcd05c78/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.mm
[modify] https://crrev.com/6d6548e6a8c4a71d1a8b99d56e5c4393dcd05c78/ios/chrome/browser/ui/uikit_ui_util.h
[modify] https://crrev.com/6d6548e6a8c4a71d1a8b99d56e5c4393dcd05c78/ios/chrome/browser/ui/uikit_ui_util.mm

Status: Fixed (was: Assigned)

Sign in to add a comment