New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 819460 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q2



Sign in to add a comment

New Tab Page: Make it really fullscreen

Project Member Reported by justincohen@chromium.org, Mar 7 2018

Issue description

Now that the scrolled NTP has a blur effect, it looks weird to not have the NTP extend to the top of the phone (and it's extra noticeable on the X)


 
Labels: -medium large
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f066e0e2fd71a7641d537b23392f5f51593751cb

commit f066e0e2fd71a7641d537b23392f5f51593751cb
Author: Justin Cohen <justincohen@google.com>
Date: Wed Apr 04 14:25:32 2018

[ios] Make NTP really full screen.

Short term solution to long term problem of pulling the NTP out of native content.
For now, convince //ios/web to show the NTP native content as full screen (including
under the status bar) by sending a negative offset to web when calculating the frame
of the native content.

Bug:  819460 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia4d2417aafad0afbc5dd62ffbcd35156deb3f8ad
Reviewed-on: https://chromium-review.googlesource.com/981233
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548047}
[modify] https://crrev.com/f066e0e2fd71a7641d537b23392f5f51593751cb/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/f066e0e2fd71a7641d537b23392f5f51593751cb/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm
[modify] https://crrev.com/f066e0e2fd71a7641d537b23392f5f51593751cb/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm
[modify] https://crrev.com/f066e0e2fd71a7641d537b23392f5f51593751cb/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout_handset.mm
[modify] https://crrev.com/f066e0e2fd71a7641d537b23392f5f51593751cb/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm
[modify] https://crrev.com/f066e0e2fd71a7641d537b23392f5f51593751cb/ios/chrome/browser/ui/ntp/ntp_header_view_adapter.h

Status: Fixed (was: Assigned)
Status: Assigned (was: Fixed)
Tested in 67.0.3393.0 Canary, iPhone X iOS 11.3 beta 6, iPhone 6 iOS 10.3.3, iPhone 7 iOS11, iPad Pro iOS11

There are differences between iOS10 and iOS 11
https://drive.google.com/file/d/1A14huqLbhP9V4KJtsQDlEIYRKzeZsfBv/view

Is this WAI?
Not WAI!  This appears to be broken on iOS10.  I see what's wrong here, thanks for catching!
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af5067d1079b79bb537f2c5ac388472862ebe08a

commit af5067d1079b79bb537f2c5ac388472862ebe08a
Author: Justin Cohen <justincohen@google.com>
Date: Wed Apr 11 19:42:00 2018

[ios] Fix NTP scrolled omnibox for iOS10.

This was broken by crrev.com/548047, which should have been wrapped in a ui
refresh flag.

Bug:  819460 ,  831555 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4b081548de5f058a81530d9dd20f369e2e1fca7d
Reviewed-on: https://chromium-review.googlesource.com/1008044
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549942}
[modify] https://crrev.com/af5067d1079b79bb537f2c5ac388472862ebe08a/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout.mm

Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2533dfa0d5490ca288ae89f5183d8386bd6dd18a

commit 2533dfa0d5490ca288ae89f5183d8386bd6dd18a
Author: Justin Cohen <justincohen@google.com>
Date: Tue Apr 17 17:57:01 2018

[ios] More fixes for making NTP fullscreen.

Bug:  819460 ,  832593 

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6ba2bfc9e22758203b5dc44698e40db5295c79ce
Reviewed-on: https://chromium-review.googlesource.com/1005912
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551386}
[modify] https://crrev.com/2533dfa0d5490ca288ae89f5183d8386bd6dd18a/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/2533dfa0d5490ca288ae89f5183d8386bd6dd18a/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.mm
[modify] https://crrev.com/2533dfa0d5490ca288ae89f5183d8386bd6dd18a/ios/chrome/browser/ui/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/2533dfa0d5490ca288ae89f5183d8386bd6dd18a/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm
[modify] https://crrev.com/2533dfa0d5490ca288ae89f5183d8386bd6dd18a/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm
[modify] https://crrev.com/2533dfa0d5490ca288ae89f5183d8386bd6dd18a/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm
[modify] https://crrev.com/2533dfa0d5490ca288ae89f5183d8386bd6dd18a/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout.mm
[modify] https://crrev.com/2533dfa0d5490ca288ae89f5183d8386bd6dd18a/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm

Status: Assigned (was: Started)
Tested in 68.0.3405.0 Canary, iPhone 6 iOS 10.3.3,
There is still an issue when navigating back from fullscreen mode.

https://drive.google.com/file/d/1hFSqGo3RX5PjFG7hAdHu6tqooVU6L1yd/view?usp=sharing
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4755ec567368e10226ecca4b7446725e920bd398

commit 4755ec567368e10226ecca4b7446725e920bd398
Author: Justin Cohen <justincohen@google.com>
Date: Wed Apr 25 15:02:45 2018

[ios] More NTP full screen fixes.

Followup to crrev.com/c/1005912, missed another case where we need to inject
the status bar height for iOS10.

Bug:  819460 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2749ac4d5fcf24edd446741e5927868e856dd4c6
Reviewed-on: https://chromium-review.googlesource.com/1026420
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553551}
[modify] https://crrev.com/4755ec567368e10226ecca4b7446725e920bd398/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm

Status: Fixed (was: Assigned)
shbarezer@ latest patch should fix comment 9
Status: Verified (was: Fixed)
Verified in 68.0.3409.0 Canary, iPhone 6 iOS 10.3.3
Looks good.

Sign in to add a comment