New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 819458 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

chrome.runtime API Source is readable

Reported by 000as00...@gmail.com, Mar 7 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.186 Safari/537.36

Steps to reproduce the problem:
1. open devTools
2. find property function type and [[Function Location]] is not <unknown> for "chrome" Object
3. click the found property [[FunctionLocation]] value and  view source

What is the expected behavior?

What went wrong?

[[FunctionLocation]] property is not removed so Source can readable 

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 64.0.3282.186  Channel: stable
OS Version: 10.0
Flash Version:
 
chrome_source_is_visual.png
0 bytes View Download
it_is_result.png
217 KB View Download

Comment 1 Deleted

re image upload 
chrome_api_source_is_viewable.png
92.2 KB View Download

Comment 3 by woxxom@gmail.com, Mar 7 2018

Chrome extensions JS binding layer has been working that way since the very beginning AFAIK. There's no problem here. Why do you think there is?
Components: Blink>JavaScript
Labels: Needs-Triage-M64
I just think why chrome API source is readable so send issue.

I'm sorry if you think it's spam.

action is not problem but source is readable
when add break points shown other API Source,
     add break points shown other.....

API is readable when call for extensions
when extensions call all method  
In theory, readable all API source in DevTools..

I Just think "it is really really correct action?"

Comment 7 by woxxom@gmail.com, Mar 8 2018

Yes, the observed behavior is correct. In the future it'll change because the bindings system is being rewritten in native C++ code ( issue 653596 ), but it's not ready for production yet. 
Cc: sindhu.chelamcherla@chromium.org rdevlin....@chromium.org
Labels: Triaged-ET
cc'ing @rdevlin.cronin from  issue 653596  for further inputs on this bug.

@rdevlin.cronin: Please help in triaging this issue. Please feel free to close/triage this issue.

Thanks!
Status: WontFix (was: Unconfirmed)
woxxom@ summed this up accurately.  Since the beginning, extensions have used JS bindings that are mostly exposed to dev tools.  This does result in the files being readable, and can be traced with breakpoints, etc.  I agree that this isn't the most ergonomic solution for developers, and that's one of the motivations for rewriting these bindings natively in C++.  When that happens, these functions will be opaque to developers, but, as woxxom@ pointed out, it's not quite ready yet.

I'm going to close this bug out since it's WAI in the current system, and it will be addressed with native bindings, but thank you for filing an issue and checking!

Sign in to add a comment