Show icons for open windows in the shelf;Default icon for unknown windows
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c40cc54dd6e688fb7b3fbee33d3ea632eaa14204 commit c40cc54dd6e688fb7b3fbee33d3ea632eaa14204 Author: Tim Zheng <timzheng@google.com> Date: Tue Mar 27 03:16:11 2018 Put running Crostini apps on the Shelf. This is an initial implementation of the integration of Crostini apps onto the Chrome OS shelf. With this change, when a Crostini app starts to run, a new shelf item will be added to manage it. The icon will be the default Crostini app icon. Coming changes will identify specific Crostini apps and use their respective icon when possible. Design Doc: go/crostini-shelf BUG= chromium:819444 TEST=Manually tested on an eve device. Change-Id: Ibe5c731ffd602a493caa49a4928ddeba253a2663 Reviewed-on: https://chromium-review.googlesource.com/965586 Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Tim Zheng <timzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#545946} [modify] https://crrev.com/c40cc54dd6e688fb7b3fbee33d3ea632eaa14204/ash/public/cpp/shelf_model.cc [modify] https://crrev.com/c40cc54dd6e688fb7b3fbee33d3ea632eaa14204/ash/public/cpp/shelf_model.h [modify] https://crrev.com/c40cc54dd6e688fb7b3fbee33d3ea632eaa14204/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/c40cc54dd6e688fb7b3fbee33d3ea632eaa14204/chrome/browser/ui/app_list/crostini/crostini_util.cc [modify] https://crrev.com/c40cc54dd6e688fb7b3fbee33d3ea632eaa14204/chrome/browser/ui/app_list/crostini/crostini_util.h [modify] https://crrev.com/c40cc54dd6e688fb7b3fbee33d3ea632eaa14204/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc [modify] https://crrev.com/c40cc54dd6e688fb7b3fbee33d3ea632eaa14204/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h [modify] https://crrev.com/c40cc54dd6e688fb7b3fbee33d3ea632eaa14204/chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc [modify] https://crrev.com/c40cc54dd6e688fb7b3fbee33d3ea632eaa14204/chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.h [modify] https://crrev.com/c40cc54dd6e688fb7b3fbee33d3ea632eaa14204/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc [add] https://crrev.com/c40cc54dd6e688fb7b3fbee33d3ea632eaa14204/chrome/browser/ui/ash/launcher/crostini_app_window.cc [add] https://crrev.com/c40cc54dd6e688fb7b3fbee33d3ea632eaa14204/chrome/browser/ui/ash/launcher/crostini_app_window.h [add] https://crrev.com/c40cc54dd6e688fb7b3fbee33d3ea632eaa14204/chrome/browser/ui/ash/launcher/crostini_app_window_shelf_controller.cc [add] https://crrev.com/c40cc54dd6e688fb7b3fbee33d3ea632eaa14204/chrome/browser/ui/ash/launcher/crostini_app_window_shelf_controller.h [add] https://crrev.com/c40cc54dd6e688fb7b3fbee33d3ea632eaa14204/chrome/browser/ui/ash/launcher/crostini_app_window_shelf_item_controller.cc [add] https://crrev.com/c40cc54dd6e688fb7b3fbee33d3ea632eaa14204/chrome/browser/ui/ash/launcher/crostini_app_window_shelf_item_controller.h [add] https://crrev.com/c40cc54dd6e688fb7b3fbee33d3ea632eaa14204/chrome/browser/ui/ash/launcher/crostini_shelf_context_menu.cc [add] https://crrev.com/c40cc54dd6e688fb7b3fbee33d3ea632eaa14204/chrome/browser/ui/ash/launcher/crostini_shelf_context_menu.h [modify] https://crrev.com/c40cc54dd6e688fb7b3fbee33d3ea632eaa14204/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
Issue 822471 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d044585cc001537d26d202c5d4d22fcbf5425d4c commit d044585cc001537d26d202c5d4d22fcbf5425d4c Author: Tim Zheng <timzheng@google.com> Date: Thu Apr 05 21:03:26 2018 Fix a bug that counts the C string length wrongly. BUG= chromium:819444 TEST=Manually tested. Change-Id: If772cc1efaf8105e92fa6bbfa709ee56110dfe90 Reviewed-on: https://chromium-review.googlesource.com/998514 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tim Zheng <timzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#548557} [modify] https://crrev.com/d044585cc001537d26d202c5d4d22fcbf5425d4c/chrome/browser/ui/app_list/crostini/crostini_util.cc [modify] https://crrev.com/d044585cc001537d26d202c5d4d22fcbf5425d4c/chrome/browser/ui/ash/launcher/crostini_app_window_shelf_controller.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6eeb4a7f5f0de6577c3eab5b481c3e54463b2e91 commit 6eeb4a7f5f0de6577c3eab5b481c3e54463b2e91 Author: Timothy Loh <timloh@chromium.org> Date: Sat Apr 21 00:32:21 2018 Use app ids from CrostiniAppRegistry in ShelfIDs. This patch moves the CreateCrostiniAppId from crostini_util.cc to the CrostiniAppRegistry and makes it look for a matching app registration. This will be useful when we want to make launching of apps focus existing windows if they exist. Bug: 819444 Change-Id: Ibef29d4441ea6f4aaab3ea45cce0982493f69a47 Reviewed-on: https://chromium-review.googlesource.com/1004564 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#552531} [modify] https://crrev.com/6eeb4a7f5f0de6577c3eab5b481c3e54463b2e91/chrome/browser/chromeos/crostini/crostini_registry_service.cc [modify] https://crrev.com/6eeb4a7f5f0de6577c3eab5b481c3e54463b2e91/chrome/browser/chromeos/crostini/crostini_registry_service.h [modify] https://crrev.com/6eeb4a7f5f0de6577c3eab5b481c3e54463b2e91/chrome/browser/chromeos/crostini/crostini_registry_service_unittest.cc [modify] https://crrev.com/6eeb4a7f5f0de6577c3eab5b481c3e54463b2e91/chrome/browser/ui/app_list/crostini/crostini_util.cc [modify] https://crrev.com/6eeb4a7f5f0de6577c3eab5b481c3e54463b2e91/chrome/browser/ui/app_list/crostini/crostini_util.h [modify] https://crrev.com/6eeb4a7f5f0de6577c3eab5b481c3e54463b2e91/chrome/browser/ui/ash/launcher/crostini_app_window_shelf_controller.cc [modify] https://crrev.com/6eeb4a7f5f0de6577c3eab5b481c3e54463b2e91/chrome/browser/ui/ash/launcher/crostini_app_window_shelf_controller.h [modify] https://crrev.com/6eeb4a7f5f0de6577c3eab5b481c3e54463b2e91/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e19e404fbd1e6e900fbe953eb5f4416f3136b2d commit 2e19e404fbd1e6e900fbe953eb5f4416f3136b2d Author: Tim Zheng <timzheng@google.com> Date: Tue Apr 24 20:41:23 2018 Use default Crostini icon on the shelf. This change just show the default penguin icon on the shelf for all running Crostini apps. Subsequent CLs will change to use real app specific icons. BUG= chromium:819444 TEST=Manually tested on an eve device. Change-Id: Ic5001edc1cf4a51acd54ea99ab43bbc1afa69dcf Reviewed-on: https://chromium-review.googlesource.com/1023292 Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Commit-Queue: Tim Zheng <timzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#553261} [modify] https://crrev.com/2e19e404fbd1e6e900fbe953eb5f4416f3136b2d/chrome/browser/ui/BUILD.gn [add] https://crrev.com/2e19e404fbd1e6e900fbe953eb5f4416f3136b2d/chrome/browser/ui/app_list/crostini/crostini_app_icon_loader.cc [add] https://crrev.com/2e19e404fbd1e6e900fbe953eb5f4416f3136b2d/chrome/browser/ui/app_list/crostini/crostini_app_icon_loader.h [modify] https://crrev.com/2e19e404fbd1e6e900fbe953eb5f4416f3136b2d/chrome/browser/ui/app_list/internal_app/internal_app_icon_loader.h [modify] https://crrev.com/2e19e404fbd1e6e900fbe953eb5f4416f3136b2d/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a59299c6698957375587040e39d906d570647bc commit 7a59299c6698957375587040e39d906d570647bc Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Fri Apr 27 02:57:21 2018 Enhanced crostini shelf app matching to search on name This covers the case for the examples of xterm & uxterm where their window_app_id was org.chromium.termain.wmclass.[U]XTerm but the desktop file is debian-[u]xterm.desktop and the unlocalized name is [U]XTerm. Bug: 819444 Test: Unit tests pass, verified xterm & uxterm show up on shelf Change-Id: I3c86d82085450a769f36617b21df7fe73ca27a2a Reviewed-on: https://chromium-review.googlesource.com/1031527 Reviewed-by: Nicholas Verne <nverne@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#554269} [modify] https://crrev.com/7a59299c6698957375587040e39d906d570647bc/chrome/browser/chromeos/crostini/crostini_registry_service.cc [modify] https://crrev.com/7a59299c6698957375587040e39d906d570647bc/chrome/browser/chromeos/crostini/crostini_registry_service_unittest.cc
Comment 1 by timzheng@chromium.org
, Mar 7 2018