New issue
Advanced search Search tips

Issue 819438 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Offline Pages P2P: bad NTP behavior when offline page is modified

Project Member Reported by dewittj@chromium.org, Mar 7 2018

Issue description

Chrome Version: Tip of Tree @ crrev.com/538186
OS: Android x86 emulator

What steps will reproduce the problem?
(1) Download an offline page.  This becomes trusted.
(2) Surf the page enough that it shows up in your TopSites list. Note that it should have the blue "offline" check mark.
(3) Edit the MHTML page so that the hash verification fails.

What is the expected result?
When the NTP opens, we should no longer see the blue check mark, since
clicking the icon while offline will no longer give you offline content.

What happens instead?
Blue checkmark visible, on tap the user navigates to the online page and gets a dino page.  When the user long-presses and "Download Link", the Download again? infobar pops up (even though this page is no longer associated with the online URL when navigating.)

 
Cc: jianli@chromium.org
Owner: petewil@chromium.org
Status: Assigned (was: Untriaged)
Over to Pete/Jian for discussion about how to fix this.
Status: WontFix (was: Assigned)
The checkmark is indicating "available offline", not "trusted".  So, it makes sense to still show as available offline even if it is modified

The "trusted" part is conveyed by the omnibox treatment.  A trusted, unmodified page will show "offline" in the Omnibox, followed by the URL of the origin website.

An untrusted page will show a file:// URL with no security treatment, and no mention of the origin website.

Sign in to add a comment