Allow pending draws to block commit for synchronous compositor |
|||
Issue descriptionIn crrev.com/1092123005, we set active_tree_needs_first_draw_ to false on invalidate so that it won't block commits. This was because the synchronous compositor did not guarantee that a draw will happen after an invalidate. If we undo the above (don't change active_tree_needs_first_draw_ on invalidate), fallback tick handling (crrev.com/1782093002) gurantees that we *will* still have draw after invalidate. So, remove https://cs.chromium.org/chromium/src/cc/scheduler/scheduler_state_machine.cc?sq=package:chromium&l=917 and the associated test: SchedulerTest.SynchronousCompositorDoubleCommitWithoutDraw
,
Mar 7 2018
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/989dd34c86ee3a462c467d0c4200faa9046fa496 commit 989dd34c86ee3a462c467d0c4200faa9046fa496 Author: James Wallace-Lee <jamwalla@chromium.org> Date: Fri Mar 09 20:57:17 2018 Don't set active_tree_needs_first_draw_ on invalidate active_tree_needs_first_draw_ was set to false on invalidate so that it wouldn't block commits. Instead, fallback tick handling guarantees that every activated frame has a draw. This CL removes the change along with its associated test (introduced in crrev.com/1092123005). Bug: 819430 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ibf6008512638943b7caa771f7ca6a953851607d6 Reviewed-on: https://chromium-review.googlesource.com/953208 Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Cr-Commit-Position: refs/heads/master@{#542216} [modify] https://crrev.com/989dd34c86ee3a462c467d0c4200faa9046fa496/cc/scheduler/scheduler_state_machine.cc [modify] https://crrev.com/989dd34c86ee3a462c467d0c4200faa9046fa496/cc/scheduler/scheduler_unittest.cc
,
Mar 12 2018
done, I guess presumably wall of perf alerts hasn't been filed yet though |
|||
►
Sign in to add a comment |
|||
Comment 1 by boliu@chromium.org
, Mar 7 2018