New issue
Advanced search Search tips

Issue 819425 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Desktop Linux: Omnibox results lost their blue selection highlight from GTK theming

Project Member Reported by tapted@chromium.org, Mar 7 2018

Issue description

Chrome Version       : 67

regressed in r541064

started -> https://chromium-review.googlesource.com/952503
 
Screenshot from 2018-03-07 11-16-12.png
29.6 KB View Download
Labels: -Type-Bug -Pri-3 ReleaseBlock-Dev Pri-1 Type-Bug-Regression
Labels: M-67
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50245fb1338161b47a2a8ef8801b6ded44f09d85

commit 50245fb1338161b47a2a8ef8801b6ded44f09d85
Author: Trent Apted <tapted@chromium.org>
Date: Wed Mar 07 20:49:24 2018

Restore the blue highlight for GTK on Omnibox results.

The way GTK theming is plumbed through is very subtle, and we don't
know yet how that should influence new color schemes.

This CL tries to isolate (and make explicit) the complexity required
for GTK theming on Desktop Linux by introducing OmniboxTint::NATIVE,
as distinct from LIGHT and DARK used everywhere else.

Bug:  819425 , 801583
Change-Id: I34ad8113f5e66843dab685c3ce3470dd7bd7f675
Reviewed-on: https://chromium-review.googlesource.com/952503
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541570}
[modify] https://crrev.com/50245fb1338161b47a2a8ef8801b6ded44f09d85/chrome/browser/ui/omnibox/omnibox_theme.cc
[modify] https://crrev.com/50245fb1338161b47a2a8ef8801b6ded44f09d85/chrome/browser/ui/omnibox/omnibox_theme.h
[modify] https://crrev.com/50245fb1338161b47a2a8ef8801b6ded44f09d85/chrome/browser/ui/views/location_bar/location_bar_view.cc

Status: Fixed (was: Started)
Labels: TE-Verified-M67 TE-Verified-67.0.3365.0
Able to reproduce the issue on chrome build without fix
Verified the fix on Ubuntu 14.04 on Chrome version #67.0.3365.0 as per the comment#0
Attaching screen cast for reference.
Observed "able to see highlighted text in Omnibox search"
Hence, the fix is working as expected.
Adding the verified label.

Thanks!
819425.ogv
1.1 MB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7aecde2142f40040f62bbab2cad88c56dcec9079

commit 7aecde2142f40040f62bbab2cad88c56dcec9079
Author: Trent Apted <tapted@chromium.org>
Date: Fri Mar 16 09:40:33 2018

Ensure omnibox_theme.cc adapts to theme changes.

This is easily done with an override of View::OnThemeChanged()

Less easily done is a test: themes are complex. Add a test for the
selection highlight, which captures the current logic around theme
color propagation.

Bug: 801583,  819425 ,  704942 
Change-Id: I86f3e4d9b5a30db66ad5a28d2ce7581aa9f7320b
Reviewed-on: https://chromium-review.googlesource.com/952802
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543657}
[modify] https://crrev.com/7aecde2142f40040f62bbab2cad88c56dcec9079/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/7aecde2142f40040f62bbab2cad88c56dcec9079/chrome/browser/ui/views/location_bar/location_bar_view.h
[modify] https://crrev.com/7aecde2142f40040f62bbab2cad88c56dcec9079/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view_browsertest.cc

Sign in to add a comment