New issue
Advanced search Search tips

Issue 819407 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

TA/DA: auto-created CL by sheriff failed presubmit

Project Member Reported by st...@chromium.org, Mar 6 2018

Issue description

"sheriff-o-matic@appspot.gserviceaccount.com is not in AUTHORS file"
Looks like this wasn't enough:
https://signcla.corp.google.com/search?cla=google&q=sheriff-o-matic%40appspot.gserviceaccount.com

Is FindIt's service account in AUTHORS for auto-revert ?

Comment 2 by st...@chromium.org, Mar 7 2018

No, it is not. Not sure why this is triggered now.
Labels: Milestone-Workflow
Labels: -Pri-3 Pri-1
Summary: TA/DA: auto-created CL by sheriff failed presubmit (was: auto-created CL by sheriff failed presubmit)
upping pri since we want to promote this feature.
Cc: aga...@chromium.org tandrii@chromium.org
tandrii, agable: Do we need to add this service account to some other gerrit permissions config file before it can land CLs (more precisely, CLs authored by it can be landed)?
1. make sure account has "singed CLA".
2. add to AUTHORS (i think necessary for chromium/src)
3. add top-level OWNERS or bypass presubmit checks.

Comment 7 by aga...@chromium.org, Mar 21 2018

It is referencing the literal AUTHORS file: https://cs.chromium.org/chromium/src/AUTHORS

I really wish SoM generated CLs in the name of the person who asked it to do so :(
@agable that's the right ultimate solution. I'm wondering if we can get it usable in its current state with less work than that full oauth-delegating implementation will require.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/26cba2b3441efc7f7fbba20c860233c058ab95e0

commit 26cba2b3441efc7f7fbba20c860233c058ab95e0
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Mon Apr 02 22:41:45 2018

[som] TA/DA: Move gerrit calls to js in the browser.

This change adds a second login in order to make gerrit
calls from the browser using the user's identity. Having
two logins isn't great UX but I don't know how else to
accomplish this.  Also they only need to do the extra
login if they want to use this test expectation editing
feature.

Bug:  819407 
Change-Id: I809aa26eec4f40e20052606c270506e4ca207cb9
Reviewed-on: https://chromium-review.googlesource.com/987210
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>

[modify] https://crrev.com/26cba2b3441efc7f7fbba20c860233c058ab95e0/go/src/infra/appengine/sheriff-o-matic/frontend/main.go
[modify] https://crrev.com/26cba2b3441efc7f7fbba20c860233c058ab95e0/go/src/infra/appengine/sheriff-o-matic/backend/main.go
[modify] https://crrev.com/26cba2b3441efc7f7fbba20c860233c058ab95e0/go/src/infra/appengine/sheriff-o-matic/frontend/bower.json
[modify] https://crrev.com/26cba2b3441efc7f7fbba20c860233c058ab95e0/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-test-expectations/som-test-expectations.js
[modify] https://crrev.com/26cba2b3441efc7f7fbba20c860233c058ab95e0/go/src/infra/appengine/sheriff-o-matic/som/handler/layout_tests.go
[modify] https://crrev.com/26cba2b3441efc7f7fbba20c860233c058ab95e0/go/src/infra/appengine/sheriff-o-matic/som/handler/layout_tests_test.go
[modify] https://crrev.com/26cba2b3441efc7f7fbba20c860233c058ab95e0/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-test-expectations/som-test-expectations.html
[modify] https://crrev.com/26cba2b3441efc7f7fbba20c860233c058ab95e0/go/src/infra/appengine/sheriff-o-matic/frontend/queue.yaml

Status: Fixed (was: Assigned)
TA/DA CLs are now generated such that the SoM user is the owner/author, not the SoM service account.

Sign in to add a comment