TA/DA: auto-created CL by sheriff failed presubmit |
|||||
Issue description
,
Mar 7 2018
No, it is not. Not sure why this is triggered now.
,
Mar 7 2018
,
Mar 21 2018
upping pri since we want to promote this feature.
,
Mar 21 2018
tandrii, agable: Do we need to add this service account to some other gerrit permissions config file before it can land CLs (more precisely, CLs authored by it can be landed)?
,
Mar 21 2018
1. make sure account has "singed CLA". 2. add to AUTHORS (i think necessary for chromium/src) 3. add top-level OWNERS or bypass presubmit checks.
,
Mar 21 2018
It is referencing the literal AUTHORS file: https://cs.chromium.org/chromium/src/AUTHORS I really wish SoM generated CLs in the name of the person who asked it to do so :(
,
Mar 21 2018
@agable that's the right ultimate solution. I'm wondering if we can get it usable in its current state with less work than that full oauth-delegating implementation will require.
,
Apr 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/26cba2b3441efc7f7fbba20c860233c058ab95e0 commit 26cba2b3441efc7f7fbba20c860233c058ab95e0 Author: Sean McCullough <seanmccullough@chromium.org> Date: Mon Apr 02 22:41:45 2018 [som] TA/DA: Move gerrit calls to js in the browser. This change adds a second login in order to make gerrit calls from the browser using the user's identity. Having two logins isn't great UX but I don't know how else to accomplish this. Also they only need to do the extra login if they want to use this test expectation editing feature. Bug: 819407 Change-Id: I809aa26eec4f40e20052606c270506e4ca207cb9 Reviewed-on: https://chromium-review.googlesource.com/987210 Commit-Queue: Sean McCullough <seanmccullough@chromium.org> Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org> [modify] https://crrev.com/26cba2b3441efc7f7fbba20c860233c058ab95e0/go/src/infra/appengine/sheriff-o-matic/frontend/main.go [modify] https://crrev.com/26cba2b3441efc7f7fbba20c860233c058ab95e0/go/src/infra/appengine/sheriff-o-matic/backend/main.go [modify] https://crrev.com/26cba2b3441efc7f7fbba20c860233c058ab95e0/go/src/infra/appengine/sheriff-o-matic/frontend/bower.json [modify] https://crrev.com/26cba2b3441efc7f7fbba20c860233c058ab95e0/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-test-expectations/som-test-expectations.js [modify] https://crrev.com/26cba2b3441efc7f7fbba20c860233c058ab95e0/go/src/infra/appengine/sheriff-o-matic/som/handler/layout_tests.go [modify] https://crrev.com/26cba2b3441efc7f7fbba20c860233c058ab95e0/go/src/infra/appengine/sheriff-o-matic/som/handler/layout_tests_test.go [modify] https://crrev.com/26cba2b3441efc7f7fbba20c860233c058ab95e0/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-test-expectations/som-test-expectations.html [modify] https://crrev.com/26cba2b3441efc7f7fbba20c860233c058ab95e0/go/src/infra/appengine/sheriff-o-matic/frontend/queue.yaml
,
Apr 3 2018
TA/DA CLs are now generated such that the SoM user is the owner/author, not the SoM service account. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by seanmccullough@google.com
, Mar 6 2018