New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 819405 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 848978
issue 850328

Blocking:
issue 812037



Sign in to add a comment

[Demo mode] Browsing Restrictions

Project Member Reported by agawronska@chromium.org, Mar 6 2018

Issue description

Code to restrict browsing in a demo session to only safe sites and showing a customized UI in case of a user navigating to a restricted site.
 
I turned on:
* Safe Search
* Safe Browsing
* Restricted Mode for YouTube

This removes the unwanted result form the Google search results, You Tube search results and blocks access to pages with malware.
This does not prevent going to the page for adults if you type url.    
Labels: -Pri-3 -M-67 M-68 Pri-1
Summary: [Demo mode] Browsing Restrictions (was: Browsing Restrictions)
Cc: michae...@chromium.org
Owner: mitasev@google.com
Status: Assigned (was: Started)
We need 'Safe sites' to block adult/inappropriate content in the Demo mode. We would like to make this feature more generic by adding new Policy available for managed devices and users. For Demo Mode new Policy need to be available for Public Session.

(Additionally we would like to customize the message that is displayed for a blocked content.)  
Labels: -M-68 M-69
Cc: mitasev@chromium.org
Labels: OS-Chrome
Owner: michae...@chromium.org
Status: Started (was: Assigned)
The plan for filtering all URLs (not just search) for inappropriate content is to componentize part of the solution for supervised users, and use that when the new policy is set.
Blockedon: 848978
Blockedon: 850328
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cc3a9cef0c599dec52bf26f95c99d1bb43cf75b

commit 2cc3a9cef0c599dec52bf26f95c99d1bb43cf75b
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Fri Jun 08 00:33:11 2018

Move safe_search_api to //components

The SafeSearchURLChecker didn't depend on //chrome. Move it to a new
safe_search_api component.

We will reuse safe_search_api::URLChecker in a later CL for filtering
URLs based on the SafeSearch API (a generalization of
SupervisedUserURLFilter).

Because we're creating a namespace, we can drop the SafeSearch prefix
and move the Classification enum out of the URLChecker class. Also clean
up presubmit issues in changed lines.

Bug:  819405 
Change-Id: Iaf411b1232eb937f93056d8e3553435fb7779bee
Reviewed-on: https://chromium-review.googlesource.com/1081892
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565486}
[modify] https://crrev.com/2cc3a9cef0c599dec52bf26f95c99d1bb43cf75b/chrome/browser/BUILD.gn
[modify] https://crrev.com/2cc3a9cef0c599dec52bf26f95c99d1bb43cf75b/chrome/browser/supervised_user/supervised_user_url_filter.cc
[modify] https://crrev.com/2cc3a9cef0c599dec52bf26f95c99d1bb43cf75b/chrome/browser/supervised_user/supervised_user_url_filter.h
[modify] https://crrev.com/2cc3a9cef0c599dec52bf26f95c99d1bb43cf75b/chrome/test/BUILD.gn
[modify] https://crrev.com/2cc3a9cef0c599dec52bf26f95c99d1bb43cf75b/components/BUILD.gn
[add] https://crrev.com/2cc3a9cef0c599dec52bf26f95c99d1bb43cf75b/components/safe_search_api/BUILD.gn
[add] https://crrev.com/2cc3a9cef0c599dec52bf26f95c99d1bb43cf75b/components/safe_search_api/DEPS
[rename] https://crrev.com/2cc3a9cef0c599dec52bf26f95c99d1bb43cf75b/components/safe_search_api/OWNERS
[rename] https://crrev.com/2cc3a9cef0c599dec52bf26f95c99d1bb43cf75b/components/safe_search_api/url_checker.cc
[rename] https://crrev.com/2cc3a9cef0c599dec52bf26f95c99d1bb43cf75b/components/safe_search_api/url_checker.h
[rename] https://crrev.com/2cc3a9cef0c599dec52bf26f95c99d1bb43cf75b/components/safe_search_api/url_checker_unittest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fe58bf7cd272dd06c9ea10072599b8cebd6b7f0

commit 0fe58bf7cd272dd06c9ea10072599b8cebd6b7f0
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Thu Jul 26 20:40:27 2018

Extract URL filtering utilities

Moves some utility functions for URL filtering from
chrome/browser/supervised_users into components/policy. These will
continue to be used by supervised users, but can now also be used for
policy (namely the upcoming safe sites filter implementation).

Largely a refactoring. The only tangible difference is that the re2
regex objects used to be per-profile but are now global (static):
They used to be members of SupervisedUserURLFilter (which was owned by
the per-profile SupervisedUserService) but are now part of the
singleton EmbeddedURLExtractor helper.

Alternatively, we could create a new //components/url_filter component
with per-profile EmbeddedURLExtractor services, but that seemed like
overkill for a couple utility functions.

Bug:  819405 
Change-Id: I4f8313f46778447e123f0021dc3a32cb4598f58c
Reviewed-on: https://chromium-review.googlesource.com/1117884
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578428}
[modify] https://crrev.com/0fe58bf7cd272dd06c9ea10072599b8cebd6b7f0/chrome/browser/supervised_user/supervised_user_service.cc
[modify] https://crrev.com/0fe58bf7cd272dd06c9ea10072599b8cebd6b7f0/chrome/browser/supervised_user/supervised_user_url_filter.cc
[modify] https://crrev.com/0fe58bf7cd272dd06c9ea10072599b8cebd6b7f0/chrome/browser/supervised_user/supervised_user_url_filter.h
[modify] https://crrev.com/0fe58bf7cd272dd06c9ea10072599b8cebd6b7f0/chrome/browser/supervised_user/supervised_user_url_filter_unittest.cc
[modify] https://crrev.com/0fe58bf7cd272dd06c9ea10072599b8cebd6b7f0/components/policy/core/browser/BUILD.gn
[modify] https://crrev.com/0fe58bf7cd272dd06c9ea10072599b8cebd6b7f0/components/policy/core/browser/DEPS
[add] https://crrev.com/0fe58bf7cd272dd06c9ea10072599b8cebd6b7f0/components/policy/core/browser/url_util.cc
[add] https://crrev.com/0fe58bf7cd272dd06c9ea10072599b8cebd6b7f0/components/policy/core/browser/url_util.h
[add] https://crrev.com/0fe58bf7cd272dd06c9ea10072599b8cebd6b7f0/components/policy/core/browser/url_util_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/527bcdc02f68c12885551bebbeb20e412185f509

commit 527bcdc02f68c12885551bebbeb20e412185f509
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Tue Jul 31 06:58:22 2018

Move SafeSites policy pref to //components/policy

The pref for the Safe Sites filter, kSafeSitesFilterBehavior, should be
accessible from //components/policy, where the filter itself will check
it once implemented.

Note that this policy's pref is unused until the follow-up CL.

Bug:  819405 
Change-Id: If87877488067ee008f16d2dc848f5e2ab01de25f
Reviewed-on: https://chromium-review.googlesource.com/1117877
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579331}
[modify] https://crrev.com/527bcdc02f68c12885551bebbeb20e412185f509/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/527bcdc02f68c12885551bebbeb20e412185f509/chrome/browser/prefs/pref_service_incognito_whitelist.cc
[modify] https://crrev.com/527bcdc02f68c12885551bebbeb20e412185f509/chrome/common/pref_names.cc
[modify] https://crrev.com/527bcdc02f68c12885551bebbeb20e412185f509/chrome/common/pref_names.h
[modify] https://crrev.com/527bcdc02f68c12885551bebbeb20e412185f509/components/policy/core/common/policy_pref_names.cc
[modify] https://crrev.com/527bcdc02f68c12885551bebbeb20e412185f509/components/policy/core/common/policy_pref_names.h

Blocking: 812037
Labels: -M-69 M-70
CL is ready but blocked on a traffic_annotation bug I'm trying to work out.
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01d7b5dfa3f9a359b67b321e9c545ce8faffef35

commit 01d7b5dfa3f9a359b67b321e9c545ce8faffef35
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Tue Aug 21 07:55:54 2018

Check SafeSearch API in PolicyBlacklistNavigationThrottle

When the SafeSitesFilterBehavior policy is enabled, filter top-level
HTTP[S] navigations using Google's SafeSearch API (porn classifier).

The SafeSites check is skipped if the URL is blacklisted or whitelisted
by policy.

This check is added to the existing PolicyBlacklistNavigationThrottle
instead of creating a standalone navigation throttle because it depends
on the blacklist/whitelist check that's already there, and conceptually
serves a similar purpose (determining if a URL should be blocked by
policy).

Bug:  819405 
Change-Id: Ica243fdbf44b06a2fc4148fb68f47a11d9b79a6b
Reviewed-on: https://chromium-review.googlesource.com/1119102
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584681}
[modify] https://crrev.com/01d7b5dfa3f9a359b67b321e9c545ce8faffef35/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/01d7b5dfa3f9a359b67b321e9c545ce8faffef35/components/BUILD.gn
[modify] https://crrev.com/01d7b5dfa3f9a359b67b321e9c545ce8faffef35/components/policy/content/BUILD.gn
[modify] https://crrev.com/01d7b5dfa3f9a359b67b321e9c545ce8faffef35/components/policy/content/DEPS
[modify] https://crrev.com/01d7b5dfa3f9a359b67b321e9c545ce8faffef35/components/policy/content/policy_blacklist_navigation_throttle.cc
[modify] https://crrev.com/01d7b5dfa3f9a359b67b321e9c545ce8faffef35/components/policy/content/policy_blacklist_navigation_throttle.h
[add] https://crrev.com/01d7b5dfa3f9a359b67b321e9c545ce8faffef35/components/policy/content/policy_blacklist_navigation_throttle_unittest.cc
[add] https://crrev.com/01d7b5dfa3f9a359b67b321e9c545ce8faffef35/components/policy/content/policy_blacklist_service.cc
[add] https://crrev.com/01d7b5dfa3f9a359b67b321e9c545ce8faffef35/components/policy/content/policy_blacklist_service.h
[modify] https://crrev.com/01d7b5dfa3f9a359b67b321e9c545ce8faffef35/components/policy/core/browser/url_blacklist_manager.cc
[modify] https://crrev.com/01d7b5dfa3f9a359b67b321e9c545ce8faffef35/components/policy/core/browser/url_blacklist_policy_handler.h
[modify] https://crrev.com/01d7b5dfa3f9a359b67b321e9c545ce8faffef35/components/safe_search_api/BUILD.gn
[add] https://crrev.com/01d7b5dfa3f9a359b67b321e9c545ce8faffef35/components/safe_search_api/stub_url_checker.cc
[add] https://crrev.com/01d7b5dfa3f9a359b67b321e9c545ce8faffef35/components/safe_search_api/stub_url_checker.h
[modify] https://crrev.com/01d7b5dfa3f9a359b67b321e9c545ce8faffef35/components/safe_search_api/url_checker_unittest.cc
[modify] https://crrev.com/01d7b5dfa3f9a359b67b321e9c545ce8faffef35/tools/traffic_annotation/auditor/safe_list.txt
[modify] https://crrev.com/01d7b5dfa3f9a359b67b321e9c545ce8faffef35/tools/traffic_annotation/summary/annotations.xml

Status: Fixed (was: Started)

Sign in to add a comment