Issue metadata
Sign in to add a comment
|
unibuild: chromeos-bootimage broken for shared depthcharge |
||||||||||||||||||||||||
Issue description
I created dtsi file for a family that will have a shared depthcharge across models, but with varying coreboot values. The chromeos-bootimage ebuild currently breaks for this case, as it relies on using the coreboot build target to find depthcharge.
Consider the following example model.dtsi:
&models {
variant: variant {
powerd-prefs = "variant";
test-label = "variant";
firmware {
bcs-overlay = "overlay-baseboard-private";
/* No Firmware URIs ready yet. */
no-firmware = "true";
build-targets {
coreboot = "variant";
ec = "variant";
depthcharge = "baseboard";
libpayload = "baseboard";
};
};
};
};
Iterating over just the coreboot build targets in src_compile() and src_install() will give the wrong path or target for depthcharge.
I have a local fix that seems to work to fix this, which I'll mail out.
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d3c654953a5459f80ecba9b16caf319116a4667f commit d3c654953a5459f80ecba9b16caf319116a4667f Author: Justin TerAvest <teravest@chromium.org> Date: Fri Mar 09 03:28:59 2018 chromeos-bootimage: Fix depthcharge target use The current logic for building images for chromeos-bootimage iterates over coreboot build targets. This is problematic when a different target is being used for depthcharge; the ebuild script is unable to find the correct file to pick up. This changes the logic to iterate per firmware combination to ensure that the right image is built. The files are current named after the coreboot build target, but that will change once a "name" field is added for build-targets in the master config. BUG= chromium:819363 TEST=Tested a dtsi with depthcharge != coreboot target CQ-DEPEND=CL:953124 Change-Id: I735d3e4833574943c6aeb812620e24bdbea920ba Reviewed-on: https://chromium-review.googlesource.com/952205 Commit-Ready: Justin TerAvest <teravest@chromium.org> Tested-by: Justin TerAvest <teravest@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org> Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Justin TerAvest <teravest@chromium.org> [modify] https://crrev.com/d3c654953a5459f80ecba9b16caf319116a4667f/sys-boot/chromeos-bootimage/chromeos-bootimage-0.0.3.ebuild [rename] https://crrev.com/d3c654953a5459f80ecba9b16caf319116a4667f/sys-boot/chromeos-bootimage/chromeos-bootimage-0.0.3-r20.ebuild |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by teravest@chromium.org
, Mar 7 2018Status: Duplicate (was: Started)