New issue
Advanced search Search tips

Issue 819351 link

Starred by 1 user
Status: Fixed
Owner:
jamescook@chromium.org
Closed: Mar 2018
Cc:
dtseng@chromium.org
lpalmaro@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

ChromeVox panel not shown when pressing Search+/ (find) in fullscreen mode

Project Member Reported by dmazz...@chromium.org, Mar 6 2018 
Repro:

1. Enable ChromeVox
2. Go fullscreen (F4)
   Note that the ChromeVox panel is hidden but it leaves a shadow on the screen, that's a separate bug that should be fixed.
3. Press Search+/

The ChromeVox panel should be shown when it's focused via Search+/ for Find, but it's still not shown. It still seems to work, but sighted users can't follow what's going on.

Note that Search+. (to open the menus) works correctly.

It's unclear if this is a regression. It doesn't affect blind users so it's not a P1 or release blocer.

Comment 1 by jamescook@chromium.org, Mar 7 2018

Owner: jamescook@chromium.org
Status: Started (was: Untriaged)
I have a CL that fixes this.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b263b51b16652c73850848cf21d7b1cd9058281a

commit b263b51b16652c73850848cf21d7b1cd9058281a
Author: James Cook <jamescook@chromium.org>
Date: Wed Mar 07 22:30:33 2018

cros: Move ChromeVoxPanel bounds management into ash

ChromeVoxPanel depends on knowledge of fullscreen state and docked
magnifier state in order to compute its bounds. In addition it can
update the window manager's work area. Under go/mustash this knowledge
lives in the ash process, not in the browser. Therefore move the
bounds and work area management into ash.

Next steps include introducing a mojo interface for setting the
ChromeVox panel's fullscreen state and moving AccessibilityObserver
support to ash::AccessibilityController from the system tray code.

Bug:  628655 ,  819351 
Test: added to ash_unittests
Change-Id: Ibb27a0b8ab6b998ecd305b7e7bfbad8b35853613
Reviewed-on: https://chromium-review.googlesource.com/952263
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541614}
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/BUILD.gn
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/accessibility/accessibility_controller.h
[add] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/accessibility/accessibility_panel_layout_manager.cc
[add] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/accessibility/accessibility_panel_layout_manager.h
[add] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/accessibility/accessibility_panel_layout_manager_unittest.cc
[delete] https://crrev.com/aff665fc085f8acf570abdab73098d833fdb8b7c/ash/accessibility/chromevox_layout_manager.cc
[delete] https://crrev.com/aff665fc085f8acf570abdab73098d833fdb8b7c/ash/accessibility/chromevox_layout_manager.h
[delete] https://crrev.com/aff665fc085f8acf570abdab73098d833fdb8b7c/ash/accessibility/chromevox_layout_manager_unittest.cc
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/public/cpp/shell_window_ids.cc
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/public/cpp/shell_window_ids.h
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/root_window_controller.cc
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/shelf/shelf.cc
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/shelf/shelf.h
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/wm/lock_action_handler_layout_manager_unittest.cc
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/ash/wm/lock_layout_manager_unittest.cc
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/chrome/browser/chromeos/accessibility/chromevox_panel.cc
[modify] https://crrev.com/b263b51b16652c73850848cf21d7b1cd9058281a/chrome/browser/chromeos/accessibility/chromevox_panel.h

Comment 3 by jamescook@chromium.org, Mar 7 2018

Status: Fixed (was: Started)
►

Sign in to add a comment