Issue metadata
Sign in to add a comment
|
Test all widgets activated in a browser test for accessibility violations |
||||||||||||||||||||||||
Issue descriptionTest any widget made visible in a browsertest for accessibility. The first test will be to ensure that focusable objects have an accessible name. This catches a lot of errors.
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22094f4b62ecb6dcf3483ae4ba5d9e20785d0fbf commit 22094f4b62ecb6dcf3483ae4ba5d9e20785d0fbf Author: Aaron Leventhal <aleventhal@chromium.org> Date: Wed Mar 07 18:04:01 2018 Accessible name via tooltip for invert bubble learn more button This is split out from the CL to test all widgets and views for nameless focusable objects. See crrev.com/c/951933. Bug: 819350 Change-Id: Ia777a77da739ead813d8f898e194366d20e3601e Reviewed-on: https://chromium-review.googlesource.com/952987 Reviewed-by: Nektarios Paisios <nektar@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#541496} [modify] https://crrev.com/22094f4b62ecb6dcf3483ae4ba5d9e20785d0fbf/chrome/browser/ui/views/accessibility/invert_bubble_view.cc
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce533692a5cb70441217054efd1fe6d43ca83e8a commit ce533692a5cb70441217054efd1fe6d43ca83e8a Author: Aaron Leventhal <aleventhal@chromium.org> Date: Wed Mar 07 18:16:16 2018 Accessible names for nameless focusable views in autofill code This is split out from the CL to test all widgets and views for nameless focusable objects. See crrev.com/c/951933. Bug: 819350 Change-Id: I2e9a97939e502493e864fec9bb6b840338905a77 Reviewed-on: https://chromium-review.googlesource.com/952988 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#541505} [modify] https://crrev.com/ce533692a5cb70441217054efd1fe6d43ca83e8a/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc [modify] https://crrev.com/ce533692a5cb70441217054efd1fe6d43ca83e8a/components/autofill/core/browser/autofill_test_utils.cc [modify] https://crrev.com/ce533692a5cb70441217054efd1fe6d43ca83e8a/components/autofill_strings.grdp
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0959b8ccf56b53002c657d22506886d9058c98a5 commit 0959b8ccf56b53002c657d22506886d9058c98a5 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Wed Mar 07 20:01:13 2018 Accessible name for focusable close button This is split out from the CL to test all widgets and views for nameless focusable objects. See crrev.com/c/951933. Bug: 819350 Change-Id: I87e8b7ec9ec968ea5f3b2648b1242ddf60be4514 Reviewed-on: https://chromium-review.googlesource.com/952709 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#541537} [modify] https://crrev.com/0959b8ccf56b53002c657d22506886d9058c98a5/chrome/browser/ui/views/fullscreen_control/fullscreen_control_view.cc
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fdb6de026767315ca219fecc179e29bcb4071f45 commit fdb6de026767315ca219fecc179e29bcb4071f45 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Wed Mar 07 22:01:52 2018 Pass accessible name tests This is split out from the CL to test all widgets and views for nameless focusable objects. See crrev.com/c/951933. Bug: 819350 Change-Id: I0b8b9b17a69d01986adf328b808c71bacd2fb8fe Reviewed-on: https://chromium-review.googlesource.com/953046 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#541600} [modify] https://crrev.com/fdb6de026767315ca219fecc179e29bcb4071f45/chrome/browser/ui/views/constrained_window_views_browsertest.cc [modify] https://crrev.com/fdb6de026767315ca219fecc179e29bcb4071f45/chrome/browser/ui/views/download/download_danger_prompt_views.cc
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea0f08d5eff509da36f6f530b5066ff379f9eaf8 commit ea0f08d5eff509da36f6f530b5066ff379f9eaf8 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Wed Mar 07 23:16:17 2018 Add accessible name for request pin view passphrase field This is split out from the CL to test all widgets and views for nameless focusable objects. See crrev.com/c/951933. Bug: 819350 Change-Id: Ic2218d2ce520b53b6da32947d4def70a72f69c27 Reviewed-on: https://chromium-review.googlesource.com/952707 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#541635} [modify] https://crrev.com/ea0f08d5eff509da36f6f530b5066ff379f9eaf8/chrome/browser/chromeos/ui/request_pin_view.cc
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/373abe246148464fd015b33b1b3f1cb07425d85f commit 373abe246148464fd015b33b1b3f1cb07425d85f Author: Aaron Leventhal <aleventhal@chromium.org> Date: Thu Mar 08 00:31:29 2018 Accessible names for nameless focusable glass browser frame buttons This is split out from the CL to test all widgets and views for nameless focusable objects. See crrev.com/c/951933. Bug: 819350 Change-Id: If1a9f377c0179c0b4b9b1f18d870ccccfc221296 Reviewed-on: https://chromium-review.googlesource.com/952328 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#541653} [modify] https://crrev.com/373abe246148464fd015b33b1b3f1cb07425d85f/chrome/browser/ui/views/frame/glass_browser_frame_view.cc [modify] https://crrev.com/373abe246148464fd015b33b1b3f1cb07425d85f/chrome/browser/ui/views/frame/glass_browser_frame_view.h [modify] https://crrev.com/373abe246148464fd015b33b1b3f1cb07425d85f/chrome/browser/ui/views/frame/windows_10_caption_button.cc [modify] https://crrev.com/373abe246148464fd015b33b1b3f1cb07425d85f/chrome/browser/ui/views/frame/windows_10_caption_button.h
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/420f236eca237b06dd2fb00f24a3803f49390884 commit 420f236eca237b06dd2fb00f24a3803f49390884 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Thu Mar 08 12:38:57 2018 Pass accessible name tests for tree view This is split out from the CL to test all widgets and views for nameless focusable objects. See crrev.com/c/951933. Bug: 819350 Change-Id: Iae8c931231d6516cb64abe6386b4c3e343b9870c Reviewed-on: https://chromium-review.googlesource.com/952329 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#541777} [modify] https://crrev.com/420f236eca237b06dd2fb00f24a3803f49390884/ui/views/controls/tree/tree_view.cc
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a49710cf797ffce483b53143b71499b674581b4 commit 1a49710cf797ffce483b53143b71499b674581b4 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Fri Mar 09 22:10:41 2018 Accessible name for nameless window selector textfield This is split out from the CL to test all widgets and views for nameless focusable objects. See crrev.com/c/951933. Bug: 819350 Change-Id: I4eb266d06d6468657b2cf00873a601efb976166c Reviewed-on: https://chromium-review.googlesource.com/952327 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#542245} [modify] https://crrev.com/1a49710cf797ffce483b53143b71499b674581b4/ash/ash_strings.grd [modify] https://crrev.com/1a49710cf797ffce483b53143b71499b674581b4/ash/wm/overview/window_selector.cc
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d02db12ff9e040447350388fb43aa3f0101f618 commit 2d02db12ff9e040447350388fb43aa3f0101f618 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Fri Mar 09 22:34:22 2018 Accessible name close button This is split out from the CL to test all widgets and views for nameless focusable objects. See crrev.com/c/951933. Bug: 819350 Change-Id: Ie5e8a17f1656ce1c7545dadacee163499563da70 Reviewed-on: https://chromium-review.googlesource.com/952330 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#542253} [modify] https://crrev.com/2d02db12ff9e040447350388fb43aa3f0101f618/chrome/browser/ui/views/ime/ime_window_frame_view.cc
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39b6068c602516e1654baca22bf33147872e0045 commit 39b6068c602516e1654baca22bf33147872e0045 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Tue Mar 13 21:00:38 2018 Similar role and name in login_shelf_view and shelf_view This is split out from the CL to test all widgets and views for nameless focusable objects. See crrev.com/c/951933. Bug: 819350 Change-Id: Iecef5783a292363f8f994cdce5f5f24f92d48025 Reviewed-on: https://chromium-review.googlesource.com/961281 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#542905} [modify] https://crrev.com/39b6068c602516e1654baca22bf33147872e0045/ash/shelf/login_shelf_view.cc
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d353d158510cbb3520c6fa94a5d646a54fd118f4 commit d353d158510cbb3520c6fa94a5d646a54fd118f4 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Tue Mar 13 22:00:18 2018 Window selector close button missing accessible name This is split out from the CL to test all widgets and views for nameless focusable objects. See crrev.com/c/951933. Bug: 819350 Change-Id: I4435ed2c1c6fcb7148abc2a15570d07c2dca292a Reviewed-on: https://chromium-review.googlesource.com/961090 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#542928} [modify] https://crrev.com/d353d158510cbb3520c6fa94a5d646a54fd118f4/ash/wm/overview/window_selector_item.cc
,
Mar 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c38b35ae6888784582324d3f2860377f1068ca18 commit c38b35ae6888784582324d3f2860377f1068ca18 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Wed Mar 14 13:26:43 2018 Ensure accessible names for app browser windows and in window selector The window selector gets names from Aura windows. Propagate titles from app names to the aura window titles, as the web content itself may not have a title. This is split out from the CL to test all widgets and views for nameless focusable objects. See crrev.com/c/951933. Bug: 819350 Change-Id: Id61d9398824b836a644c57813f1521faf1aae70f Reviewed-on: https://chromium-review.googlesource.com/961093 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#543063} [modify] https://crrev.com/c38b35ae6888784582324d3f2860377f1068ca18/chrome/browser/ui/browser.cc
,
Mar 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea2a050176cc7ca6bd185b72eb80021bd2cf571b commit ea2a050176cc7ca6bd185b72eb80021bd2cf571b Author: Aaron Leventhal <aleventhal@chromium.org> Date: Wed Mar 14 15:17:17 2018 Accessible info for notification header view This is split out from the CL to test all widgets and views for nameless focusable objects. See crrev.com/c/951933. Bug: 819350 Change-Id: Ic6426632f641ac2bfa83616684c7c61d01228e8c Reviewed-on: https://chromium-review.googlesource.com/961246 Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#543087} [modify] https://crrev.com/ea2a050176cc7ca6bd185b72eb80021bd2cf571b/ui/message_center/views/notification_header_view.cc [modify] https://crrev.com/ea2a050176cc7ca6bd185b72eb80021bd2cf571b/ui/message_center/views/notification_header_view.h
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b116b4d6e59755600220bf2271aaaa66b8b4c2a commit 2b116b4d6e59755600220bf2271aaaa66b8b4c2a Author: Aaron Leventhal <aleventhal@chromium.org> Date: Fri Mar 16 20:48:30 2018 Accessibility checks shelf crash fix Bug: 819350 Change-Id: I244117aa25f5da865af5d3d8492079337b3f9696 Reviewed-on: https://chromium-review.googlesource.com/964244 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#543819} [modify] https://crrev.com/2b116b4d6e59755600220bf2271aaaa66b8b4c2a/ash/shelf/shelf.cc [modify] https://crrev.com/2b116b4d6e59755600220bf2271aaaa66b8b4c2a/ash/shelf/shelf_widget.cc [modify] https://crrev.com/2b116b4d6e59755600220bf2271aaaa66b8b4c2a/ash/shelf/shelf_widget.h
,
Mar 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/431fdef2fb2ae464198342cd07dd32ea2d258381 commit 431fdef2fb2ae464198342cd07dd32ea2d258381 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Mon Mar 19 18:52:43 2018 Accessibility checks flag warning tray crash fix Bug: 819350 Change-Id: I75abdd3988c0c6ff3e73e67bc8fdef30e05b6aae Reviewed-on: https://chromium-review.googlesource.com/964246 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#544088} [modify] https://crrev.com/431fdef2fb2ae464198342cd07dd32ea2d258381/ash/system/flag_warning/flag_warning_tray.cc [modify] https://crrev.com/431fdef2fb2ae464198342cd07dd32ea2d258381/ash/system/flag_warning/flag_warning_tray_unittest.cc [modify] https://crrev.com/431fdef2fb2ae464198342cd07dd32ea2d258381/ash/system/status_area_widget.cc
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a869fb4b05a2c7f3348de963a3acd740007fc08 commit 0a869fb4b05a2c7f3348de963a3acd740007fc08 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Tue Mar 27 00:33:19 2018 Test any widget activated in a browser test for accessibility violations Use ChromeViewsDelegate/WidgetObserver combination to ensure that all widgets are tested for accessibility as they become hidden or visible in a browsertest. The test goes through the View entire subtree and ensure any focusable View has an accessible name. Bug: 819350 Change-Id: I213e02bcfb1ec64aefc528cbda6a8a2a1d7bd0d0 Reviewed-on: https://chromium-review.googlesource.com/951933 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#545904} [modify] https://crrev.com/0a869fb4b05a2c7f3348de963a3acd740007fc08/chrome/test/BUILD.gn [modify] https://crrev.com/0a869fb4b05a2c7f3348de963a3acd740007fc08/chrome/test/base/in_process_browser_test.cc [modify] https://crrev.com/0a869fb4b05a2c7f3348de963a3acd740007fc08/chrome/test/base/in_process_browser_test.h [add] https://crrev.com/0a869fb4b05a2c7f3348de963a3acd740007fc08/chrome/test/views/accessibility_checker.cc [add] https://crrev.com/0a869fb4b05a2c7f3348de963a3acd740007fc08/chrome/test/views/accessibility_checker.h [add] https://crrev.com/0a869fb4b05a2c7f3348de963a3acd740007fc08/chrome/test/views/accessibility_checker_unittest.cc
,
Mar 27 2018
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/777cefdf44a3102c58dfe7836dbac67caf328574 commit 777cefdf44a3102c58dfe7836dbac67caf328574 Author: Ben Wells <benwells@chromium.org> Date: Tue Mar 27 04:59:42 2018 Revert "Test any widget activated in a browser test for accessibility violations" This reverts commit 0a869fb4b05a2c7f3348de963a3acd740007fc08. Reason for revert: New checker is causing errors on bot e.g. https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/26753 from the failure: The following view violates DoesViewHaveAccessibilityErrors(): browser/ui/views/frame/BrowserRootView > ui/views/window/NonClientView > BrowserView > TopContainerView > ToolbarView > View > MenuButton (id 1008) - Focusable View has no accessible name or placeholder, and the name attribute does not use kAttributeExplicitlyEmpty. Original change's description: > Test any widget activated in a browser test for accessibility violations > > Use ChromeViewsDelegate/WidgetObserver combination to ensure that all > widgets are tested for accessibility as they become hidden or visible > in a browsertest. > > The test goes through the View entire subtree and ensure any focusable > View has an accessible name. > > Bug: 819350 > Change-Id: I213e02bcfb1ec64aefc528cbda6a8a2a1d7bd0d0 > Reviewed-on: https://chromium-review.googlesource.com/951933 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545904} TBR=sky@chromium.org,tapted@chromium.org,aleventhal@chromium.org Change-Id: I4acc057b19df35a9350ae04efa06e5f6b69b2e88 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 819350 Reviewed-on: https://chromium-review.googlesource.com/981634 Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#546020} [modify] https://crrev.com/777cefdf44a3102c58dfe7836dbac67caf328574/chrome/test/BUILD.gn [modify] https://crrev.com/777cefdf44a3102c58dfe7836dbac67caf328574/chrome/test/base/in_process_browser_test.cc [modify] https://crrev.com/777cefdf44a3102c58dfe7836dbac67caf328574/chrome/test/base/in_process_browser_test.h [delete] https://crrev.com/fc982567cd04a69c1ea0bc39bd87090b6edea0c9/chrome/test/views/accessibility_checker.cc [delete] https://crrev.com/fc982567cd04a69c1ea0bc39bd87090b6edea0c9/chrome/test/views/accessibility_checker.h [delete] https://crrev.com/fc982567cd04a69c1ea0bc39bd87090b6edea0c9/chrome/test/views/accessibility_checker_unittest.cc
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/febc3ce9dab6ea148895e1d8c311b6327d4c3c84 commit febc3ce9dab6ea148895e1d8c311b6327d4c3c84 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Thu Apr 19 14:55:56 2018 Accessible name for intent picker bubble view Need accessible name to pass upcoming accessibility checks landing in crrev.com/c/981937 Bug: 819350 Change-Id: I986dd34968136f49f436c24f115f3c70cc800e6f Reviewed-on: https://chromium-review.googlesource.com/1017605 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#552014} [modify] https://crrev.com/febc3ce9dab6ea148895e1d8c311b6327d4c3c84/chrome/browser/ui/views/intent_picker_bubble_view.cc
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72226aa9775244c1b6ef3d520f8350eb15459623 commit 72226aa9775244c1b6ef3d520f8350eb15459623 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Mon Apr 23 20:14:02 2018 Use accessible name in toolbar test Accessibility checks from http://crrev.com/c/981937 fail in ComponentToolbarActionsBrowserTest.ComponentToolbarActionsShowUpAndRespondToClicks. This adds an accessible name via the controller used in the test. Bug: 819350 Change-Id: I64c95fbea582816c47d0215065fc8983f78a2bb7 Reviewed-on: https://chromium-review.googlesource.com/1023211 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#552806} [modify] https://crrev.com/72226aa9775244c1b6ef3d520f8350eb15459623/chrome/browser/ui/toolbar/test_toolbar_action_view_controller.cc
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/373e1cddeafe7b6ec8ebbef802bda4ab9f69b2c2 commit 373e1cddeafe7b6ec8ebbef802bda4ab9f69b2c2 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Mon Apr 23 23:26:05 2018 Reland: Test any widget activated in a browser test for accessibility violations Use ChromeViewsDelegate/WidgetObserver combination to ensure that all widgets are tested for accessibility as they become hidden or visible in a browsertest. The test goes through the View entire subtree and ensure any focusable View has an accessible name. TBR=sky@chromium.org,tapted@chromium.org CQ_INCLUDE_TRYBOTS: master.tryserver.chromium.linux:linux_chromium_msan_rel_ng,linux_chromium_asan_rel_ng,linux_chromium_chromeos_asan_rel_ng,linux_chromium_chromeos_msan_rel_ng Bug: 819350 Change-Id: I001d4cd2eac566445ec65c0228100e5323610765 Reviewed-on: https://chromium-review.googlesource.com/981937 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#552892} [modify] https://crrev.com/373e1cddeafe7b6ec8ebbef802bda4ab9f69b2c2/chrome/test/BUILD.gn [modify] https://crrev.com/373e1cddeafe7b6ec8ebbef802bda4ab9f69b2c2/chrome/test/base/in_process_browser_test.cc [modify] https://crrev.com/373e1cddeafe7b6ec8ebbef802bda4ab9f69b2c2/chrome/test/base/in_process_browser_test.h [add] https://crrev.com/373e1cddeafe7b6ec8ebbef802bda4ab9f69b2c2/chrome/test/views/accessibility_checker.cc [add] https://crrev.com/373e1cddeafe7b6ec8ebbef802bda4ab9f69b2c2/chrome/test/views/accessibility_checker.h [add] https://crrev.com/373e1cddeafe7b6ec8ebbef802bda4ab9f69b2c2/chrome/test/views/accessibility_checker_unittest.cc |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Mar 7 2018