New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 819346 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Remove code for CrOS leak detector.

Project Member Reported by erikc...@chromium.org, Mar 6 2018

Issue description

See launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=600044

The leak detector is not actively being maintained. 

To the best of my knowledge, there are no recent bugs filed/fixed from the leak detector.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20ff924afe87fcf47086eb4247d847e4fd271167

commit 20ff924afe87fcf47086eb4247d847e4fd271167
Author: erikchen <erikchen@chromium.org>
Date: Wed Mar 07 15:25:52 2018

Remove CrOS leak detector.

The tool is unmaintained, has not been finding bugs, and no one wants to
maintain it.

Bug:  819346 
Change-Id: I348fe7d014f7d669465efe271ec435e0e18a7524
TBR: sky@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/951932
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541440}
[modify] https://crrev.com/20ff924afe87fcf47086eb4247d847e4fd271167/chrome/app/BUILD.gn
[modify] https://crrev.com/20ff924afe87fcf47086eb4247d847e4fd271167/chrome/app/DEPS
[modify] https://crrev.com/20ff924afe87fcf47086eb4247d847e4fd271167/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/20ff924afe87fcf47086eb4247d847e4fd271167/chrome/browser/BUILD.gn
[modify] https://crrev.com/20ff924afe87fcf47086eb4247d847e4fd271167/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/20ff924afe87fcf47086eb4247d847e4fd271167/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/20ff924afe87fcf47086eb4247d847e4fd271167/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/20ff924afe87fcf47086eb4247d847e4fd271167/chrome/browser/metrics/chromeos_metrics_provider.cc
[modify] https://crrev.com/20ff924afe87fcf47086eb4247d847e4fd271167/chrome/browser/metrics/chromeos_metrics_provider.h
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/chrome/browser/metrics/leak_detector/OWNERS
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/chrome/browser/metrics/leak_detector/leak_detector_controller.cc
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/chrome/browser/metrics/leak_detector/leak_detector_controller.h
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/chrome/browser/metrics/leak_detector/leak_detector_controller_unittest.cc
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/chrome/browser/metrics/leak_detector/leak_detector_remote_controller.cc
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h
[modify] https://crrev.com/20ff924afe87fcf47086eb4247d847e4fd271167/chrome/common/chrome_features.cc
[modify] https://crrev.com/20ff924afe87fcf47086eb4247d847e4fd271167/chrome/common/chrome_features.h
[modify] https://crrev.com/20ff924afe87fcf47086eb4247d847e4fd271167/chrome/renderer/BUILD.gn
[modify] https://crrev.com/20ff924afe87fcf47086eb4247d847e4fd271167/chrome/renderer/DEPS
[modify] https://crrev.com/20ff924afe87fcf47086eb4247d847e4fd271167/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/20ff924afe87fcf47086eb4247d847e4fd271167/chrome/renderer/chrome_content_renderer_client.h
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/chrome/renderer/leak_detector/BUILD.gn
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/chrome/renderer/leak_detector/leak_detector_remote_client.cc
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/chrome/renderer/leak_detector/leak_detector_remote_client.h
[modify] https://crrev.com/20ff924afe87fcf47086eb4247d847e4fd271167/components/metrics/BUILD.gn
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/BUILD.gn
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/OWNERS
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/call_stack_manager.cc
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/call_stack_manager.h
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/call_stack_manager_unittest.cc
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/call_stack_table.cc
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/call_stack_table.h
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/call_stack_table_unittest.cc
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/custom_allocator.cc
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/custom_allocator.h
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/gnu_build_id_reader.cc
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/gnu_build_id_reader.h
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/leak_analyzer.cc
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/leak_analyzer.h
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/leak_analyzer_unittest.cc
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/leak_detector.cc
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/leak_detector.h
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/leak_detector.mojom
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/leak_detector_impl.cc
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/leak_detector_impl.h
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/leak_detector_impl_unittest.cc
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/leak_detector_unittest.cc
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/leak_detector_value_type.cc
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/leak_detector_value_type.h
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/protobuf_to_mojo_converter.cc
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/protobuf_to_mojo_converter.h
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/protobuf_to_mojo_converter_unittest.cc
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/ranked_set.cc
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/ranked_set.h
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/ranked_set_unittest.cc
[delete] https://crrev.com/603bd02f110d0d0ab325228b1a5d98cbc324b010/components/metrics/leak_detector/stl_allocator.h

Status: Fixed (was: Started)

Sign in to add a comment