Amend json_schema_compiler to use base::Optional on optional fields
Reported by
claudiom...@gmail.com,
Mar 6 2018
|
||
Issue descriptionCurrently, whenever an optional field is found in an idl (e.g. long? id) the resulting C++ code will use a std::unique_ptr<T>. This clearly results in a heap allocation. We should be using base::Optional for that. We also need to update the consumers of these values for the semantics of base::Optional.
,
Mar 7 2018
I have already started working on this bug.
,
Mar 21 2018
Mac triage: marking this bug as Available instead of Unconfirmed. I can't assign it to an @gmail.com address.
,
Mar 21 2018
That's alright ellyjones... I'm about to push this CL soon. |
||
►
Sign in to add a comment |
||
Comment 1 by rsesek@chromium.org
, Mar 7 2018Labels: -Type-Bug OS-Android OS-Chrome OS-Fuchsia OS-iOS OS-Linux OS-Windows Type-Task