New issue
Advanced search Search tips

Issue 819317 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[MD Extensions] "Repair" button in details view seems misaligned.

Project Member Reported by dpa...@chromium.org, Mar 6 2018

Issue description

See screenshots.
 
actual.png
20.6 KB View Download
expected.png
20.0 KB View Download
Also note that the code at [1] is using padding-left, padding-right, with different values, which most likely breaks in RTL mode. Should be switched to -webkit-padding-start, -webkit-padding-end instead.

https://cs.chromium.org/chromium/src/chrome/browser/resources/md_extensions/detail_view.html?l=114,115

Comment 2 by aee@chromium.org, Mar 7 2018

Owner: aee@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60aa5ce243f0a64869024b9e23428ddbf5c8c37b

commit 60aa5ce243f0a64869024b9e23428ddbf5c8c37b
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Thu Mar 08 03:37:59 2018

MD Extensions: fix repair button alignment and remove LTR-specific styles

Bug:  819317 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iee782ed92e4f3b5ec21239718b75f2d8f1a4188d
Reviewed-on: https://chromium-review.googlesource.com/953123
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541713}
[modify] https://crrev.com/60aa5ce243f0a64869024b9e23428ddbf5c8c37b/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/60aa5ce243f0a64869024b9e23428ddbf5c8c37b/chrome/test/data/webui/extensions/extension_detail_view_test.js

Comment 4 by aee@chromium.org, Mar 8 2018

Status: Fixed (was: Started)

Sign in to add a comment