Add tests for media engagement on Android |
||
Issue descriptionTwo solutions: - Android Integration Tests for real integration tests; - unit_tests, for basic tests. I would suggest the latter so we don't spend too much time writing tests to check that things aren't working. It might make sense to check two things via unit/browser tests: - Android has the feature disable by default; - When the feature is disabled, things do not work (that could be a browser test that would run on desktop but because of the first test, it would create some sort of guarantee).
,
Mar 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13cddd74becea16d82490606d03d9fc1358f6817 commit 13cddd74becea16d82490606d03d9fc1358f6817 Author: Becca Hughes <beccahughes@chromium.org> Date: Mon Mar 12 17:09:57 2018 Media Engagement: Add tests for media engagement on Android Adds two tests for MEI on Android. The first is a unit test that ensures that MEI flags are disabled on Android. The second modifies the browser tests to make sure that MEI has no effect on Android. BUG= 819315 Change-Id: I6577da1dcd4fb92cb8234289cd20c7393e19dae6 Reviewed-on: https://chromium-review.googlesource.com/957730 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#542519} [modify] https://crrev.com/13cddd74becea16d82490606d03d9fc1358f6817/chrome/browser/media/media_engagement_autoplay_browsertest.cc [modify] https://crrev.com/13cddd74becea16d82490606d03d9fc1358f6817/chrome/browser/media/media_engagement_service_unittest.cc
,
Mar 12 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by beccahughes@chromium.org
, Mar 12 2018