Extensions: Dev mode warning bubble pops up for incognito profiles (after dismissing for the original profile) |
||||
Issue descriptionWhat steps will reproduce the problem? 1. Load unpacked extensions (e.g. via chrome://extensions) on windows stable (or with the --enable-force-dev-mode-highlighting switch) 2. Restart chrome 3. Dismiss the warning bubble 4. Open an incognito window What is the expected result? We shouldn't warn the user again. What happens instead of that? We warn the user again. Please provide any additional information below. Attach a screenshot if possible. It looks like this regressed in revision 478a043aaa94cce0bebbded00aabeef45fd11d85, where we moved from storing the original profile to the raw profile - and I didn't catch it in the code review. :(
,
Mar 11 2018
Fixed with #1, and has baked for a few days. Requesting merge to m66.
,
Mar 12 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63fef0063949b6088fe5615ba3642ba549fa2db3 commit 63fef0063949b6088fe5615ba3642ba549fa2db3 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Mar 14 05:31:55 2018 [Extensions] Only show the dev mode bubble once per original profile We record profiles we show the dev mode bubble for in order to avoid showing it multiple times for the same profile. However, we need to ensure we track the original profile, so that we don't show it for an original profile and an incognito profile. Fix this, and add a unittest. TBR=rdevlin.cronin@chromium.org (cherry picked from commit 493cc87e378a341c2f1231e9323a81f46613ac83) Bug: 819309 Change-Id: Ibe33ea6f5587e85463a5a77023387e07b8fdf3ff Reviewed-on: https://chromium-review.googlesource.com/951971 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#541266} Reviewed-on: https://chromium-review.googlesource.com/961391 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#228} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/63fef0063949b6088fe5615ba3642ba549fa2db3/chrome/browser/extensions/dev_mode_bubble_delegate.cc [modify] https://crrev.com/63fef0063949b6088fe5615ba3642ba549fa2db3/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Mar 7 2018