New issue
Advanced search Search tips

Issue 819302 link

Starred by 1 user
Status: Fixed
Owner:
mef@chromium.org
Closed: Mar 2018
Cc:
pauljensen@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

[Cronet] UrlRequest.Callback.onResponseStarted has ResponseInfo.getReceivedByteCount set to 0

Project Member Reported by mef@chromium.org, Mar 6 2018 
ResponseInfo.getReceivedByteCount should account for number of bytes received through redirects and response headers received when response has started.

It is incorrectly set to 0 in callback to UrlRequest.Callback.onResponseStarted().

It is reported properly in following callbacks onReadCompleted / onSucceeded / onFailed.

This applies to Android Java and Native API.

Comment 1 by mef@chromium.org, Mar 9 2018

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6fdcf86e9459f84e6a17409ed48be9272af216f

commit f6fdcf86e9459f84e6a17409ed48be9272af216f
Author: Misha Efimov <mef@chromium.org>
Date: Mon Mar 12 14:50:23 2018

[Cronet] Improve received byte count in UrlRequest.Callback.onResponseStarted().

Bug:  819302 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I218c03a6a308afa265468876db28ff710a09399b
Reviewed-on: https://chromium-review.googlesource.com/957126
Commit-Queue: Misha Efimov <mef@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542481}
[modify] https://crrev.com/f6fdcf86e9459f84e6a17409ed48be9272af216f/components/cronet/android/cronet_url_request_adapter.cc
[modify] https://crrev.com/f6fdcf86e9459f84e6a17409ed48be9272af216f/components/cronet/android/cronet_url_request_adapter.h
[modify] https://crrev.com/f6fdcf86e9459f84e6a17409ed48be9272af216f/components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java
[modify] https://crrev.com/f6fdcf86e9459f84e6a17409ed48be9272af216f/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java
[modify] https://crrev.com/f6fdcf86e9459f84e6a17409ed48be9272af216f/components/cronet/android/java/src/org/chromium/net/impl/JavaUrlRequest.java
[modify] https://crrev.com/f6fdcf86e9459f84e6a17409ed48be9272af216f/components/cronet/android/java/src/org/chromium/net/impl/UrlResponseInfoImpl.java
[modify] https://crrev.com/f6fdcf86e9459f84e6a17409ed48be9272af216f/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java
[modify] https://crrev.com/f6fdcf86e9459f84e6a17409ed48be9272af216f/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
[modify] https://crrev.com/f6fdcf86e9459f84e6a17409ed48be9272af216f/components/cronet/android/test/javatests/src/org/chromium/net/UrlResponseInfoTest.java
[modify] https://crrev.com/f6fdcf86e9459f84e6a17409ed48be9272af216f/components/cronet/cronet_url_request.cc
[modify] https://crrev.com/f6fdcf86e9459f84e6a17409ed48be9272af216f/components/cronet/cronet_url_request.h
[modify] https://crrev.com/f6fdcf86e9459f84e6a17409ed48be9272af216f/components/cronet/native/url_request.cc

Comment 3 by mef@chromium.org, Mar 12 2018

Status: Fixed (was: Started)
►

Sign in to add a comment