New issue
Advanced search Search tips

Issue 819299 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

File app rename of files/folders on SD-cards not possible since last update

Reported by t.fruehb...@gmail.com, Mar 6 2018

Issue description

Chrome Version       : 64.0.3282.167
OS Version: 10176.72.0
URLs (if applicable) : n.a.
Other browsers tested: n.a.

What steps will reproduce the problem?
1. open File app
2. access file system on SD-card
3. open context menu of file/folder 

What is the expected result?
context menu item "Umbenennen" (rename) is active and click on it enables editing of file/folder name

What happens instead of that?
context menu item "Umbenennen" (rename) is greyed out, nothin happens on click

Please provide any additional information below. Attach a screenshot if
possible.
It is possible to rename the same files/folders in crosh/shell by mv command. 

UserAgentString: Mozilla/5.0 (X11; CrOS armv7l 10176.72.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.167 Safari/537.36



 
Screenshot 2018-03-06 at 19.47.05.png
27.7 KB View Download
Screenshot 2018-03-06 at 19.46.07.png
23.5 KB View Download
Components: Platform>Apps>FileManager
Status: WontFix (was: Unconfirmed)
I can see in the screenshots how Rename is disabled.  This seems strange.

I have just tried this and it works fine for me to rename folders and files via FileApp on versions:
64.0.3282.190 (Official Build) (64-bit)
67.0.3365.0 (Developer Build) (64-bit)

 t.fruehbeck@, is this reproducible even after rebooting, and on multiple SD cards?
Labels: Needs-Feedback
Status: Untriaged (was: WontFix)
Status: WontFix (was: Untriaged)

Comment 5 by sashab@chromium.org, Mar 12 2018

Status: Unconfirmed (was: WontFix)
Leaving as needs-feedback in case we can get more info and repro this.
 Issue 818799  has been merged into this issue.
The problem did _not_ exist before some weeks an update was installed.
The problem remains after several reboots.

I only have one SD-card available, so I can't tell if the problem is related to _this_ card. 
But: for a test I just pluggedin a USB-stick, and _the same problem_!! No option to rename _any_ files, but rename possible in crosh/shell!

Furthermore I am not the only one, see:
https://productforums.google.com/forum/?utm_medium=email&utm_source=footer#!msg/chromebook-central/ftpLY9QF3Jc/Nd1fV95LBQAJ

Comment 8 by sashab@chromium.org, Mar 12 2018

Labels: -Type-Bug Type-Bug-Regression
Thanks for reporting this. This seems like a regression.

Can you clarify which Chromebook you are using? And what SD card/USB stick you are using? Do you know what filesystem the USB is formatted with, e.g. FAT32?

We'll try reproduce this locally, and then we can investigate further.
Screenshot 2018-03-12 at 07.44.49.png
516 KB View Download
Project Member

Comment 10 by sheriffbot@chromium.org, Mar 12 2018

Cc: joelhockey@chromium.org
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Chromebook: Asus CB5-311 (my loved one :-)

OS: chronos@localhost ~ $ sudo uname -a
Linux localhost 3.10.18 #1 SMP Sat Feb 24 13:21:23 PST 2018 armv7l ARMv7 Processor rev 3 (v7l) NVIDIA Tegra SoC (Flattened Device Tree) GNU/Linux

chronos@localhost ~ $ sudo fdisk -l /dev/sda
Disk /dev/sda: 14.6 GiB, 15676211200 bytes, 30617600 sectors
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disklabel type: dos
Disk identifier: 0x1b681c50

USB-Stick:
Device     Boot   Start      End  Sectors  Size Id Type
/dev/sda1          4220    12031     7812  3.8M ef EFI (FAT-12/16/32)
/dev/sda2  *      12032  9062399  9050368  4.3G 17 Hidden HPFS/NTFS
/dev/sda3       9062400 30617599 21555200 10.3G  7 HPFS/NTFS/exFAT

SD-Card:
chronos@localhost ~ $ sudo fdisk -l /dev/mmcblk1p1 
Disk /dev/mmcblk1p1: 20 GiB, 21474836480 bytes, 41943040 sectors
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes

Hope that helps!
Sorry, it's ACER not Asus !

Comment 13 by sa...@chromium.org, Mar 13 2018

Labels: -Pri-3 CrOSFilesFeature-ExternalMedia Pri-1
Status: Untriaged (was: Unconfirmed)
Confirmed with a USB stick with 66.0.3350.3 dev channel and 67.0.3366.0 local build.

Comment 14 by sa...@chromium.org, Mar 13 2018

 Issue 820832  has been merged into this issue.
Multiple users are reporting this problem in CBC

https://productforums.google.com/forum/#!topic/chromebook-central/ftpLY9QF3Jc

#CBC-RS/TC-watchlist 
Labels: M-67
Owner: sashab@chromium.org
Status: Assigned (was: Untriaged)
Owner: sa...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 19 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9efa9ca0d7e325320a26c5d4138c0035b286a6cd

commit 9efa9ca0d7e325320a26c5d4138c0035b286a6cd
Author: Sam McNally <sammc@chromium.org>
Date: Thu Mar 15 03:45:20 2018

File manager: Don't apply filesystem whitelisting for file renames.

File manager whitelists the filesystem types supported for volume
renaming. However, this is incorrectly being applied for file and
directory renames.

Only apply the filesystem type whitelisting if the entry being
considered is a root filesystem entry.

Bug:  819299 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9d18238b1702150c2e3f4374ae2ab028c3eed622
Reviewed-on: https://chromium-review.googlesource.com/961983
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543300}
[modify] https://crrev.com/9efa9ca0d7e325320a26c5d4138c0035b286a6cd/ui/file_manager/file_manager/foreground/js/file_manager_commands.js

 Issue 806659  has been merged into this issue.

Comment 21 by sa...@chromium.org, Mar 15 2018

Status: Fixed (was: Started)

Comment 22 by sa...@chromium.org, May 16 2018

 Issue 840175  has been merged into this issue.

Comment 23 by dats@chromium.org, May 22 2018

 Issue 841973  has been merged into this issue.
Is there any view on a resolution ?
I would really like to see a resolution soon as I don't understand why I as admin on my chromebook, don't have all permissions needed to 'manipulate' files on the disks connected to the machine.
Much appreciate your support ! Thx !

Sign in to add a comment