New issue
Advanced search Search tips

Issue 819295 link

Starred by 2 users
Status: Fixed
Owner:
agl@chromium.org
Closed: Mar 2018
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Merge better Security Key icon for M66

Project Member Reported by agl@chromium.org, Mar 6 2018 
UI team have provided a better Security Key icon for M66. This bug tracks the merge of that to the M66 branch.


Release managers:

This involves merging the following change:

  https://chromium.googlesource.com/chromium/src.git/+/2a6dabd7fd299a282087a7354833e82512acf6a5

  commit 2a6dabd7fd299a282087a7354833e82512acf6a5
  Author: Adam Langley <agl@chromium.org>
  Date: Fri Mar 02 17:39:39 2018

  Update Security Key icon.

This change has been on master for a few days now. The risk is low: it's just changing an icon.
Project Member

Comment 1 by sheriffbot@chromium.org, Mar 7 2018

Labels: -Merge-Request-66 Merge-Approved-66 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 7 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44352a5dc55db7d8a17a9d06532829b2fa0e57c8

commit 44352a5dc55db7d8a17a9d06532829b2fa0e57c8
Author: Adam Langley <agl@chromium.org>
Date: Wed Mar 07 19:39:24 2018

Update Security Key icon.

Bug:  819295 
Change-Id: I0600ca9fc724813743672c83b27e9adf0dcb28a2
Reviewed-on: https://chromium-review.googlesource.com/946518
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/953362
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#70}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/44352a5dc55db7d8a17a9d06532829b2fa0e57c8/chrome/app/vector_icons/usb_security_key.icon
[modify] https://crrev.com/44352a5dc55db7d8a17a9d06532829b2fa0e57c8/chrome/browser/permissions/attestation_permission_request.cc

Comment 3 by agl@chromium.org, Mar 7 2018

Labels: -merge-merged-3359 Merge-Approved-66
Status: Fixed (was: Assigned)

Comment 4 by gov...@chromium.org, Mar 8 2018 

Seems like this is already merge to M66 at #2. If nothing is pending for M66, pls remove "Merge-Approved-66" label. Thank you.

Comment 5 by agl@chromium.org, Mar 8 2018

Labels: -Merge-Approved-66 Merge-Merged
►

Sign in to add a comment