New issue
Advanced search Search tips

Issue 819289 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove memory metrics from base::ProcessMetrics

Project Member Reported by erikc...@chromium.org, Mar 6 2018

Issue description

The memory metrics are inconsistent and poorly defined.

These functions are Windows-specific and don't mean anything on non-Windows platforms. Some of them are defined [with other meanings] on different platforms. Some of them just return 0. The problem is that consumers of these APIs have *expectations* about what these functions mean, and those expectations are almost always cross-platform.

The memory-infra service is the sole vendor of cross-platform-consistent memory metrics [in the form of "memory footprint"]. 

"""
 // Returns the current space allocated for the pagefile, in bytes (these pages
  // may or may not be in memory).  On Linux, this returns the total virtual
  // memory size.
  size_t GetPagefileUsage() const;
  // Returns the peak space allocated for the pagefile, in bytes.
  size_t GetPeakPagefileUsage() const;
  // Returns the current working set size, in bytes.  On Linux, this returns
  // the resident set size.
  size_t GetWorkingSetSize() const;
  // Returns the peak working set size, in bytes.
  size_t GetPeakWorkingSetSize() const;
  // Returns private and sharedusage, in bytes. Private bytes is the amount of
  // memory currently allocated to a process that cannot be shared. Returns
  // false on platform specific error conditions.  Note: |private_bytes|
  // returns 0 on unsupported OSes: prior to XP SP2.
  bool GetMemoryBytes(size_t* private_bytes, size_t* shared_bytes) const;
  // Fills a CommittedKBytes with both resident and paged
  // memory usage as per definition of CommittedBytes.
  void GetCommittedKBytes(CommittedKBytes* usage) const;
  // Fills a WorkingSetKBytes containing resident private and shared memory
  // usage in bytes, as per definition of WorkingSetBytes. Note that this
  // function is somewhat expensive on Windows (a few ms per process).
  bool GetWorkingSetKBytes(WorkingSetKBytes* ws_usage) const;
  // Computes pss (proportional set size) of a process. Note that this
  // function is somewhat expensive on Windows (a few ms per process).
  bool GetProportionalSetSizeBytes(uint64_t* pss_bytes) const;
"""
 
Cc: primiano@chromium.org dcheng@chromium.org ssid@chromium.org
Owner: erikc...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4828a3eedea81b4e45017388577bcedb4e6770bd

commit 4828a3eedea81b4e45017388577bcedb4e6770bd
Author: erikchen <erikchen@chromium.org>
Date: Wed Mar 07 16:38:23 2018

Remove base::ProcessMetrics::GetPagefileUsage().

The method is only well defined on Windows, but its presence in base/
makes it appear to be well defined on other platforms. There were only 2
consumers: A metrics reporting call in remoting/ and a debug log in
v8/.

This CL updates remoting/ to fetch the metric directly on Windows and
leave it empty on other platforms. This CL updates v8 to remove the
field from the debug log.

Bug:  819289 
Change-Id: Id44c2efd345318dce9734566b4696c947b0fd617
TBR: sky@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/951745
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541460}
[modify] https://crrev.com/4828a3eedea81b4e45017388577bcedb4e6770bd/base/process/process_metrics.h
[modify] https://crrev.com/4828a3eedea81b4e45017388577bcedb4e6770bd/base/process/process_metrics_freebsd.cc
[modify] https://crrev.com/4828a3eedea81b4e45017388577bcedb4e6770bd/base/process/process_metrics_fuchsia.cc
[modify] https://crrev.com/4828a3eedea81b4e45017388577bcedb4e6770bd/base/process/process_metrics_ios.cc
[modify] https://crrev.com/4828a3eedea81b4e45017388577bcedb4e6770bd/base/process/process_metrics_linux.cc
[modify] https://crrev.com/4828a3eedea81b4e45017388577bcedb4e6770bd/base/process/process_metrics_mac.cc
[modify] https://crrev.com/4828a3eedea81b4e45017388577bcedb4e6770bd/base/process/process_metrics_openbsd.cc
[modify] https://crrev.com/4828a3eedea81b4e45017388577bcedb4e6770bd/base/process/process_metrics_win.cc
[modify] https://crrev.com/4828a3eedea81b4e45017388577bcedb4e6770bd/chrome/test/base/chrome_process_util.cc
[modify] https://crrev.com/4828a3eedea81b4e45017388577bcedb4e6770bd/chrome/test/base/chrome_process_util.h
[modify] https://crrev.com/4828a3eedea81b4e45017388577bcedb4e6770bd/chrome/test/base/chrome_process_util_mac.cc
[modify] https://crrev.com/4828a3eedea81b4e45017388577bcedb4e6770bd/content/child/BUILD.gn
[modify] https://crrev.com/4828a3eedea81b4e45017388577bcedb4e6770bd/content/child/blink_platform_impl.cc
[modify] https://crrev.com/4828a3eedea81b4e45017388577bcedb4e6770bd/content/child/blink_platform_impl.h
[delete] https://crrev.com/c76d9a204c2ea122d3330c98481cbe77371802fd/content/child/content_child_helpers.cc
[delete] https://crrev.com/c76d9a204c2ea122d3330c98481cbe77371802fd/content/child/content_child_helpers.h
[modify] https://crrev.com/4828a3eedea81b4e45017388577bcedb4e6770bd/remoting/host/current_process_stats_agent.cc
[modify] https://crrev.com/4828a3eedea81b4e45017388577bcedb4e6770bd/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
[modify] https://crrev.com/4828a3eedea81b4e45017388577bcedb4e6770bd/third_party/WebKit/public/platform/Platform.h

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07e3ce4f1317aa9d669a06a64e428d8f8488228b

commit 07e3ce4f1317aa9d669a06a64e428d8f8488228b
Author: erikchen <erikchen@chromium.org>
Date: Wed Mar 07 16:45:09 2018

Remove GetPeakPagefileUsage and GetPeakWorkingSetSize from base::ProcessMetrics

The concepts are only well defined on Windows. The only consumers were in
chrome/installer [for courgette and Zucchini], which currently only target
Windows, so the call sites were updated to directly call the Windows APIs.

Bug:  819289 
Change-Id: Ic73d9944ed77276f0ca9fabf2bda62a7c34398b9
TBR: sky@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/951923
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541473}
[modify] https://crrev.com/07e3ce4f1317aa9d669a06a64e428d8f8488228b/base/process/process_metrics.h
[modify] https://crrev.com/07e3ce4f1317aa9d669a06a64e428d8f8488228b/base/process/process_metrics_freebsd.cc
[modify] https://crrev.com/07e3ce4f1317aa9d669a06a64e428d8f8488228b/base/process/process_metrics_fuchsia.cc
[modify] https://crrev.com/07e3ce4f1317aa9d669a06a64e428d8f8488228b/base/process/process_metrics_linux.cc
[modify] https://crrev.com/07e3ce4f1317aa9d669a06a64e428d8f8488228b/base/process/process_metrics_mac.cc
[modify] https://crrev.com/07e3ce4f1317aa9d669a06a64e428d8f8488228b/base/process/process_metrics_openbsd.cc
[modify] https://crrev.com/07e3ce4f1317aa9d669a06a64e428d8f8488228b/base/process/process_metrics_win.cc
[modify] https://crrev.com/07e3ce4f1317aa9d669a06a64e428d8f8488228b/chrome/installer/setup/setup_main.cc
[modify] https://crrev.com/07e3ce4f1317aa9d669a06a64e428d8f8488228b/chrome/installer/zucchini/main_utils.cc
[modify] https://crrev.com/07e3ce4f1317aa9d669a06a64e428d8f8488228b/chrome/test/base/chrome_process_util.cc
[modify] https://crrev.com/07e3ce4f1317aa9d669a06a64e428d8f8488228b/chrome/test/base/chrome_process_util.h

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65fc192779b75ce1ce1f2af0bf7376a39b6c4d81

commit 65fc192779b75ce1ce1f2af0bf7376a39b6c4d81
Author: erikchen <erikchen@chromium.org>
Date: Wed Mar 07 23:41:06 2018

Fix incorrect setter in current_process_stats_agent.cc.

In my recent change to this file:
https://chromium-review.googlesource.com/c/chromium/src/+/951745/5/remoting/host/current_process_stats_agent.cc#35,
I accidentally called the set_working_set_size setter with the PagefileUsage metric.

This CL fixes it to use the set_pagefile_size setter.

Bug:  819289 
Change-Id: I3670f955bb484c1eb27d067c72d17a4d745a2446
TBR: sergeyu@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/953764
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541642}
[modify] https://crrev.com/65fc192779b75ce1ce1f2af0bf7376a39b6c4d81/remoting/host/current_process_stats_agent.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d447bb62da40696c451bee2e491f5719a6a8acb7

commit d447bb62da40696c451bee2e491f5719a6a8acb7
Author: erikchen <erikchen@chromium.org>
Date: Thu Mar 08 22:06:24 2018

Remove ProcessMetrics::GetWorkingSetSize()

The concept of "working set" is specific to the Windows memory model.
  * Windows-only files were modified to directly invoke the Windows API.
  * os_metrics_linux.cc was modified to use RSS instead [which is what they really
  wanted].
  * Two iOS files were incorrectly using GetWorkingSetSize() to return a
  task's "resident_size" as a rough measurement for total memory usage. This is
  inaccurate, since it includes reusable memory [used extensively by libMalloc
  for freeing objects]. This CL changes those two files to directly invoke the
  relevant mach APIs, and to subtract out reusable memory.
  * Remoting was using GetWorkingSetSize on all platforms, but the concept is
  only well defined on Windows.
  * MemoryCoordinator was calling GetWorkingSetSize from dead code. The dead
  code was removed.

Bug:  819289 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I720e18ab483a9995982762cbd5ae1d045adfaa74
TBR: sky@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/953723
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541896}
[modify] https://crrev.com/d447bb62da40696c451bee2e491f5719a6a8acb7/base/BUILD.gn
[modify] https://crrev.com/d447bb62da40696c451bee2e491f5719a6a8acb7/base/process/process_metrics.h
[modify] https://crrev.com/d447bb62da40696c451bee2e491f5719a6a8acb7/base/process/process_metrics_freebsd.cc
[modify] https://crrev.com/d447bb62da40696c451bee2e491f5719a6a8acb7/base/process/process_metrics_fuchsia.cc
[modify] https://crrev.com/d447bb62da40696c451bee2e491f5719a6a8acb7/base/process/process_metrics_ios.cc
[modify] https://crrev.com/d447bb62da40696c451bee2e491f5719a6a8acb7/base/process/process_metrics_linux.cc
[modify] https://crrev.com/d447bb62da40696c451bee2e491f5719a6a8acb7/base/process/process_metrics_mac.cc
[modify] https://crrev.com/d447bb62da40696c451bee2e491f5719a6a8acb7/base/process/process_metrics_openbsd.cc
[delete] https://crrev.com/e1c1d3de40d7b19358b219bab7cec0042c3ed337/base/process/process_metrics_unittest_ios.cc
[modify] https://crrev.com/d447bb62da40696c451bee2e491f5719a6a8acb7/base/process/process_metrics_win.cc
[modify] https://crrev.com/d447bb62da40696c451bee2e491f5719a6a8acb7/chrome/browser/task_manager/sampling/task_group_sampler.cc
[modify] https://crrev.com/d447bb62da40696c451bee2e491f5719a6a8acb7/chrome/test/base/chrome_process_util.cc
[modify] https://crrev.com/d447bb62da40696c451bee2e491f5719a6a8acb7/chrome/test/base/chrome_process_util.h
[modify] https://crrev.com/d447bb62da40696c451bee2e491f5719a6a8acb7/chrome/test/base/chrome_process_util_mac.cc
[modify] https://crrev.com/d447bb62da40696c451bee2e491f5719a6a8acb7/content/browser/memory/memory_coordinator_impl.cc
[modify] https://crrev.com/d447bb62da40696c451bee2e491f5719a6a8acb7/content/browser/memory/memory_coordinator_impl.h
[modify] https://crrev.com/d447bb62da40696c451bee2e491f5719a6a8acb7/ios/chrome/browser/memory/memory_metrics.cc
[modify] https://crrev.com/d447bb62da40696c451bee2e491f5719a6a8acb7/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm
[modify] https://crrev.com/d447bb62da40696c451bee2e491f5719a6a8acb7/remoting/host/current_process_stats_agent.cc
[modify] https://crrev.com/d447bb62da40696c451bee2e491f5719a6a8acb7/services/resource_coordinator/public/cpp/memory_instrumentation/os_metrics_linux.cc
[modify] https://crrev.com/d447bb62da40696c451bee2e491f5719a6a8acb7/services/resource_coordinator/public/cpp/memory_instrumentation/os_metrics_win.cc
[modify] https://crrev.com/d447bb62da40696c451bee2e491f5719a6a8acb7/tools/metrics/histograms/histograms.xml

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e301d42408d42ad021a6e32f8ad547cd464d5d92

commit e301d42408d42ad021a6e32f8ad547cd464d5d92
Author: erikchen <erikchen@chromium.org>
Date: Fri Mar 09 19:28:48 2018

Update MemoryDetails to use memory_instrumentation.

memory_instrumentation is the source of truth for memory metrics. It provides
private_memory_footprint, a cross-platform consistent memory metric.

The previous implementation exposed working_set and committed - Windows specific
measurements, and phys_footprint - a macOS specific measurement.

This CL replaces those metrics with private_memory_footprint. The only place
these numbers are used is to generate a log string, used by the feedback system
and the OOM reporting system.

Change-Id: If39c626605f70e18e6044c7f1d2f0f1a8ce5562a
Bug:  819289 
Reviewed-on: https://chromium-review.googlesource.com/951754
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542196}
[modify] https://crrev.com/e301d42408d42ad021a6e32f8ad547cd464d5d92/chrome/browser/memory_details.cc
[modify] https://crrev.com/e301d42408d42ad021a6e32f8ad547cd464d5d92/chrome/browser/memory_details.h
[modify] https://crrev.com/e301d42408d42ad021a6e32f8ad547cd464d5d92/chrome/browser/memory_details_android.cc
[modify] https://crrev.com/e301d42408d42ad021a6e32f8ad547cd464d5d92/chrome/browser/memory_details_linux.cc
[modify] https://crrev.com/e301d42408d42ad021a6e32f8ad547cd464d5d92/chrome/browser/memory_details_mac.cc
[modify] https://crrev.com/e301d42408d42ad021a6e32f8ad547cd464d5d92/chrome/browser/memory_details_win.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce055512c7a4201f67d8d23c15ca5cefee4b7f0e

commit ce055512c7a4201f67d8d23c15ca5cefee4b7f0e
Author: erikchen <erikchen@chromium.org>
Date: Fri Mar 09 23:49:03 2018

Change name of method from GetRSS -> GetResidentSetSize.

Bug:  819289 
Change-Id: I029d5adfef0a650998778c1b56ea8782a66ff3e2
Reviewed-on: https://chromium-review.googlesource.com/956573
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542283}
[modify] https://crrev.com/ce055512c7a4201f67d8d23c15ca5cefee4b7f0e/base/process/process_metrics.h
[modify] https://crrev.com/ce055512c7a4201f67d8d23c15ca5cefee4b7f0e/base/process/process_metrics_linux.cc
[modify] https://crrev.com/ce055512c7a4201f67d8d23c15ca5cefee4b7f0e/services/resource_coordinator/public/cpp/memory_instrumentation/os_metrics_linux.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/278beeb67bc07ca7b39d25d0a61d896f0c0978cf

commit 278beeb67bc07ca7b39d25d0a61d896f0c0978cf
Author: erikchen <erikchen@chromium.org>
Date: Thu Mar 15 17:49:38 2018

Remove GetProportionalSetSize.

The concept is only well-defined on Linux, but the measurement was only
implemented and used on Windows.

Bug:  819289 
Change-Id: Ie69e550019e29b473c8efcae8f3c8bbc390e737b
Reviewed-on: https://chromium-review.googlesource.com/956575
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543435}
[modify] https://crrev.com/278beeb67bc07ca7b39d25d0a61d896f0c0978cf/base/process/process_metrics.h
[modify] https://crrev.com/278beeb67bc07ca7b39d25d0a61d896f0c0978cf/base/process/process_metrics_win.cc
[modify] https://crrev.com/278beeb67bc07ca7b39d25d0a61d896f0c0978cf/services/resource_coordinator/public/cpp/memory_instrumentation/os_metrics_win.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00e7992e02708ec89820674bc69d2ac7fa01fc0b

commit 00e7992e02708ec89820674bc69d2ac7fa01fc0b
Author: erikchen <erikchen@chromium.org>
Date: Fri Mar 16 20:52:57 2018

Convert PrerenderContents to use memory_instrumentation.

PrerenderContents are destroyed when they use too much memory. They were
previously using base::ProcessMetrics, which returns inconsistent
results across OSes. This CL changes it to use memory_instrumentation,
which returns consistent metrics across all OSes.

Bug:  819289 
Change-Id: I1b459c2b8838c5ed69c07bf37182ca4e164d7fc3
Reviewed-on: https://chromium-review.googlesource.com/966598
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543825}
[modify] https://crrev.com/00e7992e02708ec89820674bc69d2ac7fa01fc0b/chrome/browser/prerender/prerender_contents.cc
[modify] https://crrev.com/00e7992e02708ec89820674bc69d2ac7fa01fc0b/chrome/browser/prerender/prerender_contents.h

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19ad19ef88be6c5df0d8092adf6526d9e03c1b46

commit 19ad19ef88be6c5df0d8092adf6526d9e03c1b46
Author: erikchen <erikchen@chromium.org>
Date: Tue Mar 20 18:47:58 2018

Remove ProcessMetrics::GetMemoryBytes.

There were only 2 callers of the method.
  * One caller was for additional debugging for OOMs in the bitmap manager on
  Windows. This was added in 2014 (https://codereview.chromium.org/822433003)
  for a bug marked as WontFix in 2015
  (https://bugs.chromium.org/p/chromium/issues/detail?id=429763).
  * The other caller was for Windows specific code that was already making the
  relevant syscall immediately afterwards.

There was a unit test using this method to test locked memory calculations on
macOS. This was added in https://codereview.chromium.org/2782503002/, and is no
longer necessary, as locked memory is no longer used/exposed anywhere.

Bug:  819289 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I1c6f006b77edee69305cf13dcf5a414aa5028272
Reviewed-on: https://chromium-review.googlesource.com/969089
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544451}
[modify] https://crrev.com/19ad19ef88be6c5df0d8092adf6526d9e03c1b46/base/process/process_metrics.h
[modify] https://crrev.com/19ad19ef88be6c5df0d8092adf6526d9e03c1b46/base/process/process_metrics_freebsd.cc
[modify] https://crrev.com/19ad19ef88be6c5df0d8092adf6526d9e03c1b46/base/process/process_metrics_linux.cc
[modify] https://crrev.com/19ad19ef88be6c5df0d8092adf6526d9e03c1b46/base/process/process_metrics_mac.cc
[modify] https://crrev.com/19ad19ef88be6c5df0d8092adf6526d9e03c1b46/base/process/process_metrics_openbsd.cc
[modify] https://crrev.com/19ad19ef88be6c5df0d8092adf6526d9e03c1b46/base/process/process_metrics_unittest.cc
[modify] https://crrev.com/19ad19ef88be6c5df0d8092adf6526d9e03c1b46/base/process/process_metrics_win.cc
[modify] https://crrev.com/19ad19ef88be6c5df0d8092adf6526d9e03c1b46/components/viz/common/resources/bitmap_allocation.cc
[modify] https://crrev.com/19ad19ef88be6c5df0d8092adf6526d9e03c1b46/services/resource_coordinator/public/cpp/memory_instrumentation/os_metrics_win.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52b7b6b65c81f214f3dfe0324d33e02281e7bced

commit 52b7b6b65c81f214f3dfe0324d33e02281e7bced
Author: erikchen <erikchen@chromium.org>
Date: Fri Mar 23 21:58:50 2018

Remove GetCommittedKBytes and GetWorkingSetKBytes.

There are no longer any cross-platform consumers of this code. There are two
ChromeOS consumers of the latter, which have been extracted into a function only
defined on ChromeOS.

Bug:  819289 
Change-Id: Iaa0c12c94619ba54be44e23eb45abc5337da4621
Reviewed-on: https://chromium-review.googlesource.com/973943
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545578}
[modify] https://crrev.com/52b7b6b65c81f214f3dfe0324d33e02281e7bced/base/process/process_metrics.h
[modify] https://crrev.com/52b7b6b65c81f214f3dfe0324d33e02281e7bced/base/process/process_metrics_freebsd.cc
[modify] https://crrev.com/52b7b6b65c81f214f3dfe0324d33e02281e7bced/base/process/process_metrics_fuchsia.cc
[modify] https://crrev.com/52b7b6b65c81f214f3dfe0324d33e02281e7bced/base/process/process_metrics_linux.cc
[modify] https://crrev.com/52b7b6b65c81f214f3dfe0324d33e02281e7bced/base/process/process_metrics_mac.cc
[modify] https://crrev.com/52b7b6b65c81f214f3dfe0324d33e02281e7bced/base/process/process_metrics_openbsd.cc
[modify] https://crrev.com/52b7b6b65c81f214f3dfe0324d33e02281e7bced/base/process/process_metrics_win.cc
[modify] https://crrev.com/52b7b6b65c81f214f3dfe0324d33e02281e7bced/chrome/browser/resource_coordinator/tab_manager_delegate_chromeos.cc
[modify] https://crrev.com/52b7b6b65c81f214f3dfe0324d33e02281e7bced/chrome/browser/task_manager/sampling/task_group_sampler.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aae96729ccfec1015a4ea6d3c472761328b35f01

commit aae96729ccfec1015a4ea6d3c472761328b35f01
Author: Mostyn Bramley-Moore <mostynb@vewd.com>
Date: Sat Mar 24 13:38:48 2018

[jumbo] last_system_time_ is only used on mac + win

Avoid "error: private field 'last_system_time_' is not used" warnings
which are promoted to errors.  This was somehow triggered by this CL:
https://chromium-review.googlesource.com/973943
(But I'm not sure how- the CL did not remove any direct uses of that
variable.)

Speculative fix applied to the openbsd and freebsd implementations.

TBR=dcheng@chromium.org

Bug:  819289 
Change-Id: I862d9c22a8e181ac5dd3f1a644432e5570419a0b
Reviewed-on: https://chromium-review.googlesource.com/979432
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mostyn Bramley-Moore <mostynb@vewd.com>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#545689}
[modify] https://crrev.com/aae96729ccfec1015a4ea6d3c472761328b35f01/base/process/process_metrics.h
[modify] https://crrev.com/aae96729ccfec1015a4ea6d3c472761328b35f01/base/process/process_metrics_freebsd.cc
[modify] https://crrev.com/aae96729ccfec1015a4ea6d3c472761328b35f01/base/process/process_metrics_linux.cc
[modify] https://crrev.com/aae96729ccfec1015a4ea6d3c472761328b35f01/base/process/process_metrics_openbsd.cc

Status: Fixed (was: Assigned)

Sign in to add a comment