Issue 819288 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	mthiesse@chromium.org
Closed:	Mar 2018
Components:	Internals>XR
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug
Proj-VR Test-Complete XR-Caught-By-Test
Proj-XR

Exiting WebVR presentation too quickly causes browser controls to get stuck

Project Member Reported by bsheedy@chromium.org, Mar 6 2018

Issue description

If WebVR presentation is entered and immediately exited, it causes the browser controls to get stuck if they weren't yet fully hidden. This is easily worked around by waiting until the controls are fully hidden before exiting VR, but ideally the controls will properly handle requests to be shown while still in the process of hiding.

This was the root cause of Issue 812028.

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddf80c8ed8ad67ad28fed2134af2694b4b579e76

commit ddf80c8ed8ad67ad28fed2134af2694b4b579e76
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Wed Mar 07 05:36:03 2018

VR: Fix Controls not showing if VR is immediately exited.

If VR was immediately exited after entering VR, sometimes the control
container wasn't shown. This seems to be because the constraints were
set to 'both', which sometimes lead to them staying hidden even though
we asked to show them. Setting the constraints to 'shown' fixes this,
really not sure why.

This also fixes a race on setting the present request result, where
if we exit VR before VR Shell is initialized, we fail to respond to the
present request.

Bug: 812028,  819288 
Change-Id: Ie12125126b7f948cc712855dabd1c50b8ad5dc44
Reviewed-on: https://chromium-review.googlesource.com/951926
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541361}
[modify] https://crrev.com/ddf80c8ed8ad67ad28fed2134af2694b4b579e76/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/ddf80c8ed8ad67ad28fed2134af2694b4b579e76/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/ddf80c8ed8ad67ad28fed2134af2694b4b579e76/chrome/browser/android/vr/vr_shell_delegate.cc