New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 819284 link

Starred by 1 user
Status: Verified
Owner:
lijeffrey@chromium.org
Closed: Apr 2018
Cc:
█ shenghua...@chromium.org
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 805475
issue 817468



Sign in to add a comment

[Findit] Flake Analyzer - New RunFlakeSwarmingTaskPipeline

Project Member Reported by lijeffrey@chromium.org, Mar 6 2018 
With the new asynchronous pipeline in place for triggering/waiting for results in place, RunFlakeSwarmingTask can be made to inherit from that parent class.

The new pipeline should accept bot dimensions as input for triggering the tasks, and refer to the "latest" build (the build that flakiness was detected in)'s dimensions for each task when looking back per recommendation in  issue 817468

Comment 1 by st...@chromium.org, Mar 6 2018

Cc: shenghua...@chromium.org
+shenghuazhang

Once this bug is fixed and Findit switches fully to the new analysis pipeline, Mac 10.9 is not needed anymore.

Comment 2 by shenghua...@chromium.org, Mar 6 2018

Blocking: 817468

Comment 3 by shenghua...@chromium.org, Mar 8 2018

Blocking: 805475
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b829553125a6e0f867ec5f997c674e7cfb79cf10

commit b829553125a6e0f867ec5f997c674e7cfb79cf10
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Thu Apr 05 07:13:58 2018

[Findit] Flake Analyzer - Asynchronous RunFlakeSwarmingTaskPipeline

1. Change RunFlakeSwarmingTaskPipeline from Generator to Asynchronous
2. Get rid of calls to old pipelines and replace with asynchronous
3. Introduce flake_swarming.py which handles all swarming task requests
   and operations

Bug:  828624 ,  819284 
Change-Id: Ia0f9422e85f47b9865b59af1f023d737be2bf447
Reviewed-on: https://chromium-review.googlesource.com/994238
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/b829553125a6e0f867ec5f997c674e7cfb79cf10/appengine/findit/dto/flake_swarming_task_output.py
[modify] https://crrev.com/b829553125a6e0f867ec5f997c674e7cfb79cf10/appengine/findit/dto/test/flake_swarming_task_output_test.py
[modify] https://crrev.com/b829553125a6e0f867ec5f997c674e7cfb79cf10/appengine/findit/pipelines/flake_failure/test/update_flake_analysis_data_points_pipeline_test.py
[modify] https://crrev.com/b829553125a6e0f867ec5f997c674e7cfb79cf10/appengine/findit/pipelines/flake_failure/run_flake_swarming_task_pipeline.py
[modify] https://crrev.com/b829553125a6e0f867ec5f997c674e7cfb79cf10/appengine/findit/services/flake_failure/test/flake_analysis_util_test.py
[modify] https://crrev.com/b829553125a6e0f867ec5f997c674e7cfb79cf10/appengine/findit/services/flake_failure/data_point_util.py
[modify] https://crrev.com/b829553125a6e0f867ec5f997c674e7cfb79cf10/appengine/findit/services/flake_failure/test/pass_rate_util_test.py
[modify] https://crrev.com/b829553125a6e0f867ec5f997c674e7cfb79cf10/appengine/findit/services/flake_failure/test/data_point_util_test.py
[add] https://crrev.com/b829553125a6e0f867ec5f997c674e7cfb79cf10/appengine/findit/services/flake_failure/test/flake_swarming_test.py
[modify] https://crrev.com/b829553125a6e0f867ec5f997c674e7cfb79cf10/appengine/findit/pipelines/flake_failure/test/determine_approximate_pass_rate_pipeline_test.py
[modify] https://crrev.com/b829553125a6e0f867ec5f997c674e7cfb79cf10/appengine/findit/pipelines/flake_failure/test/run_flake_swarming_task_pipeline_test.py
[modify] https://crrev.com/b829553125a6e0f867ec5f997c674e7cfb79cf10/appengine/findit/services/test_results.py
[modify] https://crrev.com/b829553125a6e0f867ec5f997c674e7cfb79cf10/appengine/findit/services/flake_failure/flake_analysis_util.py
[add] https://crrev.com/b829553125a6e0f867ec5f997c674e7cfb79cf10/appengine/findit/services/flake_failure/flake_swarming.py

Comment 5 by lijeffrey@chromium.org, Apr 23 2018

Status: Verified (was: Assigned)
►

Sign in to add a comment