Chrome building Get-Printer-Attributes requests with double forward slash |
|||||||||||
Issue descriptionWhen querying for printer attributes to check autoconf status, requesting urls with multiple backslashes. E.g. ipp://192.168.1.165//printers/foo Observed on: Chrome 66.0.3356.0
,
Mar 13 2018
,
Mar 13 2018
,
Mar 13 2018
,
Mar 13 2018
Fixing summary: - backslash -> forward slash
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7083daf25aad0704113cfc0c9af026c54577877 commit c7083daf25aad0704113cfc0c9af026c54577877 Author: Sean Kau <skau@chromium.org> Date: Thu Mar 15 19:08:43 2018 Fix url building for printer attribute queries. We're building urls to make printer attribute requests to printers directly to check for autoconf support and connectivity. Ensure that there is only one '/' between the authority and queue. Bug: 819280 Change-Id: I0be201f46b344b807e121326f9bbf1d86565de32 Reviewed-on: https://chromium-review.googlesource.com/960939 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#543465} [modify] https://crrev.com/c7083daf25aad0704113cfc0c9af026c54577877/printing/backend/cups_jobs.cc
,
Mar 15 2018
,
Mar 15 2018
,
Mar 16 2018
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 19 2018
,
Mar 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9af231f2ef09d887219901149674be5bc0aa5c38 commit 9af231f2ef09d887219901149674be5bc0aa5c38 Author: Sean Kau <skau@chromium.org> Date: Tue Mar 20 00:41:11 2018 Fix url building for printer attribute queries. We're building urls to make printer attribute requests to printers directly to check for autoconf support and connectivity. Ensure that there is only one '/' between the authority and queue. TBR=skau@chromium.org (cherry picked from commit c7083daf25aad0704113cfc0c9af026c54577877) Bug: 819280 Change-Id: I0be201f46b344b807e121326f9bbf1d86565de32 Reviewed-on: https://chromium-review.googlesource.com/960939 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#543465} Reviewed-on: https://chromium-review.googlesource.com/969836 Reviewed-by: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#332} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/9af231f2ef09d887219901149674be5bc0aa5c38/printing/backend/cups_jobs.cc
,
Mar 20 2018
To verify, attempt to setup a connection to a CUPS print server which will reject the double-slash uri.
,
Mar 20 2018
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by skau@chromium.org
, Mar 13 2018