Issue 820628  has been merged into this issue.

Min, do you think you'll have a chance to add this before the M67 branch on Friday? I'd like us to have some time to experiment with this so we can consider turning it on for eve, because I'm concerned about regressing the UX there otherwise. If you're busy with other things, I can look into adding it this week -- let me know.

yeah, I am the shadow gardener this week, and I am currently investigating about the cros config of the unibuild devices. Sorry I guess I may don't have time to add the flag this week.

Thanks, I'll take a look.

Sent https://crrev.com/c/981607 for review.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ef89ee744646b7d66922db1dca291963ebf0608

commit 9ef89ee744646b7d66922db1dca291963ebf0608
Author: Daniel Erat <derat@chromium.org>
Date: Tue Mar 27 03:46:46 2018

ash: Add feature for mode-specific power button behavior.

Add a new off-by-default feature that makes the power button
behave slightly differently depending on whether the device
is in tablet mode or laptop mode. Specifically, tapping the
power button turns the display off in tablet mode but does
nothing in laptop mode. Previously, tapping the button
turned the display off on most convertible devices
regardless of their mode.

Bug:  819276 
Change-Id: Iecd2e7aea74132018c3d88c88199e8d733c24fd2
Reviewed-on: https://chromium-review.googlesource.com/981607
Commit-Queue: Dan Erat <derat@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Reviewed-by: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546000}
[modify] https://crrev.com/9ef89ee744646b7d66922db1dca291963ebf0608/ash/public/cpp/ash_features.cc
[modify] https://crrev.com/9ef89ee744646b7d66922db1dca291963ebf0608/ash/public/cpp/ash_features.h
[modify] https://crrev.com/9ef89ee744646b7d66922db1dca291963ebf0608/ash/system/power/power_button_controller.cc
[modify] https://crrev.com/9ef89ee744646b7d66922db1dca291963ebf0608/ash/system/power/power_button_controller.h
[modify] https://crrev.com/9ef89ee744646b7d66922db1dca291963ebf0608/ash/system/power/power_button_controller_test_api.cc
[modify] https://crrev.com/9ef89ee744646b7d66922db1dca291963ebf0608/ash/system/power/power_button_controller_test_api.h
[modify] https://crrev.com/9ef89ee744646b7d66922db1dca291963ebf0608/ash/system/power/power_button_controller_unittest.cc
[modify] https://crrev.com/9ef89ee744646b7d66922db1dca291963ebf0608/ash/system/power/power_button_test_base.cc
[modify] https://crrev.com/9ef89ee744646b7d66922db1dca291963ebf0608/ash/system/power/power_button_test_base.h
[modify] https://crrev.com/9ef89ee744646b7d66922db1dca291963ebf0608/chrome/browser/about_flags.cc
[modify] https://crrev.com/9ef89ee744646b7d66922db1dca291963ebf0608/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/9ef89ee744646b7d66922db1dca291963ebf0608/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/9ef89ee744646b7d66922db1dca291963ebf0608/tools/metrics/histograms/enums.xml

I've gotten the go-ahead from UI review to turn this on.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd33ca87c35e2ee3cdf19629fbd1ee38c2958520

commit fd33ca87c35e2ee3cdf19629fbd1ee38c2958520
Author: Daniel Erat <derat@chromium.org>
Date: Tue Apr 17 19:18:44 2018

chromeos: Enable mode-specific power button behavior.

Enable mode-specific power button behavior by default. In
short, tapping the power button turns the display off on
devices that are in tablet mode but is ignored on devices
that are in laptop mode.

Bug:  819276 ,  783164 
Change-Id: Ic658e034366a32066940c647a73b8c61ecec2840
Reviewed-on: https://chromium-review.googlesource.com/1014486
Commit-Queue: Dan Erat <derat@chromium.org>
Reviewed-by: Min Chen <minch@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#551427}
[modify] https://crrev.com/fd33ca87c35e2ee3cdf19629fbd1ee38c2958520/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/fd33ca87c35e2ee3cdf19629fbd1ee38c2958520/ash/lock_screen_action/lock_screen_note_display_state_handler_unittest.cc
[modify] https://crrev.com/fd33ca87c35e2ee3cdf19629fbd1ee38c2958520/ash/public/cpp/ash_features.cc
[modify] https://crrev.com/fd33ca87c35e2ee3cdf19629fbd1ee38c2958520/ash/system/power/power_button_controller_unittest.cc

(The merge request is just for the flag flip and unit test updates in #8.)

Sounds like this was fully tested in experiment and verified good to go by switching as default behavior?

Yes, this has been verified first while it was behind a flag and now on ToT.

Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c4acd68284aaedac09e49df38abec5e644c0f96

commit 9c4acd68284aaedac09e49df38abec5e644c0f96
Author: Daniel Erat <derat@chromium.org>
Date: Wed Apr 18 20:15:29 2018

chromeos: Enable mode-specific power button behavior.

Enable mode-specific power button behavior by default. In
short, tapping the power button turns the display off on
devices that are in tablet mode but is ignored on devices
that are in laptop mode.

Bug:  819276 ,  783164 
Change-Id: Ic658e034366a32066940c647a73b8c61ecec2840
Reviewed-on: https://chromium-review.googlesource.com/1014486
Commit-Queue: Dan Erat <derat@chromium.org>
Reviewed-by: Min Chen <minch@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#551427}(cherry picked from commit fd33ca87c35e2ee3cdf19629fbd1ee38c2958520)
Reviewed-on: https://chromium-review.googlesource.com/1017662
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#98}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/9c4acd68284aaedac09e49df38abec5e644c0f96/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/9c4acd68284aaedac09e49df38abec5e644c0f96/ash/lock_screen_action/lock_screen_note_display_state_handler_unittest.cc
[modify] https://crrev.com/9c4acd68284aaedac09e49df38abec5e644c0f96/ash/public/cpp/ash_features.cc
[modify] https://crrev.com/9c4acd68284aaedac09e49df38abec5e644c0f96/ash/system/power/power_button_controller_unittest.cc

Thanks!

 Issue 783164  has been merged into this issue.