New issue
Advanced search Search tips

Issue 819268 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 819265

Blocking:
issue 634341



Sign in to add a comment

tpm: fix shutdown handling for tpm 1.2 chips

Project Member Reported by apronin@chromium.org, Mar 6 2018

Issue description

During system shutdown, TPM driver should send a Shutdown command to the chip and make sure there're no further commands sent after that (that also ensure that no command is in transition during reset).

In Chrome OS kernels prior to 4.14, it was achieved by a special 'gentle shutdown' patch.

For 4.14, a fix for that is made upstream for TPM 2.0 chips through the newly added mechanism of class shutdown handler for tpm drivers. However, TPM 1.2 chips are still not covered by that. Part of the reason is that there's a potential race condition for tpm sysfs entries: don't hold proper locks for all paths, which can lead to null-deref after the shutdown handler. Upstream TPM 2.0 doesn't have sysfs entries by design, but TPM 1.2 does. See also issue 819265.

Need to fix sysfs and shutdown handling (use the new class shutdown) for TPM 1.2 in 4.14+ kernels.
 
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Blocking: 634341
Blockedon: 819265
Components: OS>Kernel>TPM

Sign in to add a comment