New issue
Advanced search Search tips

Issue 819265 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 819268



Sign in to add a comment

tpm: fix sysfs locking for tpm 2.0 in kernel 4.14+

Project Member Reported by apronin@chromium.org, Mar 6 2018

Issue description

Starting with 4.14, ChromeOS uses the tpm driver fix from upstream for handling system shutdown. It registers a class shutdown handler that for TPM 2.0 sends the Shutdown command and set ops for the chip to null to prevent further commands. However, tpm sysfs code doesn't always properly acquire chip ops locks, which could lead to null-ifying the ops while the sysfs code accesses it.

This is not an issue for upstream code, which doesn't register any sysfs attributes for TPM 2.0. However, Chrome OS does have syfs entries in 2.0 case.

Need to fix sysfs locking to prevent races during shutdown. 
 
Needs to be done in conjunction with issue 819268 for the patches to be accepted upstream. Otherwise, there is no reason to fix sysfs there, and previouly submitted patches were rejected.

Comment 2 Deleted

Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Blocking: 819268
Components: OS>Kernel>TPM

Sign in to add a comment