Run interactive_ui_tests with network service on bots and pass all tests |
||||
Issue descriptionhopefully no surprises in this target
,
Mar 7 2018
,
Mar 15 2018
I am looking at the failures.
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc463e66ac97e4385733d172405794bd0f1095d6 commit cc463e66ac97e4385733d172405794bd0f1095d6 Author: Jay Civelli <jcivelli@google.com> Date: Fri Mar 16 04:26:30 2018 Fix the PasswordGenerationInteractiveTest interactive ui tests Fixes the PasswordGenerationInteractiveTest interactive ui tests with the network service. The tests were not initializing the command line properly. Bug: 819249 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I8321d85caf67d2b762e827881c16f8c4d52ff551 Reviewed-on: https://chromium-review.googlesource.com/964908 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#543625} [modify] https://crrev.com/cc463e66ac97e4385733d172405794bd0f1095d6/chrome/browser/password_manager/password_generation_interactive_uitest.cc [modify] https://crrev.com/cc463e66ac97e4385733d172405794bd0f1095d6/testing/buildbot/filters/mojo.fyi.network_interactive_ui_tests.filter
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1385637859567aa79a5989e9f5415845e4e90048 commit 1385637859567aa79a5989e9f5415845e4e90048 Author: Jay Civelli <jcivelli@google.com> Date: Fri Mar 16 05:23:40 2018 Reenable some interactive ui tests that seem to work Bug: 819249 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id6aa2933360c9b74cf51d575a72f63b29daf7846 Reviewed-on: https://chromium-review.googlesource.com/964913 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#543631} [modify] https://crrev.com/1385637859567aa79a5989e9f5415845e4e90048/testing/buildbot/filters/mojo.fyi.network_interactive_ui_tests.filter
,
Mar 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9bbf72d43272b54f1cd76538c97e5ba7f994dfd commit c9bbf72d43272b54f1cd76538c97e5ba7f994dfd Author: Jay Civelli <jcivelli@google.com> Date: Sat Mar 24 01:58:31 2018 Fix local NTP tests with the network service Fixes several local NTP tests with the network service by registering the chrome-search scheme with the appropriate URLDataLoader. That fixes the last interactive UI test failure and the associated filter file is removed. Bug: 819249 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ie7b01dc92cd74238d941bc358ed287d860831c97 Reviewed-on: https://chromium-review.googlesource.com/978847 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#545661} [modify] https://crrev.com/c9bbf72d43272b54f1cd76538c97e5ba7f994dfd/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/c9bbf72d43272b54f1cd76538c97e5ba7f994dfd/content/browser/webui/web_ui_url_loader_factory.cc [modify] https://crrev.com/c9bbf72d43272b54f1cd76538c97e5ba7f994dfd/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/c9bbf72d43272b54f1cd76538c97e5ba7f994dfd/testing/buildbot/chromium.linux.json [modify] https://crrev.com/c9bbf72d43272b54f1cd76538c97e5ba7f994dfd/testing/buildbot/filters/BUILD.gn [modify] https://crrev.com/c9bbf72d43272b54f1cd76538c97e5ba7f994dfd/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter [delete] https://crrev.com/2450ba2bb259ddb17932b2384c0978baeb1e14f6/testing/buildbot/filters/mojo.fyi.network_interactive_ui_tests.filter [modify] https://crrev.com/c9bbf72d43272b54f1cd76538c97e5ba7f994dfd/testing/buildbot/test_suites.pyl
,
Mar 24 2018
,
Jul 19
The following revision refers to this bug: https://chromium.googlesource.com/webm/libvpx/+/bc30e6e39c8bde9a31e1c314e6d1003ff47f2f7f commit bc30e6e39c8bde9a31e1c314e6d1003ff47f2f7f Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Date: Tue Jul 17 03:52:11 2018 vpx_sum_squares_2d_i16_neon(): Make |s2| a uint64x1_t. This fixes the build with at least GCC 7.3, where it was previously failing with: sum_squares_neon.c: In function 'vpx_sum_squares_2d_i16_neon': sum_squares_neon.c: note: use -flax-vector-conversions to permit conversions between vectors with differing element types or numbers of subparts s2 = vpaddl_u32(s1); ^~ sum_squares_neon.c: incompatible types when assigning to type 'int64x1_t' from type 'uint64x1_t' s2 = vpaddl_u32(s1); ^ sum_squares_neon.c: incompatible types when assigning to type 'int64x1_t' from type 'uint64x1_t' s2 = vadd_u64(vget_low_u64(s1), vget_high_u64(s1)); ^ sum_squares_neon.c: incompatible type for argument 1 of 'vget_lane_u64' return vget_lane_u64(s2, 0); ^~ The generated assembly was verified to remain identical with both GCC and LLVM. Bug: chromium:819249 Change-Id: I2778428ee1fee0a674d0d4910347c2a717de21ac [modify] https://crrev.com/bc30e6e39c8bde9a31e1c314e6d1003ff47f2f7f/vpx_dsp/arm/sum_squares_neon.c |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Mar 7 2018