New issue
Advanced search Search tips

Issue 819248 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 769401



Sign in to add a comment

Run extensions_browsertests with network service on bots and pass all tests

Project Member Reported by jam@chromium.org, Mar 6 2018

Issue description

Assigning to Ken as preliminary owner

 

Comment 1 by jam@chromium.org, Mar 6 2018

Owner: jam@chromium.org
Status: Started (was: Assigned)
looks like this is no work, so i will do it :)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9350d9dc037bfed22f896f8b324e589f7df0f895

commit 9350d9dc037bfed22f896f8b324e589f7df0f895
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Mar 06 23:49:23 2018

Run extensions_browsertests with network service along with the other network_service gtests.

There is one test failing which is because we don't handle external protocols with the network service.

Bug:  819248 , 706030 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I3ff98b61b2fa19fa3bfd54373cd920d4777f04c9
Reviewed-on: https://chromium-review.googlesource.com/951883
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541246}
[modify] https://crrev.com/9350d9dc037bfed22f896f8b324e589f7df0f895/extensions/BUILD.gn
[modify] https://crrev.com/9350d9dc037bfed22f896f8b324e589f7df0f895/extensions/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/9350d9dc037bfed22f896f8b324e589f7df0f895/extensions/shell/browser/shell_content_browser_client.h
[modify] https://crrev.com/9350d9dc037bfed22f896f8b324e589f7df0f895/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/9350d9dc037bfed22f896f8b324e589f7df0f895/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/9350d9dc037bfed22f896f8b324e589f7df0f895/testing/buildbot/filters/BUILD.gn
[modify] https://crrev.com/9350d9dc037bfed22f896f8b324e589f7df0f895/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[add] https://crrev.com/9350d9dc037bfed22f896f8b324e589f7df0f895/testing/buildbot/filters/mojo.fyi.network_extensions_browsertests.filter
[modify] https://crrev.com/9350d9dc037bfed22f896f8b324e589f7df0f895/testing/buildbot/test_suites.pyl

Comment 3 by jam@chromium.org, Mar 7 2018

Status: Fixed (was: Started)

Sign in to add a comment