New issue
Advanced search Search tips

Issue 819245 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 5
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Add test for CPU vulnerabilities reported by the kernel

Project Member Reported by jorgelo@chromium.org, Mar 6 2018

Issue description

As per title.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/283ab94ae9c4611c74bd09787ee5140567f97b5b

commit 283ab94ae9c4611c74bd09787ee5140567f97b5b
Author: Jorge Lucangeli Obes <jorgelo@chromium.org>
Date: Thu Mar 08 03:47:00 2018

security_CpuVulnerabilities: Add test.

The kernel provides info about CPU vulnerabilities in
/sys/devices/system/cpu/vulnerabilities, so check that to prevent
regressions.

Eventually the values might change for the same CPU arch on different
kernel families, but we'll cross that bridge when we get there.

BUG= chromium:819245 
TEST=Passes on soraka, caroline, grunt; NAs on kevin.

Change-Id: I86d491568ac42f0589f1e69887dbcb26c36da427
Reviewed-on: https://chromium-review.googlesource.com/951504
Commit-Ready: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>

[add] https://crrev.com/283ab94ae9c4611c74bd09787ee5140567f97b5b/client/site_tests/security_CpuVulnerabilities/security_CpuVulnerabilities.py
[add] https://crrev.com/283ab94ae9c4611c74bd09787ee5140567f97b5b/client/site_tests/security_CpuVulnerabilities/control

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c1f9eebc1945a7e5d0bc49e0f55b4e7795d3ec75

commit c1f9eebc1945a7e5d0bc49e0f55b4e7795d3ec75
Author: Jorge Lucangeli Obes <jorgelo@chromium.org>
Date: Thu Mar 15 22:27:22 2018

autotest-tests-security: Add security_CpuVulnerabilities.

BUG= chromium:819245 
TEST=Runs and passes on soraka, caroline, grunt; NAs on kevin.
CQ-DEPEND=CL:951504

Change-Id: Ic099502450c9b7b585b9f12fa1f33ba0bbe3c2dc
Reviewed-on: https://chromium-review.googlesource.com/953044
Commit-Ready: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/c1f9eebc1945a7e5d0bc49e0f55b4e7795d3ec75/chromeos-base/autotest-tests-security/autotest-tests-security-9999.ebuild

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/04cffc4658273f762183d1e1fe65327677c88ab8

commit 04cffc4658273f762183d1e1fe65327677c88ab8
Author: Jorge Lucangeli Obes <jorgelo@chromium.org>
Date: Wed Apr 11 21:55:47 2018

security_CpuVulnerabilities: Allow per-kernel-version mitigations.

Some mitigations are only included in later kernels. Support that.

BUG= chromium:819245 
TEST=Passes on eve (4.4, Spectre v1 mitigated in the kernel).
TEST=Passes on caroline (3.18, Spectre v1 not mitigated in the kernel).
TEST=Still passes on grunt.

Change-Id: I84c839a5f67719a43d7ec0e97331afd3f5239011
Reviewed-on: https://chromium-review.googlesource.com/1005855
Commit-Ready: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>

[modify] https://crrev.com/04cffc4658273f762183d1e1fe65327677c88ab8/client/site_tests/security_CpuVulnerabilities/security_CpuVulnerabilities.py

security_CpuVulnerabilities  is now failing on KBL systems (eve, nocturne) because the file contains more things than the test is expecting. 

Status: Assigned (was: Fixed)
Status: Fixed (was: Assigned)
Opened issue 880922 to track the changes, let's not reopen old bugs.

Sign in to add a comment